CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: k...@cvs.openbsd.org2020/03/10 16:31:36 Modified files: sys/dev/ic : adw.c Log message: Variables 'nowait' amd 'flags' should have died in 2008 with r1.36's removal of internal queuing of scsi_xfer's. Put them out of their misery. Nuke an obsolete comment in passing. CID 1453357.
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: k...@cvs.openbsd.org2020/03/10 15:35:41 Modified files: sys/net: route.c route.h Log message: The return value of rt_ifa_purge() is ignored, so stop returning a (possibly uninitialized) value. CID 1483466. ok millert@
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: an...@cvs.openbsd.org 2020/03/10 13:20:53 Modified files: sys/kern : init_sysent.c syscalls.c sys/sys: syscall.h syscallargs.h Log message: regen
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: an...@cvs.openbsd.org 2020/03/10 13:20:14 Modified files: sys/kern : syscalls.master Log message: Unlock fcntl(2). ok visa@
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: to...@cvs.openbsd.org 2020/03/10 12:54:52 Modified files: sbin/iked : iked.h ikev2.c policy.c Log message: Relookup policy based on received cryptographic parameter proposal. The IKEv2 responder does not know which policy is negotiated until the ID payload is received in the IKE_AUTH exchange. iked therefore chooses a default policy until the final policy is selected. This change adds a policy relookup during the IKE_SA_INIT. If the received proposal is not compatible with the default policy we switch to the next highest ranked policy that is compatible with the received proposal. ok kn@ markus@
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: js...@cvs.openbsd.org 2020/03/10 11:23:25 Modified files: lib/libssl : tls13_client.c tls13_server.c Log message: Use ctx->hs->secrets rather than the S3I(s) version. ok inoguchi@ tb@
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: js...@cvs.openbsd.org 2020/03/10 11:15:37 Modified files: regress/lib/libssl/handshake: handshake_table.c Log message: Update to follow handshake enum removal.
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: js...@cvs.openbsd.org 2020/03/10 11:15:02 Modified files: lib/libssl : tls13_handshake.c tls13_handshake.h tls13_internal.h tls13_server.c Log message: Remove some unnecessary handshake enums/functions. Both session tickets and key updates are post-handshake handshake messages, which were originally included in the handshake code. ok inoguchi@ tb@
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: js...@cvs.openbsd.org 2020/03/10 11:11:25 Modified files: lib/libssl : tls13_buffer.c Log message: Add a return value check to tls13_buffer_extend(). In the unlikely event that the return value from the read callback is larger than the number of bytes we asked for, we can end up incrementing buf->len beyond capacity. Check the return value from the read callback to prevent this. ok inoguchi@ tb@
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: js...@cvs.openbsd.org 2020/03/10 11:02:21 Modified files: lib/libssl : d1_lib.c d1_pkt.c ssl_locl.h ssl_pkt.c t1_lib.c tls13_legacy.c Log message: Remove the enc function pointers. The enc function pointers do not serve any purpose these days - remove a layer of indirection and call dtls1_enc()/tls1_enc() directly. ok inoguchi@ tb@
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: t...@cvs.openbsd.org2020/03/10 09:57:22 Modified files: sys/kern : Tag: OPENBSD_6_6 kern_sysctl.c Log message: Return EINVAL for KERN_PROC if the size parameter is 0. Prevents a panic due to a NULL dereference; Coverity CID 1452899. Based on a diff from mpi@, OK deraadt@ kettenis@ OpenBSD 6.6 errata 022 (6.6/022_sysctl.patch.sig)
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: t...@cvs.openbsd.org2020/03/10 09:57:29 Modified files: sys/kern : Tag: OPENBSD_6_5 kern_sysctl.c Log message: Return EINVAL for KERN_PROC if the size parameter is 0. Prevents a panic due to a NULL dereference; Coverity CID 1452899. Based on a diff from mpi@, OK deraadt@ kettenis@ OpenBSD 6.5 errata 032 (6.5/032_sysctl.patch.sig)
CVS: cvs.openbsd.org: www
CVSROOT:/cvs Module name:www Changes by: t...@cvs.openbsd.org2020/03/10 09:42:38 Modified files: . : errata65.html errata66.html Log message: release sysctl errata.
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: k...@cvs.openbsd.org2020/03/10 08:49:20 Modified files: sys/dev/ic : nvme.c Log message: Coverity points out (12 + MAXMPS) can never be less than 12. PAGE_SHIFT is 12 (a.k.a. PAGE_SIZE == 4096) or more on OpenBSD architectures. So remove some dead code by unconditionally setting sc_mps (memory page size) to 1 << PAGE_SHIFT. CID 1491655. No functional change.
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: j...@cvs.openbsd.org2020/03/10 08:22:27 Modified files: usr.sbin/rpki-client: extern.h output.c Log message: Narrow the visibility of some functions and variables local to output.c Also make the outputs table const. Based on a suggestion from claudio@, ok deraadt@ claudio@
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: k...@cvs.openbsd.org2020/03/10 08:08:40 Modified files: sys/dev/ic : nvmevar.h Log message: Ooops. Need both files. sgl (scatter gather list) and prpl (physical region page list) are two different things in the NVMe world. Only the latter is currently implemented in nvme(4) so rename sc_max_sgl to sc_max_prpl to reflect this. No functional change.
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: k...@cvs.openbsd.org2020/03/10 07:50:13 Modified files: sys/dev/ic : nvme.c Log message: sgl (scatter gather list) and prpl (physical region page list) are two different things in the NVMe world. Only the latter is currently implemented in nvme(4) so rename sc_max_sgl to sc_max_prpl to reflect this. No functional change.
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: inogu...@cvs.openbsd.org2020/03/10 05:13:28 Modified files: regress/lib/libcrypto/base64: base64test.c Log message: Import openssl-1.1.1d test data to base64test.c ok bcook@ tb@
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: inogu...@cvs.openbsd.org2020/03/10 05:10:53 Modified files: regress/lib/libcrypto/base64: base64test.c Log message: Modify regress base64test.c - Don't remove multi line CR/LF from bt->out when NL mode base64_encoding_test removes CR/LF from bt->out to compare with the encoding result. This is fine with NO NL mode, but it goes wrong with NL mode if encoding result is larger than 64 and multi line, like below. "eHh4eHh4eHh4eHh4eHh4eHh4eHh4eHh4eHh4eHh4eHh4eHh4eHh4eHh4eHh4eHh4\neHh4eHh4eHh4eHh4\n" - Use memcpy instead of asprintf to avoid lost '\0' at the end of data This test data loses trailing '\0' if using asprintf. "\x61\x47\x56\x73\x62\x47\x38\x3d\x0a\x00" - Print original data if decoding result comparison fails This change is not for importing test data, but I just notice. It prints bt->out if fail to memcmp bt->in with decoding result. ok bcook@ tb@
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: st...@cvs.openbsd.org 2020/03/10 04:49:08 Modified files: distrib/sets/lists/base: mi Log message: sync
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: st...@cvs.openbsd.org 2020/03/10 04:48:30 Added files: etc/signify: openbsd-68-fw.pub Log message: add 6.8 fw pubkey
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: to...@cvs.openbsd.org 2020/03/10 04:19:22 Modified files: sbin/iked : ikev2.c Log message: Make sure 'pooladdr' is zero initialized. ok markus@
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: to...@cvs.openbsd.org 2020/03/10 04:07:46 Modified files: sbin/iked : ikev2_pld.c Log message: Fix memory leak of 'cr' if allocation of 'cr->data' fails. ok markus@
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: to...@cvs.openbsd.org 2020/03/10 03:57:49 Modified files: sbin/iked : ikev2.c Log message: Make sure ikev2_next_payload() is only called when there is a previous payload. Not doing so may result in a nullptr dereference. ok gerhard@
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: to...@cvs.openbsd.org 2020/03/10 03:46:35 Modified files: sbin/iked : ikev2.c Log message: Return when SA lookup fails in ikev2_init_recv(). ok patrick@ markus@
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: to...@cvs.openbsd.org 2020/03/10 03:42:40 Modified files: sbin/iked : ikev2_msg.c Log message: Delete dead code in ikev2_msg_valid_ike_sa(). ok markus@
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: to...@cvs.openbsd.org 2020/03/10 03:35:21 Modified files: sbin/iked : ikev2_msg.c Log message: Make sure 'e' is NULL initialized to prevent nullptr dereference in ibuf_release(). ok gerhard@
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: to...@cvs.openbsd.org 2020/03/10 03:11:55 Modified files: sys/net: if.c Log message: Properly exit loop at end of hooks TAILQ. Feedback from and ok dlg@ ok kn@ todd@
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: to...@cvs.openbsd.org 2020/03/10 02:45:28 Modified files: sys/net: ifq.c Log message: Make sure return value 'error' is initialized to '0'. ok dlg@ deraadt@
CVS: cvs.openbsd.org: src
CVSROOT:/cvs Module name:src Changes by: to...@cvs.openbsd.org 2020/03/10 02:41:20 Modified files: sys/dev: softraid.c Log message: Remove unused argument to sr_error. ok kn@ deraadt@