CVS: cvs.openbsd.org: src

2020-07-20 Thread Visa Hankala
CVSROOT:/cvs
Module name:src
Changes by: v...@cvs.openbsd.org2020/07/20 23:56:02

Modified files:
sys/arch/loongson/loongson: generic3a_machdep.c 

Log message:
Do not bother masking IPIs in the Loongson 3A specific IPI routine.
The interrupt dispatcher interrupt() keeps interrupts disabled anyway.
Also, the IPI code should not allow nesting of interrupts.



CVS: cvs.openbsd.org: src

2020-07-20 Thread Nicholas Marriott
CVSROOT:/cvs
Module name:src
Changes by: n...@cvs.openbsd.org2020/07/20 23:24:33

Modified files:
usr.bin/tmux   : cmd-save-buffer.c screen-write.c tmux.h utf8.c 

Log message:
Fix show-buffer when run from inside tmux, GitHub issue 2314.



CVS: cvs.openbsd.org: src

2020-07-20 Thread Theo de Raadt
CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2020/07/20 22:08:37

Modified files:
sbin/fdisk : Makefile 

Log message:
extra garbage line found during archeology



CVS: cvs.openbsd.org: src

2020-07-20 Thread Theo de Raadt
CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2020/07/20 21:48:07

Modified files:
sys/arch/amd64/amd64: acpi_machdep.c 
sys/arch/i386/i386: acpi_machdep.c 
sys/dev/acpi   : acpi.c acpiec.c dsdt.c 

Log message:
acpi can use IPL_BIO (a low interrupt) since it only enqueues operations for
later processing.  The use of a high interrupt will predate suspend/resume
efforts, we had to redesign acpi to be non-reentrant obviously
discussed with kettenis, in snaps for more than a week



CVS: cvs.openbsd.org: src

2020-07-20 Thread Kenneth R Westerback
CVSROOT:/cvs
Module name:src
Changes by: k...@cvs.openbsd.org2020/07/20 20:04:33

Modified files:
sys/arch/sparc64/dev: vdsk.c 

Log message:
It's saa_flags, not flags.

Encountered by deraadt@



CVS: cvs.openbsd.org: src

2020-07-20 Thread Klemens Nanni
CVSROOT:/cvs
Module name:src
Changes by: k...@cvs.openbsd.org2020/07/20 19:09:03

Modified files:
usr.sbin/tcpdump: print-null.c 

Log message:
Avoid integer underflow due to tiny snaplen

For DLT_NULL and DLT_LOOP interfaces, print-null.c passes
`caplen - NULL_HDRLEN' as length to default_print() which takes an unsigned
integer, hence if caplen is smaller than the header itself (four octets),
this difference wraps around.

Exit early in such cases and print the expected truncation marker "[|null]"
instead.

Feedback OK dlg



CVS: cvs.openbsd.org: src

2020-07-20 Thread Theo de Raadt
CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2020/07/20 16:40:53

Modified files:
sys/kern   : kern_tc.c 

Log message:
ramdisks got broken by that last diff.



CVS: cvs.openbsd.org: src

2020-07-20 Thread Scott Soule Cheloha
CVSROOT:/cvs
Module name:src
Changes by: chel...@cvs.openbsd.org 2020/07/20 15:51:34

Modified files:
sys/kern   : kern_tc.c 

Log message:
timecounting: add missing mutex assertion to tc_update_timekeep()



CVS: cvs.openbsd.org: src

2020-07-20 Thread Scott Soule Cheloha
CVSROOT:/cvs
Module name:src
Changes by: chel...@cvs.openbsd.org 2020/07/20 15:43:02

Modified files:
sys/kern   : kern_tc.c 

Log message:
timecounting: misc. cleanup in tc_setclock() and tc_setrealtimeclock()

- Use real variable names like "utc" and "uptime" instead of non-names
like "bt" and "bt2"
- Move the TIMESPEC_TO_BINTIME(9) conversions out of the critical
section
- Sprinkle in a little whitespace
- Sort automatic variables according to style(9)



Re: CVS: cvs.openbsd.org: src

2020-07-20 Thread Tobias Heider
On Mon, Jul 20, 2020 at 03:24:46PM -0600, Tobias Heider wrote:
> CVSROOT:  /cvs
> Module name:  src
> Changes by:   to...@cvs.openbsd.org   2020/07/20 15:24:46
> 
> Modified files:
>   sbin/iked  : parse.y 
> 
> Log message:
> Fix dst/src port configuration bug with multiple flows.
> 
> ok patrick@
> 

Reported by Anton Kasimov 



CVS: cvs.openbsd.org: src

2020-07-20 Thread Tobias Heider
CVSROOT:/cvs
Module name:src
Changes by: to...@cvs.openbsd.org   2020/07/20 15:24:46

Modified files:
sbin/iked  : parse.y 

Log message:
Fix dst/src port configuration bug with multiple flows.

ok patrick@



CVS: cvs.openbsd.org: src

2020-07-20 Thread Kenneth R Westerback
CVSROOT:/cvs
Module name:src
Changes by: k...@cvs.openbsd.org2020/07/20 14:38:10

Modified files:
sys/dev/ic : aac.c 

Log message:
Neither is saa.ssa.pool the same as saa.saa_pool.



CVS: cvs.openbsd.org: src

2020-07-20 Thread Kenneth R Westerback
CVSROOT:/cvs
Module name:src
Changes by: k...@cvs.openbsd.org2020/07/20 14:33:10

Modified files:
sys/arch/luna88k/dev: mb89352.c 
sys/arch/sparc64/dev: vdsk.c 

Log message:
saa.ssa.wwpn is not the same as saa.saa_wwpn.

Typo broke miod's luna88k build. Would have broken next sparc64 build.



CVS: cvs.openbsd.org: src

2020-07-20 Thread Todd C . Miller
CVSROOT:/cvs
Module name:src
Changes by: mill...@cvs.openbsd.org 2020/07/20 12:57:19

Modified files:
usr.bin/awk: run.c 

Log message:
If closefile() is called on std{in,out,err}, freopen() /dev/null instead.
Otherwise, awk will continue trying to perform I/O on a closed stdio stream.
This appears to be consistent with how gawk behaves.  OK tim@



CVS: cvs.openbsd.org: src

2020-07-20 Thread Todd C . Miller
CVSROOT:/cvs
Module name:src
Changes by: mill...@cvs.openbsd.org 2020/07/20 12:55:15

Modified files:
usr.bin/awk: run.c 

Log message:
In closeall(), skip stdin and flush std{err,out} instead of closing.
Otherwise awk could fclose(stdin) twice (it may appear more than once)
and closing stderr means awk cannot report errors closing other streams.
OK tim@



CVS: cvs.openbsd.org: src

2020-07-20 Thread Theo de Raadt
CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2020/07/20 12:42:30

Modified files:
sys/kern   : tty.c 

Log message:
cleanup ttrstrt; no functional change; ok dlg



CVS: cvs.openbsd.org: src

2020-07-20 Thread Theo de Raadt
CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2020/07/20 11:57:46

Modified files:
sys/arch/powerpc64/conf: Makefile.powerpc64 

Log message:
improve accuracy of kexec_subr.o dependency



CVS: cvs.openbsd.org: src

2020-07-20 Thread Theo de Raadt
CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2020/07/20 11:55:28

Modified files:
sys/kern   : subr_prf.c 

Log message:
fix macro indent



CVS: cvs.openbsd.org: src

2020-07-20 Thread Theo de Raadt
CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2020/07/20 11:42:33

Modified files:
regress/sys/kern/stackpivot: Makefile 

Log message:
Improve MACHINE/MACHINE_ARCH access to actually testing architectures



CVS: cvs.openbsd.org: src

2020-07-20 Thread Theo de Raadt
CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2020/07/20 11:37:17

Modified files:
regress/sys/kern/stackpivot/syscall: stackpivot.c 

Log message:
test _exit(2) rather than exit(3) [to keep things simpler], and
print the stack address [for comparison in dmesg post-fault]



CVS: cvs.openbsd.org: src

2020-07-20 Thread Theo de Raadt
CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2020/07/20 11:18:51

Modified files:
sys/arch/powerpc64/powerpc64: trap.c 

Log message:
Add uvm_map_inentry call, to detect stack pivots at trap time.
ok kettenis



CVS: cvs.openbsd.org: www

2020-07-20 Thread Theo Buehler
CVSROOT:/cvs
Module name:www
Changes by: t...@cvs.openbsd.org2020/07/20 10:41:54

Modified files:
faq: faq4.html 

Log message:
remove XXXrelease for .fs -> .img renaming



CVS: cvs.openbsd.org: www

2020-07-20 Thread T . J . Townsend
CVSROOT:/cvs
Module name:www
Changes by: t...@cvs.openbsd.org2020/07/20 10:29:38

Modified files:
faq: faq1.html 

Log message:
add powerpc64



CVS: cvs.openbsd.org: src

2020-07-20 Thread Kenneth R Westerback
CVSROOT:/cvs
Module name:src
Changes by: k...@cvs.openbsd.org2020/07/20 10:09:48

Modified files:
sys/dev/ic : aic7xxx_openbsd.c 

Log message:
Missed a chunk somewhere along the line. Use our_id vs our_id_b in
appropriate spots. Don't copy one empty/unused scsi_link (channel) to
another empty/unused scsi_link (channel_b)



CVS: cvs.openbsd.org: www

2020-07-20 Thread T . J . Townsend
CVSROOT:/cvs
Module name:www
Changes by: t...@cvs.openbsd.org2020/07/20 09:54:19

Modified files:
build  : versionup 

Log message:
add powerpc64.html and switch usb files from .fs to .img



CVS: cvs.openbsd.org: www

2020-07-20 Thread T . J . Townsend
CVSROOT:/cvs
Module name:www
Changes by: t...@cvs.openbsd.org2020/07/20 09:53:35

Modified files:
.  : powerpc64.html 

Log message:
add XXX reminders for 6.8 and fix more typos



CVS: cvs.openbsd.org: src

2020-07-20 Thread Theo de Raadt
CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2020/07/20 08:55:43

Modified files:
distrib/special/installboot: Makefile 

Log message:
build powerpc version, also



CVS: cvs.openbsd.org: src

2020-07-20 Thread Ingo Schwarze
CVSROOT:/cvs
Module name:src
Changes by: schwa...@cvs.openbsd.org2020/07/20 08:52:12

Modified files:
usr.bin/mandoc : apropos.1 man.1 mandoc.1 

Log message:
as jmc@ points out, i missed a few instances of .Xr more 1



CVS: cvs.openbsd.org: src

2020-07-20 Thread Kenneth R Westerback
CVSROOT:/cvs
Module name:src
Changes by: k...@cvs.openbsd.org2020/07/20 08:41:14

Modified files:
sys/arch/luna88k/dev: mb89352.c 
sys/arch/sparc64/dev: vdsk.c 
sys/dev: softraid.c vscsi.c 
sys/dev/ata: atascsi.c 
sys/dev/atapiscsi: atapiscsi.c 
sys/dev/ic : aac.c adv.c adw.c aic6250.c aic6360.c 
 aic79xx_openbsd.c aic7xxx_openbsd.c ami.c cac.c 
 ciss.c gdt_common.c mfi.c mpi.c ncr53c9x.c 
 nvme.c oosiop.c osiop.c qla.c qlw.c siop.c 
 twe.c uha.c wd33c93.c 
sys/dev/isa: wds.c 
sys/dev/pci: arc.c iha_pci.c ips.c mfii.c mpii.c qle.c 
 trm_pci.c vmwpvs.c 
sys/dev/pv : hvs.c vioblk.c vioscsi.c xbf.c 
sys/dev/sdmmc  : sdmmc_scsi.c 
sys/dev/usb: umass_scsi.c 
sys/scsi   : mpath.c scsiconf.c scsiconf.h 

Log message:
Move remaining scsi bus initialization info from "prototype scsi link"
fields to struct scsibus_attach_args. Nuke the struct scsi_link *
(saa_sc_link) in scaibus_attach_args.

Explicitly initialize each field in scsibus_attach_args variables.



CVS: cvs.openbsd.org: src

2020-07-20 Thread Theo de Raadt
CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2020/07/20 08:34:16

Modified files:
sys/kern   : tty.c tty_pty.c 

Log message:
Sigh. Only the ptyc case should tsleep in ttyretype, since others can
arrive in the wrong context.  Found by jcs.



CVS: cvs.openbsd.org: src

2020-07-20 Thread Ingo Schwarze
CVSROOT:/cvs
Module name:src
Changes by: schwa...@cvs.openbsd.org2020/07/20 08:25:22

Modified files:
usr.bin/mandoc : apropos.1 main.c man.1 mandoc.1 

Log message:
Switch the default pager from "more -s" to "less".

POSIX explicitly allows using a different default pager if that
is documented.  The pager provided in the OpenBSD base system is
less(1).  It can merely be called as more(1) for compatibility.
Our man(1) implementation uses less(1) features that traditional
more(1) did not provide, in particular tagging.  Besides, as noted
by deraadt@, the user interface of less(1) is slightly more refined
and preferable over the user inferface of more(1).
This switch was originally suggested by Ian Ropers.

As explained by jmc@ and deraadt@, the -s flag was added a very
long time ago when an antique version of groff(1) had an annoying
bug in terminal output that would randomly display blank lines in
the middle of pages.  Clearly, -s has no longer been needed for
many years, so drop it from the default pager invocation.

OK deraadt@ jmc@ martijn@ job@



CVS: cvs.openbsd.org: src

2020-07-20 Thread Klemens Nanni
CVSROOT:/cvs
Module name:src
Changes by: k...@cvs.openbsd.org2020/07/20 08:21:51

Modified files:
sbin/pfctl : pfctl.8 

Log message:
Mention hostid and checksum

Complete the description of "-s info -v" such that grepping for them
in the manual pager yields something.

Feedback jmc
OK sashan



CVS: cvs.openbsd.org: src

2020-07-20 Thread Frederic Cambus
CVSROOT:/cvs
Module name:src
Changes by: fcam...@cvs.openbsd.org 2020/07/20 08:09:24

Modified files:
usr.sbin/wsfontload: wsfontload.c 

Log message:
Add a new column to wsfontload -l output, to report the number of
characters contained in a loaded font.

It's especially useful with user loaded fonts as they can contain
more than 256 characters.

OK sthen@



CVS: cvs.openbsd.org: src

2020-07-20 Thread Vitaliy Makkoveev
CVSROOT:/cvs
Module name:src
Changes by: m...@cvs.openbsd.org2020/07/20 07:55:33

Modified files:
sys/net: if.c 

Log message:
Move insertions to `if_list' out of NET_LOCK() because KERNEL_LOCK()
protects this list. Also corresponding assertion added to be sure the
required lock was held.

This is the step to clean locking mess around `if_list'.

Also we are going to protect `if_list' by it's own lock and this will
allow us to avoid lock order issues in future.

ok dlg@



CVS: cvs.openbsd.org: src

2020-07-20 Thread Frederic Cambus
CVSROOT:/cvs
Module name:src
Changes by: fcam...@cvs.openbsd.org 2020/07/20 07:34:31

Modified files:
sys/dev/wsfont : spleen12x24.h spleen16x32.h spleen32x64.h 
 spleen5x8.h spleen6x12.h spleen8x16.h 

Log message:
Update Spleen kernel fonts to version 1.8.1, bringing the following
improvements:

- Center tilde vertically for all sizes, as modern fonts do



CVS: cvs.openbsd.org: src

2020-07-20 Thread Stuart Henderson
CVSROOT:/cvs
Module name:src
Changes by: st...@cvs.openbsd.org   2020/07/20 07:15:24

Modified files:
sbin/iked  : parse.y 

Log message:
iked: fix typo in fatalx



CVS: cvs.openbsd.org: src

2020-07-20 Thread Frederic Cambus
CVSROOT:/cvs
Module name:src
Changes by: fcam...@cvs.openbsd.org 2020/07/20 06:40:45

Modified files:
sys/dev/rasops : rasops.c rasops32.c rasops_bitops.h 

Log message:
Fix various whitespace and formatting issues in rasops(9).



CVS: cvs.openbsd.org: www

2020-07-20 Thread Landry Breuil
CVSROOT:/cvs
Module name:www
Changes by: lan...@cvs.openbsd.org  2020/07/20 06:27:14

Modified files:
.  : powerpc64.html 

Log message:
fix typo



CVS: cvs.openbsd.org: www

2020-07-20 Thread Mark Kettenis
CVSROOT:/cvs
Module name:www
Changes by: kette...@cvs.openbsd.org2020/07/20 06:02:35

Modified files:
.  : plat.html 
Added files:
.  : powerpc64.html 

Log message:
Mention OpenBSD/powerpc64.



CVS: cvs.openbsd.org: src

2020-07-20 Thread Stefan Sperling
CVSROOT:/cvs
Module name:src
Changes by: s...@cvs.openbsd.org2020/07/20 02:22:06

Modified files:
sys/dev/pci: if_iwn.c 

Log message:
KNF for multi-line comment added to iwn5000_set_gains() in previous commit.



CVS: cvs.openbsd.org: src

2020-07-20 Thread Stefan Sperling
CVSROOT:/cvs
Module name:src
Changes by: s...@cvs.openbsd.org2020/07/20 02:19:59

Modified files:
sys/dev/pci: if_iwn.c 

Log message:
Fix gain calibration for some iwn(4) devices (5000 and up).

IWN_LSB() returns an index starting with 1, however the arrays used
later on (noise and gain in iwn5000_set_gains()) start with 0. The
previous code accounted for this difference when setting the antenna
gain by accessing cmd.gain[i - 1]. However the noise array was accessed
with noise[i], the chainmask was checked against i, and more importantly
the overall for() loop iterated wrongly over the antennas by always
starting with i=2 (the third antenna). One consequence is that gain
calibration never happened in case of only two antennas.

Patch by Holger Mikolon.



CVS: cvs.openbsd.org: src

2020-07-20 Thread Mark Kettenis
CVSROOT:/cvs
Module name:src
Changes by: kette...@cvs.openbsd.org2020/07/20 02:14:53

Modified files:
share/mk   : bsd.own.mk 

Log message:
Add powerpc64 to PIE_ARCH and STATICPIE_ARCH.

ok drahn@



CVS: cvs.openbsd.org: src

2020-07-20 Thread Stefan Sperling
CVSROOT:/cvs
Module name:src
Changes by: s...@cvs.openbsd.org2020/07/20 02:09:30

Modified files:
sys/dev/pci: if_iwn.c 

Log message:
Fix a logic bug in iwn(4) which meant that automatic rate control for
A-MPDU ran while a fixed Tx MCS was configured. The intention was of
course the inverse: Use automatic rate control if Tx MCS is not fixed.

There is a second bug which went unnoticed because of the above bug.
The value of 'seq' provided by firmware may be smaller than ba_winstart.
When this happened it triggered a KASSERT in ieee80211_output_ba_record_ack.
iwn_ampdu_rate_control() implicitly assumes that its 'seq' parameter equals
ba_winstart, so just pass that value directly.

tested by bket@, jmc@, and myself
ok mpi@



CVS: cvs.openbsd.org: src

2020-07-20 Thread Stefan Sperling
CVSROOT:/cvs
Module name:src
Changes by: s...@cvs.openbsd.org2020/07/20 02:04:41

Modified files:
sys/dev/pci: if_iwn.c 

Log message:
update a comment in iwn_ampdu_tx_done following previous SSN -> SEQ change



CVS: cvs.openbsd.org: src

2020-07-20 Thread Stefan Sperling
CVSROOT:/cvs
Module name:src
Changes by: s...@cvs.openbsd.org2020/07/20 02:00:38

Modified files:
sys/dev/pci: if_iwn.c 

Log message:
Make iwn_ampdu_tx_done() record an ACK for the frame for which the hardware
triggered the Tx completion interrupt, instead of the frame with the starting
sequence number (SSN) of the firmware's block ack window. The frame at SSN
is unrelated and may not even have been transmitted yet.

tested by bket@, jmc@, and myself
ok mpi@



CVS: cvs.openbsd.org: src

2020-07-20 Thread Stefan Sperling
CVSROOT:/cvs
Module name:src
Changes by: s...@cvs.openbsd.org2020/07/20 01:45:44

Modified files:
sys/dev/ic : bwfm.c rt2560.c rt2661.c 
sys/net80211   : ieee80211_input.c 

Log message:
The IEEE80211_F_HIDENWID flag is now part of ic_userflags, not ic_flags.
Fix code which was still looking for this flag at the old location.

The 'hidenwid' feature was slightly broken as a result: The SSID was leaked
in probe responses to wildcard probe requests. There are other trivial ways
of snooping a "hidden" SSID however so this is not a big deal.

Problem reported by Mogens Jensen.