Re: CVS: cvs.openbsd.org: src

2021-10-12 Thread Anton Lindqvist
On Tue, Oct 12, 2021 at 09:16:45AM -0600, Job Snijders wrote:
> CVSROOT:  /cvs
> Module name:  src
> Changes by:   j...@cvs.openbsd.org2021/10/12 09:16:45
> 
> Modified files:
>   usr.sbin/rpki-client: cert.c extern.h output-json.c x509.c 
> 
> Log message:
> Emit SKI in the JSON output and improve flow in x509_get_pubkey()
> 
> OK claudio@

This broke regress, feel free to commit.

Index: test-cert.c
===
RCS file: /cvs/src/regress/usr.sbin/rpki-client/test-cert.c,v
retrieving revision 1.12
diff -u -p -r1.12 test-cert.c
--- test-cert.c 11 Oct 2021 17:32:27 -  1.12
+++ test-cert.c 13 Oct 2021 05:28:20 -
@@ -57,8 +57,8 @@ cert_print(const struct cert *p)
printf("caRepository: %s\n", p->repo);
if (p->notify != NULL)
printf("Notify URL: %s\n", p->notify);
-   if (p->bgpsec_pubkey != NULL)
-   printf("BGPsec P-256 ECDSA public key: %s\n", p->bgpsec_pubkey);
+   if (p->pubkey != NULL)
+   printf("BGPsec P-256 ECDSA public key: %s\n", p->pubkey);
strftime(tbuf, sizeof(tbuf), "%FT%TZ", gmtime(>expires));
printf("Valid until: %s\n", tbuf);
 



CVS: cvs.openbsd.org: src

2021-10-12 Thread Alexander Bluhm
CVSROOT:/cvs
Module name:src
Changes by: bl...@cvs.openbsd.org   2021/10/12 16:44:48

Modified files:
regress/usr.sbin/syslogd: args-server-tls-error.pl 

Log message:
Relax test regex, read or write error is possible.



CVS: cvs.openbsd.org: src

2021-10-12 Thread Mark Kettenis
CVSROOT:/cvs
Module name:src
Changes by: kette...@cvs.openbsd.org2021/10/12 12:22:04

Modified files:
sys/dev/pci/drm: drm_gem.c 
sys/dev/pci/drm/ttm: ttm_bo_vm.c 

Log message:
Remove misleading uvm reference counting that isn't actually used.
Make sure uvm_obj_init() is only called once.  Call uvm_obj_destroy()
when we release the GEM object that wraps an uvm object for which we
called uvm_obj_init().

ok mpi@, jsg@



CVS: cvs.openbsd.org: src

2021-10-12 Thread Mark Kettenis
CVSROOT:/cvs
Module name:src
Changes by: kette...@cvs.openbsd.org2021/10/12 12:16:51

Modified files:
sys/uvm: uvm_object.c uvm_object.h 

Log message:
Introduce a dummy uvm_obj_destroy() interface.  This function will be
used in the near future (by mpi@) to improve the locking for uvm objects.
Introducing this function now will me allow me to call it in the
appropriate place in the drm code.

ok mpi@, jsg@



CVS: cvs.openbsd.org: src

2021-10-12 Thread Mark Kettenis
CVSROOT:/cvs
Module name:src
Changes by: kette...@cvs.openbsd.org2021/10/12 12:06:15

Modified files:
sys/arch/powerpc64/include: pmap.h 
sys/arch/powerpc64/powerpc64: pmap.c 

Log message:
Add (minimal) accounting for wired pages in userland pmaps.
This enables enforcing of RLIMIT_MEMLOCK on powerpc64.

ok mpi@



CVS: cvs.openbsd.org: www

2021-10-12 Thread T . J . Townsend
CVSROOT:/cvs
Module name:www
Changes by: t...@cvs.openbsd.org2021/10/12 11:49:42

Modified files:
.  : ftp.html httpslist 
build  : mirrors.dat 
openbgpd   : ftp.html 
openntpd   : portable.html 
openssh: ftp.html portable.html 
rpki-client: portable.html 

Log message:
remove syringanetworks' https entry since their cert has been expired
for two months



CVS: cvs.openbsd.org: src

2021-10-12 Thread Theo de Raadt
CVSROOT:/cvs
Module name:src
Changes by: dera...@cvs.openbsd.org 2021/10/12 10:39:22

Modified files:
etc/etc.armv7  : disktab 
distrib/armv7/miniroot: Makefile.inc 

Log message:
make armv7 fit again after bootblock growth; discussed with jsg



CVS: cvs.openbsd.org: src

2021-10-12 Thread Job Snijders
CVSROOT:/cvs
Module name:src
Changes by: j...@cvs.openbsd.org2021/10/12 09:16:45

Modified files:
usr.sbin/rpki-client: cert.c extern.h output-json.c x509.c 

Log message:
Emit SKI in the JSON output and improve flow in x509_get_pubkey()

OK claudio@



CVS: cvs.openbsd.org: src

2021-10-12 Thread Visa Hankala
CVSROOT:/cvs
Module name:src
Changes by: v...@cvs.openbsd.org2021/10/12 08:06:05

Modified files:
gnu/usr.bin/binutils-2.17/bfd: elfxx-mips.c 

Log message:
Do not extend PT_DYNAMIC segment on mips64

The IRIX-specific extension of the PT_DYNAMIC segment is not needed
by the dynamic linker on OpenBSD/mips64. Disable it so that the .dynamic
section stays at the start of the PT_DYNAMIC segment even when .dynstr,
.dynsym or .hash precedes .dynamic in the ELF file. This enables
Binutils 2.17 tools, such as strip(1), rewrite executables and shared
libraries that have been produced by LLD.

OK kettenis@



CVS: cvs.openbsd.org: src

2021-10-12 Thread Landry Breuil
CVSROOT:/cvs
Module name:src
Changes by: lan...@cvs.openbsd.org  2021/10/12 05:20:33

Modified files:
sys/dev/pci: if_iwm.c 

Log message:
iwm(4): revert to use firmware v17 on Intel AC 7265.

fixes instability issues seen on X1 carbon gen3 (hw rev 0x210) by
anton@, mpi@ and myself.
diff from stsp@
ok mpi@ stsp@



CVS: cvs.openbsd.org: src

2021-10-12 Thread Stefan Sperling
CVSROOT:/cvs
Module name:src
Changes by: s...@cvs.openbsd.org2021/10/12 04:46:57

Modified files:
sys/dev/pci: if_iwx.c if_iwxvar.h 

Log message:
Make our old BSSID available to iwx_newstate_task() when roaming.

ic_bss->ni_bssid has already been overwritten once we enter
iwx_newstate_task() to perform the state transitions necessary
for roaming to our new access point (RUN->AUTH->ASSOC->RUN).

We do however use the BSSID in commands sent to firmware.
Cache our BSSID in struct iwx_node such that firmware commands
keep using the old BSSID while we are still tearing things down.
Switch to the new BSSID only once we start back up in iwx_auth().
This should be consistent from the firmware's point of view.

Same fix as committed for iwm(4) recently.



CVS: cvs.openbsd.org: src

2021-10-12 Thread Stefan Sperling
CVSROOT:/cvs
Module name:src
Changes by: s...@cvs.openbsd.org2021/10/12 04:45:21

Modified files:
sys/dev/pci: if_iwx.c 

Log message:
Explicitly stop iwx(4) Rx block ack when roaming between access points.

This is similar to a recent fix committed to iwm(4).
Unlike iwm(4) we do not need to disable Tx aggregation queues in iwx(4).
Attempting to do so would cause fatal firmware errors.

Tested by jmc@ and myself.



CVS: cvs.openbsd.org: src

2021-10-12 Thread Stefan Sperling
CVSROOT:/cvs
Module name:src
Changes by: s...@cvs.openbsd.org2021/10/12 04:44:34

Modified files:
sys/dev/pci: if_iwx.c 

Log message:
Remove code which was needed to support old firmware images from iwx(4).

Tested with cc-a0-63 and QuZ-a0-hr-b0-63 firmware by myself.
Tested with Qu-c0-hr-b0-63 firmware by Fredrik Engberg.



CVS: cvs.openbsd.org: src

2021-10-12 Thread Tobias Heider
CVSROOT:/cvs
Module name:src
Changes by: to...@cvs.openbsd.org   2021/10/12 04:01:59

Modified files:
sbin/iked  : iked.h ikev2.c policy.c 

Log message:
Change responder to prefer DH group from KE payload.
Without this change the responder would always prefer the first DH
group configured in its policy. This would lead to invalid KE
messages that cause an additional exchange which old
implementations do not support correctly. Now we ignore the order
of DH groups in the policy and prefer the group from the policy
that matches the KE payload.

from markus@
ok patrick@



CVS: cvs.openbsd.org: src

2021-10-12 Thread Tobias Heider
CVSROOT:/cvs
Module name:src
Changes by: to...@cvs.openbsd.org   2021/10/12 03:27:21

Modified files:
sbin/iked  : config.c ikev2.c parse.y 

Log message:
Make sure all copies of MSCHAPv2 passphrase are zeroed after use.

ok patrick@



CVS: cvs.openbsd.org: src

2021-10-12 Thread Marc Espie
CVSROOT:/cvs
Module name:src
Changes by: es...@cvs.openbsd.org   2021/10/12 03:06:37

Modified files:
usr.sbin/pkg_add/OpenBSD: ForwardDependencies.pm PkgAdd.pm 

Log message:
do the matching as a last resort to handle .libs
fix the bug I introduced that bluhm@ et al noticed



CVS: cvs.openbsd.org: src

2021-10-12 Thread Martin Pieuchot
CVSROOT:/cvs
Module name:src
Changes by: m...@cvs.openbsd.org2021/10/12 01:38:22

Modified files:
sys/uvm: uvm_fault.c uvm_pager.h uvm_vnode.c 

Log message:
Fix the deadlock between uvn_io() and uvn_flush() by restarting the fault.

Do not allow a faulting thread to sleep on a contended vnode lock to prevent
lock ordering issues with upcoming per-uobj lock.

Also reduce the sleep value for VM_PAGER_AGAIN from 1sec to 5nsec to not add
visible slowdown when starting a multi-threaded application with threads that
fault on the same vnode (chromium, firefox, etc).

Tested by anton@, tb@, robert@ and gnezdo@

ok anton@, tb@

Reported-by: syzbot+e63407b35dff08dbe...@syzkaller.appspotmail.com



CVS: cvs.openbsd.org: src

2021-10-12 Thread Martin Pieuchot
CVSROOT:/cvs
Module name:src
Changes by: m...@cvs.openbsd.org2021/10/12 01:37:42

Modified files:
sys/uvm: uvm_vnode.c uvm_vnode.h 

Log message:
Revert the fix for the deadlock between uvn_io() and uvn_flush().

This fix (ab)use the vnode lock to serialize access to some fields of
the corresponding pages associated with UVM vnode object and this will
create new deadlocks with the introduction of a per-uobj lock.

ok anton@