CVS: cvs.openbsd.org: src

2023-03-31 Thread Theo Buehler
CVSROOT:/cvs
Module name:src
Changes by: t...@cvs.openbsd.org2023/03/31 23:27:44

Modified files:
usr.bin/find   : function.c 

Log message:
horrible whitespace, mostly on non-code lines. no object change



CVS: cvs.openbsd.org: src

2023-03-31 Thread David Gwynne
CVSROOT:/cvs
Module name:src
Changes by: d...@cvs.openbsd.org2023/03/31 18:04:40

Modified files:
sys/dev/usb: umsm.c 

Log message:
follow quectel guidance on which usb interfaces umsm should match.

the Quectel LTE&5G Linux USB Driver User Guide V2.0 says umsm should
only attach to usb interfaces 0 to 3 using the interface class
UICLASS_VENDOR. their doco uses magic numbers, but this is what
they mean.

interfaces 4 and above provide network (not serial) via qmi, ecm,
or mbim. preventing umsm from attaching to the high interfaces
allows the appropriate network driver to use it instead. eg, umb
is now able to attach to the network interface because it presents
a standard mbim class.

discussed with and tested by kevlo@
ok patric@ sthen@ kevlo@



CVS: cvs.openbsd.org: src

2023-03-31 Thread David Gwynne
CVSROOT:/cvs
Module name:src
Changes by: d...@cvs.openbsd.org2023/03/31 17:55:45

Modified files:
sys/dev/usb: umsm.c 

Log message:
shuffle the code in umsm_match a bit.

if umsm_lookup doesnt return anything, return early and leave the
rest of umsm_match to handling specific devices.

no functional change.



CVS: cvs.openbsd.org: src

2023-03-31 Thread David Gwynne
CVSROOT:/cvs
Module name:src
Changes by: d...@cvs.openbsd.org2023/03/31 17:53:49

Modified files:
sys/dev/usb: if_umb.c 

Log message:
dont match quectel ec25 by vendor+product id

quectel seem to provide a sane and consistent set of functionality
built on top of the qualcomm qmi stuff. their linux drivers guide
says quectel modems provide a set of umsm usb interfaces and a
network interface that can be in qmi, ecm, or mbim mode.

if the modem is in mbim mode, it will present the mbim classes which
umb should be able to attach to without this explicit vendor+product
match (assuming umsm doesn't claim the interface first).

based on info in the Quectel LTE&5G Linux USB Driver User Guide V2.0

discussed with and tested by kevlo@
ok patrick@ sthen@ kevlo@



CVS: cvs.openbsd.org: src

2023-03-31 Thread Klemens Nanni
CVSROOT:/cvs
Module name:src
Changes by: k...@cvs.openbsd.org2023/03/31 14:31:35

Modified files:
sys/dev/pci: pcidevs.h pcidevs_data.h 

Log message:
regen after "BE-M1000" addition



CVS: cvs.openbsd.org: src

2023-03-31 Thread Klemens Nanni
CVSROOT:/cvs
Module name:src
Changes by: k...@cvs.openbsd.org2023/03/31 14:28:48

Modified files:
sys/dev/pci: pcidevs 

Log message:
Add "Baikal Electronics" and their "BE-M1000" SoC

OK kettenis



CVS: cvs.openbsd.org: src

2023-03-31 Thread Theo Buehler
CVSROOT:/cvs
Module name:src
Changes by: t...@cvs.openbsd.org2023/03/31 14:16:55

Modified files:
sbin/isakmpd   : ike_quick_mode.c 

Log message:
Add missing NULL check after group_get()

Otherwise dh_getlen() will dereference ie->group and crash.

looks correct to hshoexer



CVS: cvs.openbsd.org: src

2023-03-31 Thread Marcus Glocker
CVSROOT:/cvs
Module name:src
Changes by: mgloc...@cvs.openbsd.org2023/03/31 13:50:46

Modified files:
sys/arch/arm64/conf: RAMDISK 

Log message:
Enable ufshci(4).

ok kettenis@



CVS: cvs.openbsd.org: src

2023-03-31 Thread Alexander Bluhm
CVSROOT:/cvs
Module name:src
Changes by: bl...@cvs.openbsd.org   2023/03/31 13:43:33

Modified files:
sys/netinet6   : nd6.c nd6_nbr.c nd6_rtr.c 

Log message:
Fix white space.



CVS: cvs.openbsd.org: src

2023-03-31 Thread Theo Buehler
CVSROOT:/cvs
Module name:src
Changes by: t...@cvs.openbsd.org2023/03/31 13:40:09

Modified files:
regress/lib/libcrypto/bn: bn_unit.c 

Log message:
Add regress coverage for the new behavior of BN_copy() with respect to
flags.



CVS: cvs.openbsd.org: src

2023-03-31 Thread Theo Buehler
CVSROOT:/cvs
Module name:src
Changes by: t...@cvs.openbsd.org2023/03/31 13:39:15

Modified files:
lib/libcrypto/bn: bn_lib.c 

Log message:
Copy BN_FLG flags in BN_copy()

BN_copy() forgot to copy the flags from the source to the target. Fix
this by copying the flags. In fact, only copy BN_FLG_CONSTTIME since
propagating BN_FLG_MALLOCED and BN_FLG_STATIC_DATA is wrong. Ignore the
BN_FLG_FREE flag "used for debugging" which of course means "unused"
like a lot of other debug code that somehow ended up in public headers.

Also: make BN_FLG_CONSTTIME sticky on the target, i.e., don't clear the
flag when copying from a non-constant time BIGNUM to a constant time one
for the following reason: if a is constant time, BN_sqr(a, a, ctx) would
use a BIGNUM without the flag internally, then copy the result to a in
which process a would lose its constant time flag.

Fixing this would be a lot of pointless work since someone had the good
sense of not relying on a fragile flag for something this important.
Rather, libcrypto always uses the constant time paths instead of the
faster, cryptographically inadequate paths.

Before this was changed, this was a pretty bad bug. The RSA code uses the
horrible BN_with_flags() function to create local versions of the private
moduli and set BN_FLG_CONSTTIME on them. If the RSA_FLAG_CACHE_PRIVATE for
caching moduli is set on the RSA, which it is by default, it attempts to
set these constant time versions on the RSA's internal Montgomery contexts.
Since it is called BN_MONT_CTX_set(), the setter doesn't set a BIGNUM on
the BN_MONT_CTX, rather it copies it over, losing the BN_FLG_CONSTTIME flag
in the process and make all the horrible leaky RSA code leak some more.
Good job.

This is all harmless and is mostly a cosmetic fix. BN_FLG_CONSTTIME should
be removed internally. It will be kept since various language bindings of
course picked it up and expose it.

ok beck jsing



CVS: cvs.openbsd.org: src

2023-03-31 Thread Kenneth R Westerback
CVSROOT:/cvs
Module name:src
Changes by: k...@cvs.openbsd.org2023/03/31 13:12:32

Modified files:
sbin/fdisk : part.c 

Log message:
Refactor partition type menu code, disentangling mbr and gpt
partition types from menu building and display.

Some GPT partition names change to match their MBR bretheren.

No intentional functional change.



CVS: cvs.openbsd.org: src

2023-03-31 Thread Mark Kettenis
CVSROOT:/cvs
Module name:src
Changes by: kette...@cvs.openbsd.org2023/03/31 12:49:43

Modified files:
lib/libc/arch/aarch64: Makefile.inc 

Log message:
Since all arm64 assembly code in libc uses the ENTRY* macros from
 they are already get the necessary "bti c" instructions.
Passi the -mmark-bti-property option to mark the corresponding object
files as having BTI support.

ok deraadt@



CVS: cvs.openbsd.org: src

2023-03-31 Thread Mark Kettenis
CVSROOT:/cvs
Module name:src
Changes by: kette...@cvs.openbsd.org2023/03/31 12:46:24

Modified files:
lib/csu/aarch64: md_init.h 

Log message:
Add "bti c" where needed for BTI control flow integrety checks.

ok deraadt@



CVS: cvs.openbsd.org: src

2023-03-31 Thread Mark Kettenis
CVSROOT:/cvs
Module name:src
Changes by: kette...@cvs.openbsd.org2023/03/31 12:45:05

Modified files:
libexec/ld.so/aarch64: ldasm.S 

Log message:
Call entry point of the executable through register x17.  This allows it
to be a normal C function that starts with "bti c" when BTI contro flow
integretry enforcement is in place.  Add "bti c" to _dl_bind_start().

Remove unused _rtld_tlsdesc() function to avoid having to add "bti c" to it.

ok deraadt@



CVS: cvs.openbsd.org: src

2023-03-31 Thread Theo Buehler
CVSROOT:/cvs
Module name:src
Changes by: t...@cvs.openbsd.org2023/03/31 11:47:39

Modified files:
lib/libcrypto/ts: ts_verify_ctx.c 

Log message:
Inline only use of TS_VERIFY_CTX_init()

Since TS_VERIFY_CTX is now opaque, the only thing TS_VERIFY_CTX_init()
is good for outside the library is memory leaks. Inside the library it's
also useless, since as a much more familiar name is memset(). It will soon
be able to join all the other nonsense that should never have leaked out of
this library.



CVS: cvs.openbsd.org: www

2023-03-31 Thread Stuart Henderson
CVSROOT:/cvs
Module name:www
Changes by: st...@cvs.openbsd.org   2023/03/31 10:51:40

Modified files:
.  : anoncvs.html 

Log message:
sync



CVS: cvs.openbsd.org: www

2023-03-31 Thread Stuart Henderson
CVSROOT:/cvs
Module name:www
Changes by: st...@cvs.openbsd.org   2023/03/31 10:51:32

Modified files:
build  : mirrors.dat 

Log message:
remove some anoncvs servers which are no more, with beck@



CVS: cvs.openbsd.org: src

2023-03-31 Thread Kenneth R Westerback
CVSROOT:/cvs
Module name:src
Changes by: k...@cvs.openbsd.org2023/03/31 08:41:08

Modified files:
sbin/fdisk : part.c 

Log message:
Oops. Missed eliminating unneeded double quotes in previous.



CVS: cvs.openbsd.org: src

2023-03-31 Thread Jason McIntyre
CVSROOT:/cvs
Module name:src
Changes by: j...@cvs.openbsd.org2023/03/31 07:48:34

Modified files:
share/man/man4 : igc.4 udl.4 usb.4 wscons.4 

Log message:
remove the whitespace in weird " / " constructs;



CVS: cvs.openbsd.org: src

2023-03-31 Thread Jason McIntyre
CVSROOT:/cvs
Module name:src
Changes by: j...@cvs.openbsd.org2023/03/31 07:45:13

Modified files:
share/man/man4 : ngbe.4 

Log message:
remove some unneccessary words and whitespace;



CVS: cvs.openbsd.org: src

2023-03-31 Thread Mark Kettenis
CVSROOT:/cvs
Module name:src
Changes by: kette...@cvs.openbsd.org2023/03/31 07:37:41

Modified files:
sys/dev/mii: miidevs.h 

Log message:
regen



CVS: cvs.openbsd.org: src

2023-03-31 Thread Mark Kettenis
CVSROOT:/cvs
Module name:src
Changes by: kette...@cvs.openbsd.org2023/03/31 07:37:02

Modified files:
sys/dev/mii: miidevs 

Log message:
Add RTL8211F-VD, a new RTL8211F variant.

ok jsg@, dlg@



CVS: cvs.openbsd.org: src

2023-03-31 Thread Kenneth R Westerback
CVSROOT:/cvs
Module name:src
Changes by: k...@cvs.openbsd.org2023/03/31 07:11:41

Modified files:
sbin/fdisk : cmd.c gpt.c part.c part.h 

Log message:
Be more consistent in function naming. Functions taking or
returning struct uuid's use 'uuid' in their names.

Lengthen a pointlessly short line.

No functional change.



CVS: cvs.openbsd.org: src

2023-03-31 Thread Jonathan Gray
CVSROOT:/cvs
Module name:src
Changes by: j...@cvs.openbsd.org2023/03/31 06:35:24

Modified files:
sys/kern   : uipc_usrreq.c 

Log message:
remove unused unp_lock
ok kn@ mvs@



CVS: cvs.openbsd.org: src

2023-03-31 Thread Klemens Nanni
CVSROOT:/cvs
Module name:src
Changes by: k...@cvs.openbsd.org2023/03/31 06:07:55

Modified files:
sys/dev/fdt: gpiokeys.c 

Log message:
Flip label separators to fix previous

-gpiokeys0 at mainbus0, "PWR Button"
+gpiokeys0 at mainbus0: "PWR Button"

OK patrick



CVS: cvs.openbsd.org: src

2023-03-31 Thread Claudio Jeker
CVSROOT:/cvs
Module name:src
Changes by: clau...@cvs.openbsd.org 2023/03/31 03:55:39

Modified files:
usr.sbin/bgplgd: slowcgi.c 

Log message:
When the slowcgi timeout fires but no process what yet started terminate
the session with a HTTP 408 error.
OK tb@



CVS: cvs.openbsd.org: src

2023-03-31 Thread Kevin Lo
CVSROOT:/cvs
Module name:src
Changes by: ke...@cvs.openbsd.org   2023/03/31 02:22:09

Modified files:
sys/arch/amd64/conf: GENERIC 

Log message:
Enable ngbe(4).

ok miod@



CVS: cvs.openbsd.org: src

2023-03-31 Thread Kevin Lo
CVSROOT:/cvs
Module name:src
Changes by: ke...@cvs.openbsd.org   2023/03/31 02:20:58

Modified files:
share/man/man4 : Makefile pci.4 
Added files:
share/man/man4 : ngbe.4 

Log message:
Man page for ngbe(4).

ok miod@



CVS: cvs.openbsd.org: src

2023-03-31 Thread Kevin Lo
CVSROOT:/cvs
Module name:src
Changes by: ke...@cvs.openbsd.org   2023/03/31 02:19:41

Modified files:
sys/dev/pci: files.pci 
Added files:
sys/dev/pci: if_ngbe.c if_ngbereg.h 

Log message:
ngbe(4), a driver for Wangxun WX1860 series Gigabit Ethernet devices.
Written based on the vendor driver for Linux.
Thanks to WangXun for relicensing their vendor driver to ISC.

Special thanks to miod@ for reviewing and providing valuable input.

ok miod@



CVS: cvs.openbsd.org: src

2023-03-31 Thread Kevin Lo
CVSROOT:/cvs
Module name:src
Changes by: ke...@cvs.openbsd.org   2023/03/31 02:17:00

Modified files:
sys/dev/pci: pcidevs.h pcidevs_data.h 

Log message:
regen



CVS: cvs.openbsd.org: src

2023-03-31 Thread Kevin Lo
CVSROOT:/cvs
Module name:src
Changes by: ke...@cvs.openbsd.org   2023/03/31 02:16:30

Modified files:
sys/dev/pci: pcidevs 

Log message:
Add "Beijing WangXun Technology" vendor and WX1860 series NICs.

ok miod@



CVS: cvs.openbsd.org: src

2023-03-31 Thread Theo Buehler
CVSROOT:/cvs
Module name:src
Changes by: t...@cvs.openbsd.org2023/03/31 01:28:46

Modified files:
sbin/isakmpd   : dh.c 

Log message:
Guard use of GROUP_EC2N with #ifndef OPENSSL_NO_EC2M

This allows compiling isakmpd with a libcrypto that has binary field
support removed. Leave the enum value itself unguarded on claudio's
request.

ok beck claudio jsing



CVS: cvs.openbsd.org: src

2023-03-31 Thread Theo Buehler
CVSROOT:/cvs
Module name:src
Changes by: t...@cvs.openbsd.org2023/03/31 00:07:44

Modified files:
regress/lib/libcrypto/bio: bio_asn1.c 

Log message:
Add a regress for the recent BIO_new_NDEF() write after free

This is a simple reproducer for a write after free that avoids all the
mess with CMS, PKCS7 and SMIME. This now mostly allows ASAN to check
that the memory handling in this marvellous function is correct.