CVS: cvs.openbsd.org: src

2023-04-28 Thread Alexander Bluhm
CVSROOT:/cvs
Module name:src
Changes by: bl...@cvs.openbsd.org   2023/04/28 18:20:46

Modified files:
regress/usr.bin/rsync: Makefile 

Log message:
Run open rsync and ports rsync programs against each other using
the --rsync-path option.  So we can see whether the tests pass in
all interoperability combinations.
Suggested by claudio@



CVS: cvs.openbsd.org: src

2023-04-28 Thread Theo Buehler
CVSROOT:/cvs
Module name:src
Changes by: t...@cvs.openbsd.org2023/04/28 15:40:14

Modified files:
lib/libcrypto  : crypto.h 

Log message:
Mark OpenSSLDie() as __dead

This tells gcc that OPENSSL_assert() will not return and thus avoids a
silly warning that triggers scary gentoo QA warnings.

>From claudio



CVS: cvs.openbsd.org: src

2023-04-28 Thread Dave Voutila
CVSROOT:/cvs
Module name:src
Changes by: d...@cvs.openbsd.org2023/04/28 15:22:20

Modified files:
usr.sbin/vmd   : parse.y 

Log message:
vmd(8): fix specifying boot image in vm.conf

Previous change to allow overriding changed the way we parsed and
stored the boot image path. The lifetime of the path was...much too
short. Heap allocate the kernel path.

Found by Mischa Peters.

ok mlarkin@



CVS: cvs.openbsd.org: src

2023-04-28 Thread Ingo Schwarze
CVSROOT:/cvs
Module name:src
Changes by: schwa...@cvs.openbsd.org2023/04/28 14:34:26

Modified files:
regress/usr.bin/mandoc/man/PP: args.out_lint 

Log message:
adjust after man_validate.c rev. 1.128 improved the error messages



CVS: cvs.openbsd.org: src

2023-04-28 Thread Theo Buehler
CVSROOT:/cvs
Module name:src
Changes by: t...@cvs.openbsd.org2023/04/28 14:22:35

Modified files:
usr.bin/locate/locate: fastfind.c util.c 

Log message:
Make LLVM 15 happier by changing from K to ANSI prototypes



CVS: cvs.openbsd.org: src

2023-04-28 Thread Ingo Schwarze
CVSROOT:/cvs
Module name:src
Changes by: schwa...@cvs.openbsd.org2023/04/28 14:14:19

Modified files:
usr.bin/mandoc : man_html.c man_term.c man_validate.c 

Log message:
Do not rewrite MAN_LP and MAN_P to MAN_PP because doing that causes
confusing warning messages complaining about macros that don't even
appear in the input file.
As a welcome side effect, this also shortens the code...

Fixing a minibug
reported by Alejandro Colomar .



CVS: cvs.openbsd.org: src

2023-04-28 Thread Dave Voutila
CVSROOT:/cvs
Module name:src
Changes by: d...@cvs.openbsd.org2023/04/28 14:13:56

Modified files:
usr.sbin/vmctl : vmctl.8 

Log message:
Clarify -b usage by `vmctl start`.



CVS: cvs.openbsd.org: src

2023-04-28 Thread Vitaliy Makkoveev
CVSROOT:/cvs
Module name:src
Changes by: m...@cvs.openbsd.org2023/04/28 14:03:14

Modified files:
sys/dev/dt : dt_prov_static.c 
sys/net: route.c 
sys/sys: refcnt.h 

Log message:
Add rtentry refcnt type to dt(4).

ok bluhm@



CVS: cvs.openbsd.org: src

2023-04-28 Thread Dave Voutila
CVSROOT:/cvs
Module name:src
Changes by: d...@cvs.openbsd.org2023/04/28 13:46:42

Modified files:
usr.sbin/vmctl : main.c vmctl.c 
usr.sbin/vmd   : config.c control.c parse.y vm.c vmd.c vmd.h 

Log message:
vmd(8)/vmctl(8): allow vm owners to override boot kernel.

vmd allows non-root users to "own" a vm defined in vm.conf(5). While
the user can start/stop the vm, if they break their filesystem they
have no means of booting recovery media like a ramdisk kernel.

This change opens the provided boot kernel via vmctl and passes the
file descriptor through the control channel to vmd. The next boot
of the vm will use the provided file descriptor as boot kernel/bios.
Subsequent boots (e.g. a reboot) will return to using behavior
defined in vm.conf or the default bios image.

ok mlarkin@



CVS: cvs.openbsd.org: src

2023-04-28 Thread Alexander Bluhm
CVSROOT:/cvs
Module name:src
Changes by: bl...@cvs.openbsd.org   2023/04/28 13:41:07

Modified files:
regress/usr.bin/rsync: Makefile 
Removed files:
regress/usr.bin/rsync: runtests.sh 

Log message:
Execute each test as make target.  Remove the shell wrapper.  Mark
failing test so that claudio@ can fix them.



CVS: cvs.openbsd.org: src

2023-04-28 Thread Dave Voutila
CVSROOT:/cvs
Module name:src
Changes by: d...@cvs.openbsd.org2023/04/28 12:52:22

Modified files:
usr.sbin/vmd   : vioblk.c vionet.c vioqcow2.c 

Log message:
Remove unneeded header includes in vmd.

No functional change. virtio block/networking emulation do not need
to know about vmm or any kernel types.



CVS: cvs.openbsd.org: src

2023-04-28 Thread Robert Nagy
CVSROOT:/cvs
Module name:src
Changes by: rob...@cvs.openbsd.org  2023/04/28 12:33:22

Modified files:
sys/arch/amd64/include: vmparam.h 
sys/arch/arm64/include: vmparam.h 

Log message:
bump MAXDSIZ to 128G on amd64 and 64G on arm64
discussed with kettenis@, ok deraadt@



CVS: cvs.openbsd.org: src

2023-04-28 Thread Job Snijders
CVSROOT:/cvs
Module name:src
Changes by: j...@cvs.openbsd.org2023/04/28 12:32:40

Modified files:
regress/lib/libcrypto/x509: x509_asn1.c 

Log message:
Free all libcrypto global state memory before returning

Found with the help of Otto's malloc memory leak detector!



CVS: cvs.openbsd.org: src

2023-04-28 Thread Job Snijders
CVSROOT:/cvs
Module name:src
Changes by: j...@cvs.openbsd.org2023/04/28 12:31:34

Modified files:
regress/lib/libcrypto/x509: x509_asn1.c 

Log message:
Return a non-zero error exit code on any DER cache discrepancies



CVS: cvs.openbsd.org: src

2023-04-28 Thread Scott Soule Cheloha
CVSROOT:/cvs
Module name:src
Changes by: chel...@cvs.openbsd.org 2023/04/28 12:27:55

Modified files:
distrib/sets/lists/man: mi 
share/man/man4/man4.sparc64: Makefile 
sys/arch/sparc64/conf: GENERIC RAMDISK RAMDISKU1 RAMDISKU5 
sys/arch/sparc64/sparc64: autoconf.c clock.c locore.s 
Removed files:
share/man/man4/man4.sparc64: timer.4 
sys/arch/sparc64/sparc64: timerreg.h 

Log message:
timer(4/sparc64): remove driver

The timer(4/sparc64) driver was effectively disabled during the
previous release.  Nobody has come forward asking for it to be adapted
to work with the new clockintr framework, so it's time to remove the
driver from the tree.

As of today, if you want to run OpenBSD on SPARC v9 hardware, that
hardware needs to sport either %tick and %tick_compare (%asr23), or
%stick (%asr24) and %stick_compare (%asr25).

All Sun/Oracle SPARC v9 hardware meets these conditions, from the
UltraSPARC I onward.

Most HAL/Fujitsu SPARC v9 hardware meets these conditions, from the
SPARC64 III onward.  The only HAL/Fujitsu hardware that might not have
%tick_compare are the HAL SPARC64 I and SPARC64 II, for which I can
find no documentation.  However, those processors are currently
unsupported by OpenBSD for other reasons, so their support status is
unchanged by the removal of this driver.

With help from miod@.

Link: https://marc.info/?l=openbsd-tech=167898759928206=2

"after unlock" deraadt@, ok mlarkin@ miod@



CVS: cvs.openbsd.org: src

2023-04-28 Thread Theo Buehler
CVSROOT:/cvs
Module name:src
Changes by: t...@cvs.openbsd.org2023/04/28 12:27:50

Modified files:
regress/lib/libcrypto/x509: x509_asn1.c 

Log message:
Fix leaks reported by ASAN

debugged with job



CVS: cvs.openbsd.org: src

2023-04-28 Thread Kenneth R Westerback
CVSROOT:/cvs
Module name:src
Changes by: k...@cvs.openbsd.org2023/04/28 12:14:59

Modified files:
distrib/amd64/ramdiskA: Makefile 
distrib/i386/ramdisk: Makefile 

Log message:
Revert amd64/i386 floppy change. Missing diff to vnconfig broke
installboot'ing due to incorrect d_type (must be 'floppy' not
'vnd') in disklabel.

Noticed by deraadt@ and sthen@



CVS: cvs.openbsd.org: src

2023-04-28 Thread Theo Buehler
CVSROOT:/cvs
Module name:src
Changes by: t...@cvs.openbsd.org2023/04/28 12:14:59

Modified files:
lib/libssl : ssl_tlsext.c 

Log message:
Too many stupid things whine about these being used uninitialized
(which they aren't), so appease them.



CVS: cvs.openbsd.org: src

2023-04-28 Thread Job Snijders
CVSROOT:/cvs
Module name:src
Changes by: j...@cvs.openbsd.org2023/04/28 11:59:53

Modified files:
lib/libcrypto/asn1: tasn_dec.c tasn_enc.c 

Log message:
Remove preservation and use of cached DER/BER encodings in the d2i/i2d paths

A long time ago a workflow was envisioned for X509, X509_CRL, and X509_REQ
structures in which only fields modified after deserialization would need to
be re-encoded upon serialization.

Unfortunately, over the years, authors would sometimes forget to add code in
setter functions to trigger invalidation of previously cached DER encodings.

The presence of stale versions of structures can lead to very hard-to-debug
issues and cause immense sorrow.

Fully removing the concept of caching DER encodings ensures stale versions
of structures can never rear their ugly heads again.

OK tb@ jsing@



CVS: cvs.openbsd.org: src

2023-04-28 Thread Ingo Schwarze
CVSROOT:/cvs
Module name:src
Changes by: schwa...@cvs.openbsd.org2023/04/28 11:31:58

Modified files:
lib/libevent   : event_base_new.3 

Log message:
Some wording tweaks to finish the polishing.
While here, also correct the HISTORY section.
OK jmc@



CVS: cvs.openbsd.org: src

2023-04-28 Thread Ingo Schwarze
CVSROOT:/cvs
Module name:src
Changes by: schwa...@cvs.openbsd.org2023/04/28 10:59:03

Modified files:
regress/lib/libcrypto/man: check_complete.pl 

Log message:
Mark the obsolete PROXY_PARAM and SOCKS BIO_ctrl(3) command constants
as intentionally undocumented.  Do that here because no related
manual pages exist.



CVS: cvs.openbsd.org: src

2023-04-28 Thread Bob Beck
CVSROOT:/cvs
Module name:src
Changes by: b...@cvs.openbsd.org2023/04/28 10:50:16

Modified files:
lib/libcrypto/x509: x509_verify.c x509_vfy.c x509_vfy.h 
x509_vpm.c 
regress/lib/libcrypto/x509/policy: policy.c 

Log message:
Enable policy checking by default now that we are DAG implementation based.

This ensures that we will no longer silently ignore a certificate with
a critical policy extention by default.

ok tb@



CVS: cvs.openbsd.org: src

2023-04-28 Thread Ingo Schwarze
CVSROOT:/cvs
Module name:src
Changes by: schwa...@cvs.openbsd.org2023/04/28 10:49:00

Modified files:
lib/libcrypto/man: BIO_f_buffer.3 BIO_f_cipher.3 BIO_s_bio.3 
   BIO_s_datagram.3 BIO_s_file.3 

Log message:
Mark a number of BIO_ctrl(3) command constants as intentionally
undocumented because they are NOOPs or deprecated.



CVS: cvs.openbsd.org: src

2023-04-28 Thread Ingo Schwarze
CVSROOT:/cvs
Module name:src
Changes by: schwa...@cvs.openbsd.org2023/04/28 10:39:19

Modified files:
lib/libcrypto/man: BN_new.3 

Log message:
kill the .Xr to BN_nist_mod_521(3) which no longer exists



CVS: cvs.openbsd.org: src

2023-04-28 Thread Theo Buehler
CVSROOT:/cvs
Module name:src
Changes by: t...@cvs.openbsd.org2023/04/28 10:30:14

Modified files:
lib/libcrypto  : Makefile 
lib/libcrypto/asn1: x_x509.c 
lib/libcrypto/x509: x509_local.h x509_policy.c x509_vfy.c 

Log message:
Unifdef LIBRESSL_HAS_POLICY_DAG and remove it from the Makefile

with beck



CVS: cvs.openbsd.org: src

2023-04-28 Thread Claudio Jeker
CVSROOT:/cvs
Module name:src
Changes by: clau...@cvs.openbsd.org 2023/04/28 10:28:28

Added files:
regress/usr.bin/rsync: Makefile conf.sh lib.sh runtests.sh 
   test0_noslash.test test10_perms.test 
   test10b_perms.test test11_middlediff.test 
   test11b_middlediff.test test12_inex.test 
   test12b_inex.test test12c_inex.test 
   test1_minusa.test test2_minusexclude.test 
   test3_minusexclude.test 
   test3b_minusexclude.test 
   test3c_minusexclude.test 
   test3d_minusexclude.test 
   test3e_minusexclude.test 
   test4_excludedir.test test6_perms.test 
   test6b_perms.test test7_symlinks.test 
   test7b_symlinks.test test8_times.test 
   test8b_times.test test9_norecurse.test 

Log message:
Import rsync regress provided by Martin Cracauer so that bluhm@ can work
improve it in tree.



CVS: cvs.openbsd.org: src

2023-04-28 Thread Claudio Jeker
CVSROOT:/cvs
Module name:src
Changes by: clau...@cvs.openbsd.org 2023/04/28 10:25:21

src/regress/usr.bin/rsync

Update of /cvs/src/regress/usr.bin/rsync
In directory cvs.openbsd.org:/tmp/cvs-serv6114/rsync

Log Message:
Directory /cvs/src/regress/usr.bin/rsync added to the repository



CVS: cvs.openbsd.org: src

2023-04-28 Thread Ingo Schwarze
CVSROOT:/cvs
Module name:src
Changes by: schwa...@cvs.openbsd.org2023/04/28 10:22:45

Modified files:
lib/libcrypto/man: BIO_ctrl.3 

Log message:
Add BIO_C_SET_MD_CTX to the list of command constants.



CVS: cvs.openbsd.org: src

2023-04-28 Thread Theo Buehler
CVSROOT:/cvs
Module name:src
Changes by: t...@cvs.openbsd.org2023/04/28 10:21:57

Modified files:
lib/libcrypto  : Makefile 
Removed files:
lib/libcrypto/x509: pcy_cache.c pcy_data.c pcy_int.h pcy_lib.c 
pcy_map.c pcy_node.c pcy_tree.c 

Log message:
Take the old policy code behind the barn

It can go play in the fields with all the other exponential time policy
"code".

discussed with jsing
ok & commit message beck



CVS: cvs.openbsd.org: src

2023-04-28 Thread Ingo Schwarze
CVSROOT:/cvs
Module name:src
Changes by: schwa...@cvs.openbsd.org2023/04/28 10:20:01

Modified files:
lib/libcrypto/man: BIO_f_md.3 

Log message:
Document BIO_set_md_ctx(3) and BIO_C_SET_MD_CTX.
Correct the return types of some macros.
Improve the RETURN VALUES section.



CVS: cvs.openbsd.org: src

2023-04-28 Thread Theo Buehler
CVSROOT:/cvs
Module name:src
Changes by: t...@cvs.openbsd.org2023/04/28 10:18:17

Modified files:
regress/lib/libcrypto/x509/policy: Makefile 

Log message:
The policy test is no longer expected to fail



CVS: cvs.openbsd.org: src

2023-04-28 Thread Theo Buehler
CVSROOT:/cvs
Module name:src
Changes by: t...@cvs.openbsd.org2023/04/28 10:14:46

Modified files:
lib/libcrypto  : Makefile 

Log message:
Enable the new policy checking code in x509_policy.c

ok beck jsing



CVS: cvs.openbsd.org: src

2023-04-28 Thread Theo Buehler
CVSROOT:/cvs
Module name:src
Changes by: t...@cvs.openbsd.org2023/04/28 09:57:38

Modified files:
lib/libcrypto/x509: x509_policy.c 

Log message:
Silence gcc-4 warnings about sk_sort()

Tell it we deliberately ignore the return value, (we really don't
care what the old comparison function was).



CVS: cvs.openbsd.org: src

2023-04-28 Thread Job Snijders
CVSROOT:/cvs
Module name:src
Changes by: j...@cvs.openbsd.org2023/04/28 09:51:18

Modified files:
lib/libcrypto/man: ASN1_item_d2i.3 X509_sign.3 

Log message:
Remove misinformation, reason had nothing to do with efficiency

"Failure to re-encode on modification is a bug not a feature."

OK jsing@



CVS: cvs.openbsd.org: src

2023-04-28 Thread Alexandr Nedvedicky
CVSROOT:/cvs
Module name:src
Changes by: sas...@cvs.openbsd.org  2023/04/28 09:50:05

Modified files:
sys/net: if_pfsync.c 

Log message:
remove superfluous/invalid KASSERT() in pfsync_q_del().

pointed and OK bluhm@



CVS: cvs.openbsd.org: src

2023-04-28 Thread Theo Buehler
CVSROOT:/cvs
Module name:src
Changes by: t...@cvs.openbsd.org2023/04/28 09:39:29

Modified files:
lib/libcrypto/x509: x509_policy.c 

Log message:
Remove now no longer needed ; sort headers

ok jsing



CVS: cvs.openbsd.org: src

2023-04-28 Thread Theo Buehler
CVSROOT:/cvs
Module name:src
Changes by: t...@cvs.openbsd.org2023/04/28 09:37:28

Modified files:
lib/libcrypto/x509: x509_policy.c 

Log message:
Deassert has_explicit_policy()

The only caller is X509_policy_check() which goes straight to error.

with beck
ok jsing



CVS: cvs.openbsd.org: src

2023-04-28 Thread Theo Buehler
CVSROOT:/cvs
Module name:src
Changes by: t...@cvs.openbsd.org2023/04/28 09:35:55

Modified files:
lib/libcrypto/x509: x509_policy.c 

Log message:
Deassert delete_if() callbacks

Add sk_is_sorted() checks to the callers of sk_X509_POLICY_NODE_delete_if()
and add a comment that this is necessary.

with beck
ok jsing



CVS: cvs.openbsd.org: src

2023-04-28 Thread Theo Buehler
CVSROOT:/cvs
Module name:src
Changes by: t...@cvs.openbsd.org2023/04/28 09:30:14

Modified files:
lib/libcrypto/x509: x509_policy.c 

Log message:
Deassert x509_policy_level_find()

Move the check that level->nodes is sorted to the call site and make sure
that the logic is preserved and erroring does the right thing.

with beck
ok jsing



CVS: cvs.openbsd.org: src

2023-04-28 Thread Theo Buehler
CVSROOT:/cvs
Module name:src
Changes by: t...@cvs.openbsd.org2023/04/28 09:27:15

Modified files:
lib/libcrypto/x509: x509_policy.c 

Log message:
Deassert X509_policy_check()

Instead of asserting that i == num_certs - 2, simply make that an error
check.

with beck
ok jsing



CVS: cvs.openbsd.org: src

2023-04-28 Thread Theo Buehler
CVSROOT:/cvs
Module name:src
Changes by: t...@cvs.openbsd.org2023/04/28 09:21:22

Modified files:
lib/libcrypto/x509: x509_policy.c 

Log message:
Deassert x509_policy_level_add_nodes()

This assert is in debugging code that ensures that there are no duplicate
nodes on this level. This is an expensive and unnecessary check. Duplicates
already cause failures as ensured by regress.

with beck
ok jsing



CVS: cvs.openbsd.org: src

2023-04-28 Thread Theo Buehler
CVSROOT:/cvs
Module name:src
Changes by: t...@cvs.openbsd.org2023/04/28 09:16:48

Modified files:
lib/libcrypto/x509: x509_policy.c 

Log message:
Deassert x509_policy_new()

Turn the check into an error which will make all callers error.

with beck
ok jsing



CVS: cvs.openbsd.org: src

2023-04-28 Thread Job Snijders
CVSROOT:/cvs
Module name:src
Changes by: j...@cvs.openbsd.org2023/04/28 09:12:51

Modified files:
regress/lib/libcrypto/x509: x509_asn1.c 

Log message:
Rearrange freeing of memory in the regress test



CVS: cvs.openbsd.org: src

2023-04-28 Thread Ingo Schwarze
CVSROOT:/cvs
Module name:src
Changes by: schwa...@cvs.openbsd.org2023/04/28 09:04:33

Modified files:
lib/libcrypto/man: BIO_f_md.3 

Log message:
Reorder the text such that every function is discussed only once
instead of discussing some of them at two different places.
Also follow a more logical order: initialization first, then reading
and writing, then retrieving the digest and reinitialization.
Leave context handling and chain duplication at the end because
both are rarely needed.

While here, also tweak the wording of the shuffled text
and add some precision in a few places.



CVS: cvs.openbsd.org: src

2023-04-28 Thread Theo Buehler
CVSROOT:/cvs
Module name:src
Changes by: t...@cvs.openbsd.org2023/04/28 08:45:51

Modified files:
regress/lib/libcrypto/x509/policy: policy.c 

Log message:
make the policy test compile on sparc64



CVS: cvs.openbsd.org: src

2023-04-28 Thread Peter Hessler
CVSROOT:/cvs
Module name:src
Changes by: phess...@cvs.openbsd.org2023/04/28 08:09:06

Modified files:
sys/netinet6   : nd6_nbr.c 

Log message:
Inbound portion of RFC9131.  Routers can create new neighbor cache entries
when receiving a valid Neighbor Advertisement.

OK florian@ kn@



CVS: cvs.openbsd.org: src

2023-04-28 Thread Alexandr Nedvedicky
CVSROOT:/cvs
Module name:src
Changes by: sas...@cvs.openbsd.org  2023/04/28 08:08:38

Modified files:
sbin/pfctl : pfctl.c 
sys/net: pf_ioctl.c pf_ruleset.c pfvar.h pfvar_priv.h 

Log message:
This change speeds up DIOCGETRULE ioctl(2) which pfctl(8) uses to
retrieve rules from kernel. The current implementation requires
like O((n^2)/2) operation to read the complete rule set, because
each DIOCGETRULE operation must iterate over previous n
rules to find (n + 1)-th rule to read.

To address the issue diff introduces a pf_trans structure to keep
pointer to next rule to read, thus  reading process does not need
to iterate from beginning of rule set to reach the next rule.
All transactions opened by process get closed either when process
is done (reads all rules) or when /dev/pf device is closed.

the diff also comes with lots of improvements from dlg@ and kn@

OK dlg@, kn@



CVS: cvs.openbsd.org: src

2023-04-28 Thread Peter Hessler
CVSROOT:/cvs
Module name:src
Changes by: phess...@cvs.openbsd.org2023/04/28 08:08:34

Modified files:
sys/net: pf.c 

Log message:
Relax the "pass all" rule so all forms of neighbor advertisements are allowed
in either direction.

This more closely matches the IPv4 ARP behaviour.

>From sashan@
discussed with kn@ deraadt@



CVS: cvs.openbsd.org: src

2023-04-28 Thread Job Snijders
CVSROOT:/cvs
Module name:src
Changes by: j...@cvs.openbsd.org2023/04/28 07:48:38

Modified files:
regress/lib/libcrypto/x509: x509_asn1.c 

Log message:
Add X509_REQ_add_extensions and to X509_REQ_add1_attr to DER cache test

These new tests won't bubble up a non-zero error exit code because
other libcrypto bits still need to land first.



CVS: cvs.openbsd.org: src

2023-04-28 Thread Claudio Jeker
CVSROOT:/cvs
Module name:src
Changes by: clau...@cvs.openbsd.org 2023/04/28 07:24:25

Modified files:
usr.sbin/bgpctl: bgpctl.c output.c 

Log message:
Same change as in bgpd:
Add explicit default labels in switch() statements with error handling.
Right now these are not reachable. Should also clear some gcc warnings.
OK tb@



CVS: cvs.openbsd.org: src

2023-04-28 Thread Claudio Jeker
CVSROOT:/cvs
Module name:src
Changes by: clau...@cvs.openbsd.org 2023/04/28 07:23:52

Modified files:
usr.sbin/bgpd  : parse.y printconf.c 

Log message:
Add explicit default labels in switch() statements with error handling.
Right now these are not reachable. Should also clear some gcc warnings.
OK tb@



CVS: cvs.openbsd.org: src

2023-04-28 Thread Alexander Bluhm
CVSROOT:/cvs
Module name:src
Changes by: bl...@cvs.openbsd.org   2023/04/28 06:53:42

Modified files:
sys/kern   : uipc_socket.c 

Log message:
Add a membar_consumer() for the taskq_create() in sosplice().  Membar
producer and consumer must come in pair and the latter was missing.
Also move the code a bit to make clear which check is needed for
what.
OK mvs@



CVS: cvs.openbsd.org: src

2023-04-28 Thread Kenneth R Westerback
CVSROOT:/cvs
Module name:src
Changes by: k...@cvs.openbsd.org2023/04/28 06:26:43

Modified files:
distrib/alpha/miniroot: Makefile 
distrib/amd64/ramdiskA: Makefile 
distrib/i386/iso: Makefile 
distrib/i386/ramdisk: Makefile 
distrib/i386/ramdisk_cd: Makefile 
distrib/landisk/ramdisk: Makefile 
distrib/luna88k/ramdisk: Makefile 
distrib/sparc64/iso: Makefile 
distrib/sparc64/miniroot: Makefile 
distrib/sparc64/ramdisk: Makefile 
distrib/sparc64/ramdiskB: Makefile 

Log message:
Move FSDISKTYPE uses from disklabel(8) invocations to vnconfig(8)
invocations, making the geometry information written to the
disklabel a bit more logically related to the disktab information
from whence it came. Also makes FSDISKTYPE usage consistent.

Flip the disklabel(8) invocations to the "echo '/ *'"
idiom to make it obvious that the desire is to create a single
'a' partition containing all free space.

No intentional functional change. MBRs, disklabels and newfs
outputs appear identical.

reads good to kn@



CVS: cvs.openbsd.org: src

2023-04-28 Thread Greg Steuck
CVSROOT:/cvs
Module name:src
Changes by: gne...@cvs.openbsd.org  2023/04/28 06:03:49

Modified files:
gnu/llvm/clang/lib/Driver/ToolChains: OpenBSD.cpp 

Log message:
Enable kernel-address sanitizer for clang openbsd target

OK deraadt@



CVS: cvs.openbsd.org: src

2023-04-28 Thread Claudio Jeker
CVSROOT:/cvs
Module name:src
Changes by: clau...@cvs.openbsd.org 2023/04/28 04:24:39

Modified files:
usr.bin/rsync  : extern.h fargs.c main.c rsync.1 uploader.c 

Log message:
Implement --size-only and --ignore-times

Flags are passed to the remote system but --size-only is only set
if local system is sender since this is the behaviour of rsync.
Initial diff from Martin Cracauer but mostly reimplemented and extended
by myself.
OK kn@



CVS: cvs.openbsd.org: src

2023-04-28 Thread Klemens Nanni
CVSROOT:/cvs
Module name:src
Changes by: k...@cvs.openbsd.org2023/04/28 04:19:36

Modified files:
sys/net: pf_ioctl.c 

Log message:
Remove net lock from DIOCGETQUEUES

Both ticket and number of queues stem from the pf_queues_active list which
is effectively static to pf_ioctl.c and fully protected by the pf lock.

OK sashan



CVS: cvs.openbsd.org: src

2023-04-28 Thread Patrick Wildt
CVSROOT:/cvs
Module name:src
Changes by: patr...@cvs.openbsd.org 2023/04/28 04:19:07

Modified files:
sys/dev/fdt: qcscm.c 

Log message:
Fix memory constraints in the inline-assembly stub that calls into secure
mode.  Without this change the compiler doesn't realize that the memory
behind the array that contains the return values might have changed and
optimizes the access away.  With this change it properly access the array
to retrieve the returned values.

ok drahn@



CVS: cvs.openbsd.org: src

2023-04-28 Thread Alexander Bluhm
CVSROOT:/cvs
Module name:src
Changes by: bl...@cvs.openbsd.org   2023/04/28 04:18:58

Modified files:
sys/dev/pci: if_igc.c if_ix.c if_oce.c 

Log message:
Remove error handling around mallocarray(9).  I cannot fail when
called with M_WAITOK.
OK kevlo@



CVS: cvs.openbsd.org: src

2023-04-28 Thread Omar Polo
CVSROOT:/cvs
Module name:src
Changes by: o...@cvs.openbsd.org2023/04/28 04:02:03

Modified files:
usr.bin/mg : mg.1 util.c 

Log message:
fix lfindent (newline-and-indent) comment and description in the man page

for a while it has used only spaces when no-tab-mode is enabled and respected
the current buffer tab width.



CVS: cvs.openbsd.org: src

2023-04-28 Thread Theo Buehler
CVSROOT:/cvs
Module name:src
Changes by: t...@cvs.openbsd.org2023/04/28 03:56:09

Modified files:
lib/libcrypto/x509: x509_policy.c 

Log message:
Cleanup pass over x509_check_policy.c

This hoists variable declarations to the top and compiles with -Wshadow.

ok beck



CVS: cvs.openbsd.org: src

2023-04-28 Thread Omar Polo
CVSROOT:/cvs
Module name:src
Changes by: o...@cvs.openbsd.org2023/04/28 03:50:50

Modified files:
usr.bin/mg : mg.1 

Log message:
mark up all commands in the man page



CVS: cvs.openbsd.org: src

2023-04-28 Thread Bob Beck
CVSROOT:/cvs
Module name:src
Changes by: b...@cvs.openbsd.org2023/04/28 03:11:35

Modified files:
regress/lib/libcrypto/x509: Makefile 
regress/lib/libcrypto/x509/policy: Makefile 

Log message:
Hook up the the x509 policy regression tests to x509 regress.

These were adapted from BoringSSL's regress tests for x509
policy. They are currently marked as expected to fail as
we have not enabled LIBRESSL_HAS_POLICY_DAG by default yet, and
the old tree based policy code from OpenSSL is special.

These tests pass when we build with LIBRESSL_HAS_POLICY_DAG.



CVS: cvs.openbsd.org: src

2023-04-28 Thread Bob Beck
CVSROOT:/cvs
Module name:src
Changes by: b...@cvs.openbsd.org2023/04/28 03:02:04

Modified files:
regress/lib/libcrypto/x509/policy: policy.c 

Log message:
Fix copyright, convert boringssl comments to C style



CVS: cvs.openbsd.org: src

2023-04-28 Thread Bob Beck
CVSROOT:/cvs
Module name:src
Changes by: b...@cvs.openbsd.org2023/04/28 02:53:20

Modified files:
regress/lib/libcrypto/x509/policy: policy.c 

Log message:
KNF
ok knfmt



Re: CVS: cvs.openbsd.org: src

2023-04-28 Thread Kenneth Westerback
Or as it should have said:

"Make 'bsd' before 'mr.fs' so that 'mr.fs' can use the actual
space available in the kernel image rather than relying on
third parties like disktab to be correct.

No intentional functional change."

Sigh.

Kenneth R Westerback  writes:

> CVSROOT:  /cvs
> Module name:  src
> Changes by:   k...@cvs.openbsd.org2023/04/28 02:45:26
>
> Modified files:
>   distrib/alpha/miniroot: Makefile
>   distrib/amd64/ramdiskA: Makefile
>   distrib/amd64/ramdisk_cd: Makefile
>   distrib/arm64/ramdisk: Makefile
>   distrib/armv7/ramdisk: Makefile
>   distrib/hppa/ramdisk: Makefile
>   distrib/i386/ramdisk: Makefile
>   distrib/i386/ramdisk_cd: Makefile
>   distrib/landisk/ramdisk: Makefile
>   distrib/loongson/ramdisk: Makefile
>   distrib/luna88k/ramdisk: Makefile
>   distrib/macppc/ramdisk: Makefile
>   distrib/octeon/ramdisk: Makefile
>   distrib/powerpc64/ramdisk: Makefile
>   distrib/riscv64/ramdisk: Makefile
>   distrib/sparc64/miniroot: Makefile
>   distrib/sparc64/ramdisk: Makefile
>   distrib/sparc64/ramdiskB: Makefile
>   sys/arch/octeon/stand/boot: Makefile
>   sys/arch/powerpc64/stand/boot: Makefile
>
> Log message:
> Retire -E's "expert" mode. Introduced 23 years ago to avoid
> confusing users with FFS attributes that only experts should
> fiddle with. Actual use has withered away with functionality
> rendered moot or moved elsewhere.
>
> '-e' remains for the truly obscure corner cases.
>
> Simply excise the code for now to see if hidden users/uses are
> exposed.  Further simplifications are possible if no such
> users/uses surface.
>
> ok with sthen@ millert@ kn@ otto@
--
 Ken



CVS: cvs.openbsd.org: src

2023-04-28 Thread Bob Beck
CVSROOT:/cvs
Module name:src
Changes by: b...@cvs.openbsd.org2023/04/28 02:50:08

Modified files:
regress/lib/libcrypto/x509/policy: policy.c 

Log message:
remove unused code.



CVS: cvs.openbsd.org: src

2023-04-28 Thread Bob Beck
CVSROOT:/cvs
Module name:src
Changes by: b...@cvs.openbsd.org2023/04/28 02:45:50

Modified files:
regress/lib/libcrypto/x509/policy: policy.c 

Log message:
remove debugging printf



CVS: cvs.openbsd.org: src

2023-04-28 Thread Kenneth R Westerback
CVSROOT:/cvs
Module name:src
Changes by: k...@cvs.openbsd.org2023/04/28 02:45:26

Modified files:
distrib/alpha/miniroot: Makefile 
distrib/amd64/ramdiskA: Makefile 
distrib/amd64/ramdisk_cd: Makefile 
distrib/arm64/ramdisk: Makefile 
distrib/armv7/ramdisk: Makefile 
distrib/hppa/ramdisk: Makefile 
distrib/i386/ramdisk: Makefile 
distrib/i386/ramdisk_cd: Makefile 
distrib/landisk/ramdisk: Makefile 
distrib/loongson/ramdisk: Makefile 
distrib/luna88k/ramdisk: Makefile 
distrib/macppc/ramdisk: Makefile 
distrib/octeon/ramdisk: Makefile 
distrib/powerpc64/ramdisk: Makefile 
distrib/riscv64/ramdisk: Makefile 
distrib/sparc64/miniroot: Makefile 
distrib/sparc64/ramdisk: Makefile 
distrib/sparc64/ramdiskB: Makefile 
sys/arch/octeon/stand/boot: Makefile 
sys/arch/powerpc64/stand/boot: Makefile 

Log message:
Retire -E's "expert" mode. Introduced 23 years ago to avoid
confusing users with FFS attributes that only experts should
fiddle with. Actual use has withered away with functionality
rendered moot or moved elsewhere.

'-e' remains for the truly obscure corner cases.

Simply excise the code for now to see if hidden users/uses are
exposed.  Further simplifications are possible if no such
users/uses surface.

ok with sthen@ millert@ kn@ otto@



CVS: cvs.openbsd.org: src

2023-04-28 Thread Bob Beck
CVSROOT:/cvs
Module name:src
Changes by: b...@cvs.openbsd.org2023/04/28 02:43:18

Modified files:
regress/lib/libcrypto/x509/policy: policy.c 

Log message:
This test should not have V_EXPLICIT_POLICY set.  with this
corrected we pass



CVS: cvs.openbsd.org: src

2023-04-28 Thread Bob Beck
CVSROOT:/cvs
Module name:src
Changes by: b...@cvs.openbsd.org2023/04/28 02:15:11

Modified files:
regress/lib/libcrypto/x509/policy: policy.c 

Log message:
Add the rest of the boringssl policy unit tests.

We currently still fail two of these, looks like one more bug in
extracting the depth for require policy from the certificate..



CVS: cvs.openbsd.org: src

2023-04-28 Thread Jason McIntyre
CVSROOT:/cvs
Module name:src
Changes by: j...@cvs.openbsd.org2023/04/28 00:21:42

Modified files:
share/man/man4 : urtwn.4 

Log message:
escape the "D1" revisions, as mandoc thinks this is a macro call;



CVS: cvs.openbsd.org: src

2023-04-28 Thread Nicholas Marriott
CVSROOT:/cvs
Module name:src
Changes by: n...@cvs.openbsd.org2023/04/28 00:12:27

Modified files:
usr.bin/tmux   : cmd-confirm-before.c tmux.1 

Log message:
Add options to change the confirm key and default behaviour of
confirm-before. From Elias Assaf in GitHub issue 3548; prompted by an
earlier change from Yutaro Yoshii in GitHub issue 3496.