Re: CVS commit: src/distrib
> Module Name: src > Committed By: abs > Date: Sun Sep 20 23:19:56 UTC 2009 : > Added Files: > src/distrib/common: termcap > Removed Files: : > src/distrib/common: termcap.mini : > Log Message: > 34 different termcap subsets, plus a couple of ports still using > the full termcap distfile. In an attempt to reduce the madness > switch everyone (except the i386 cd install which does its own > thing) to the same (under 8K) termcap subset: Can't it use src/distrib/common/mktermcap script? --- Izumi Tsutsui
Re: CVS commit: src/distrib
On Sep 20, 8:14pm, da...@l8s.co.uk (David Laight) wrote: -- Subject: Re: CVS commit: src/distrib | On Sat, Sep 19, 2009 at 09:05:27PM +, Christos Zoulas wrote: | > | > if [ -n "$1" ]; then | > awk -f .../list2sh.awk "$@" | > fi | | Since "$@" is being substituted, wouldn't a check against $# | be more appropriate? | | > and that "X$1" idiom needs to die | | It is necessary to guarantee the way the expression is evaluated | if/when $1 (in the above example) is, say, "-o" or some other string | that might be deemed to be an operator. if [ -n -o ]; then echo true; else echo false; fi works just fine. | Although posix defines strict rules for expressions with small | numbers of arguments, netbsd'd parser doesn't obey them! Really? Can you give me an example. | > as well as using unquoted variables | > which will break for strings with whitespace. | | Sometimes I empty IFS Heh, christos
Re: CVS commit: src/distrib
On Sat, Sep 19, 2009 at 09:05:27PM +, Christos Zoulas wrote: > > if [ -n "$1" ]; then > awk -f .../list2sh.awk "$@" > fi Since "$@" is being substituted, wouldn't a check against $# be more appropriate? > and that "X$1" idiom needs to die It is necessary to guarantee the way the expression is evaluated if/when $1 (in the above example) is, say, "-o" or some other string that might be deemed to be an operator. Although posix defines strict rules for expressions with small numbers of arguments, netbsd'd parser doesn't obey them! > as well as using unquoted variables > which will break for strings with whitespace. Sometimes I empty IFS David -- David Laight: da...@l8s.co.uk
Re: CVS commit: src/sys/ufs/ufs
On Sun Sep 20 2009 at 14:00:24 +, Manuel Bouyer wrote: > Module Name: src > Committed By: bouyer > Date: Sun Sep 20 14:00:24 UTC 2009 > > Modified Files: > src/sys/ufs/ufs: ufs_ihash.c > > Log Message: > PR kern/41147: race between nfsd and local rm > Note that the race also exists between 2 nfs client, one of them doing the rm. > In ufs_ihashget(), vget() can return a vnode that has been vclean'ed because > vget() can sleep. After vget returns, check that vp is still connected with > ip, and that ip still points to the inode we want. This fix the NULL > pointer dereference in ufs_fhtovp() I've been seeing on a NFS server. Um, hold the phone. The whole point of vget() is to provide race-free access to the weak vnode reference held by the file system. Are you saying this does not hold anymore?
Re: CVS commit: src/sys/arch/i386/pci
Am 17.09.2009 um 21:21 schrieb David Young: Module Name:src Committed By: dyoung Date: Thu Sep 17 20:21:54 UTC 2009 Modified Files: src/sys/arch/i386/pci: elan520.c Log Message: As Jonathan Kollasch points out, elansc_attach() does not actually use gba after filling it out. Delete it. I am not sure if this is the right fix. Does the gpio device still attach now? Shouldn't there just be a config_found_ia(self, "gpiobus", &gba, gpiobus_print); call added? Or how does the GPIO system get to know how much pins etc. this GPIO controller has? Have you tested this on real hardware (e.g. a Soekris net4501)? - Marc Balmer To generate a diff of this commit: cvs rdiff -u -r1.42 -r1.43 src/sys/arch/i386/pci/elan520.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. Modified files: Index: src/sys/arch/i386/pci/elan520.c diff -u src/sys/arch/i386/pci/elan520.c:1.42 src/sys/arch/i386/pci/ elan520.c:1.43 --- src/sys/arch/i386/pci/elan520.c:1.42Wed Apr 29 23:50:53 2009 +++ src/sys/arch/i386/pci/elan520.c Thu Sep 17 20:21:54 2009 @@ -1,4 +1,4 @@ -/* $NetBSD: elan520.c,v 1.42 2009/04/29 23:50:53 dyoung Exp $ */ +/* $NetBSD: elan520.c,v 1.43 2009/09/17 20:21:54 dyoung Exp $ */ /*- * Copyright (c) 2002 The NetBSD Foundation, Inc. @@ -40,7 +40,7 @@ #include -__KERNEL_RCSID(0, "$NetBSD: elan520.c,v 1.42 2009/04/29 23:50:53 dyoung Exp $"); +__KERNEL_RCSID(0, "$NetBSD: elan520.c,v 1.43 2009/09/17 20:21:54 dyoung Exp $"); #include #include @@ -1262,7 +1262,6 @@ uint16_t rev; uint8_t cpuctl, picicr, ressta; #if NGPIO > 0 - struct gpiobus_attach_args gba; int pin, reg, shift; uint16_t data; #endif @@ -1387,10 +1386,6 @@ sc->sc_gpio_gc.gp_pin_write = elansc_gpio_pin_write; sc->sc_gpio_gc.gp_pin_ctl = elansc_gpio_pin_ctl; - gba.gba_gc = &sc->sc_gpio_gc; - gba.gba_pins = sc->sc_gpio_pins; - gba.gba_npins = ELANSC_PIO_NPINS; - #endif /* NGPIO */ elansc_rescan(sc->sc_dev, "elanparbus", NULL);
