Re: CVS commit: src/external/bsd/mdocml/dist
On Sat, Nov 07, 2009 at 12:48:16AM -0700, M. Warner Losh wrote: which ones have the same name, but different behavior on OS X? A quick read of the man pages suggests they are identical... Check about whether they need a \n at the end of the format. David -- David Laight: da...@l8s.co.uk
Re: CVS commit: src/sys/dev/ppbus
David Young wrote: Module Name: src Committed By: dyoung Date: Sat Nov 7 00:05:49 UTC 2009 Modified Files: src/sys/dev/ppbus: ppbus_conf.c Log Message: Don't deactivate a child before detaching it, that's not necessary. Don't take a device off of the ppbus(4)'s list of children in the detach routine, but add a child-detachment hook that does it for us. As a nice side-effect, we can probably detach ppbus(4) children with drvctl(8), now. Compile-tested, only. XXX Does anybody even use ppbus(4)? It's not even in the ALL XXX configuration for i386! At last, hans@ wrote a gpio backend for ppbus. Shouldn't ppbus replace lpt ? Christoph
Re: CVS commit: src/sys/rump/librump/rumpkern
David Laight wrote: Module Name: src Committed By: dsl Date: Sat Nov 7 12:08:35 UTC 2009 Modified Files: src/sys/rump/librump/rumpkern: pmap_stub.c Log Message: Fix stub prototype Doh! rump is not build as part of any kernel. Hence gcc didn't catch it. Thanks for fixing. Christoph
Re: CVS commit: src/external/bsd/mdocml/dist
In article 20091107.004816.-432821225@bsdimp.com, M. Warner Losh i...@bsdimp.com wrote: In message: hd2nci$40...@ger.gmane.org chris...@astron.com (Christos Zoulas) writes: : In article 20091106183619.ga2...@britannica.bec.de, : Joerg Sonnenberger jo...@britannica.bec.de wrote: : On Fri, Nov 06, 2009 at 04:53:58PM +, Christos Zoulas wrote: : - portability: warnx - fprintf/perror : : This change is backwards; : we should not be using perror/fprintf but warn/warnx. : : I disagree. They are not portable. Many platforms don't have them. : Some other platforms have functions of the same name, but with different : behavior (OS X). : : It should autoconf them. which ones have the same name, but different behavior on OS X? A quick read of the man pages suggests they are identical... These functions are all implemented in one file that's been trivial to port to Linux and Windows for me in the past... I agree with Christos here: their use is pervasive and it will be confusing to know when to use err and when to use perror + exit... My point here is that we should be pushing ahead with useful features that make the code cleaner and easier to read and maintain, not encourage the laggard OS's not to upgrade/fix their API's by using ancient and awkward API's such as perror(). christos
Re: CVS commit: src/external/bsd/mdocml/dist
In message: 20091107084411.gt15...@snowdrop.l8s.co.uk David Laight da...@l8s.co.uk writes: : On Sat, Nov 07, 2009 at 12:48:16AM -0700, M. Warner Losh wrote: : : which ones have the same name, but different behavior on OS X? A quick read : of the man pages suggests they are identical... : : Check about whether they need a \n at the end of the format. They aren't needed on MacOS, nor FreeBSD. A quick test on 10.5.8 shows that warn doesn't need it. Is there one that does need them? Warner
Re: CVS commit: src/sys/dev/ppbus
On Sat, Nov 07, 2009 at 09:46:01AM +0100, Christoph Egger wrote: Shouldn't ppbus replace lpt ? I don't see why not. Will somebody test it to see if it works? It might help if the lpt(4) drivers (both ppbus and isa attachments) were modularized so that one could swap one for the other at run-time. Dave -- David Young OJC Technologies dyo...@ojctech.com Urbana, IL * (217) 278-3933
Re: CVS commit: src/sys
Hello, Module Name:src Committed By: cegger Date: Sat Nov 7 07:27:50 UTC 2009 ... Log Message: Add a flags argument to pmap_kenter_pa(9). Patch showed on tech-kern@ http://mail-index.netbsd.org/tech-kern/2009/11/04/msg006434.html No objections. Since we have flags argument now, I think PMAP_KMPAGE and friends should no longer be glued together with prot. -- Mindaugas
Re: CVS commit: src/sys
Mindaugas Rasiukevicius wrote: Hello, Module Name:src Committed By: cegger Date: Sat Nov 7 07:27:50 UTC 2009 ... Log Message: Add a flags argument to pmap_kenter_pa(9). Patch showed on tech-kern@ http://mail-index.netbsd.org/tech-kern/2009/11/04/msg006434.html No objections. Since we have flags argument now, I think PMAP_KMPAGE and friends should no longer be glued together with prot. Agree. Also ports which have their own PMAP_NOCACHE and glue it together with prot should implement the flags argument and switch to PMAP_NOCACHE. Christoph
re: CVS commit: src/sys/rump/librump/rumpkern
David Laight wrote: Module Name: src Committed By: dsl Date: Sat Nov 7 12:08:35 UTC 2009 Modified Files: src/sys/rump/librump/rumpkern: pmap_stub.c Log Message: Fix stub prototype Doh! rump is not build as part of any kernel. Hence gcc didn't catch it. Thanks for fixing. when you make a big change like your pmap change you should *ALWAYS* full release before checking in. just one platform would be sufficient. .mrg.
