Re: CVS commit: src/sys/rump/librump/rumpkern

2010-11-22 Thread Nick Hudson
On Sunday 21 November 2010 21:46:43 Antti Kantee wrote:
 Module Name:  src
 Committed By: pooka
 Date: Sun Nov 21 21:46:43 UTC 2010
 
 Modified Files:
   src/sys/rump/librump/rumpkern: Makefile.rumpkern
 Added Files:
   src/sys/rump/librump/rumpkern: atomic_cas_up.c
 
 Log Message:
 Add a lockless uniprocessor version of atomic_cas_generic.c, which
 is currently used by all the archs that previously used cas_generic.

This break arm platform builds.

/usr/src/lib/librump/../../sys/rump/../lib/libkern/../../../common/lib/libc/arch/arm/atomic/atomic_cas_up.S:
 
Assembler messages:   
/usr/src/lib/librump/../../sys/rump/../lib/libkern/../../../common/lib/libc/arch/arm/atomic/atomic_cas_up.S:38:
 
Error: bad instruction `ras_start_asm_hidden(_atomic_cas)'  

  
/usr/src/lib/librump/../../sys/rump/../lib/libkern/../../../common/lib/libc/arch/arm/atomic/atomic_cas_up.S:42:
 
Error: bad instruction `ras_end_asm_hidden(_atomic_cas)'

  
*** [atomic_cas_up.pico] Error code 1   

   

Nick


Re: CVS commit: src/sys/rump/librump/rumpkern

2010-11-22 Thread Nick Hudson
On Monday 22 November 2010 10:51:03 Antti Kantee wrote:
 On Mon Nov 22 2010 at 10:35:00 +, Nick Hudson wrote:
  On Sunday 21 November 2010 21:46:43 Antti Kantee wrote:
   Module Name:  src
   Committed By: pooka
   Date: Sun Nov 21 21:46:43 UTC 2010
  
   Modified Files:
 src/sys/rump/librump/rumpkern: Makefile.rumpkern
   Added Files:
 src/sys/rump/librump/rumpkern: atomic_cas_up.c
  
   Log Message:
   Add a lockless uniprocessor version of atomic_cas_generic.c, which
   is currently used by all the archs that previously used cas_generic.
 
  This break arm platform builds.
 
  /usr/src/lib/librump/../../sys/rump/../lib/libkern/../../../common/lib/li
 bc/arch/arm/atomic/atomic_cas_up.S: Assembler messages:
  /usr/src/lib/librump/../../sys/rump/../lib/libkern/../../../common/lib/li
 bc/arch/arm/atomic/atomic_cas_up.S:38: Error: bad instruction
  `ras_start_asm_hidden(_atomic_cas)'
  /usr/src/lib/librump/../../sys/rump/../lib/libkern/../../../common/lib/li
 bc/arch/arm/atomic/atomic_cas_up.S:42: Error: bad instruction
  `ras_end_asm_hidden(_atomic_cas)'
  *** [atomic_cas_up.pico] Error code 1
 
 Fixed.  I'll run a build just to make sure.
 

Thanks for the quick response.

Nick


Re: CVS commit: src/lib/libpam/modules/pam_ssh

2010-11-22 Thread Izumi Tsutsui
mrg@ wrote:

 there's *really* broken code that writes to a time_t via a long*.

OpenBSD still uses long (not time_t) for tv_sec in struct timeval...

---
Izumi Tsutsui


Re: CVS commit: src/lib/libpam/modules/pam_ssh

2010-11-22 Thread Christos Zoulas
On Nov 22, 11:10pm, tsut...@ceres.dti.ne.jp (Izumi Tsutsui) wrote:
-- Subject: Re: CVS commit: src/lib/libpam/modules/pam_ssh

| mrg@ wrote:
| 
|  there's *really* broken code that writes to a time_t via a long*.
| 
| OpenBSD still uses long (not time_t) for tv_sec in struct timeval...

Yes, but the portable openssh cannot make such assumptions! After all,
according to posix time_t can be float.

christos


Re: CVS commit: src/bin/dd

2010-11-22 Thread Antti Kantee
On Mon Nov 22 2010 at 22:09:24 +, David Laight wrote:
 On Mon, Nov 22, 2010 at 09:04:28PM +, Antti Kantee wrote:
  Module Name:src
  Committed By:   pooka
  Date:   Mon Nov 22 21:04:28 UTC 2010
  
  Modified Files:
  src/bin/dd: Makefile args.c dd.c dd.h extern.h position.c
  
  Log Message:
  Add two new operands: rif and rof.  They operate exactly like
  if and of with the exception that the communicate with a rump
  kernel instead of the host kernel.
 
 H this seems like polluting a standard utility to support
 a very specific use.
 
 Surely it would be more appropriate to make thye rump kernel directly
 forward some paths to the real kernel?

Can you explain how that could work?


Re: CVS commit: src

2010-11-22 Thread Adam Hamsik

On Nov,Monday 22 2010, at 9:42 PM, Antti Kantee wrote:

 Module Name:  src
 Committed By: pooka
 Date: Mon Nov 22 20:42:19 UTC 2010
 
 Modified Files:
   src/lib/librumpuser: rumpuser_sp.c
   src/sys/rump/include/rump: rumpuser.h
   src/sys/rump/librump/rumpkern: lwproc.c rump.c rumpcopy.c vm.c
 
 Log Message:
 Support physio for remote processes.
 == add support for remote vmspace vmapbuf/vunmapbuf
  == add proper support for copyin/out_vmspace
== add support for remote vmspace uvm_io
  == add support for non-curproc rumpuser_sp_copyin/out
== store remote context in vm_map-pmap instead of
pthread_specificdata
 
 In short, makes read/write of most (all?) block devices work from
 a remote rump client via rump syscalls.

Cool I have been waiting for this, now I can write proper dm test suite with 
rump ;) 

Thanks Antti

Regards

Adam.



Re: CVS commit: src/bin/dd

2010-11-22 Thread David Holland
On Mon, Nov 22, 2010 at 10:09:24PM +, David Laight wrote:
   Add two new operands: rif and rof.  They operate exactly like
   if and of with the exception that the communicate with a rump
   kernel instead of the host kernel.
  
  H this seems like polluting a standard utility to support
  a very specific use.

(Was this discussed anywhere?)

  Surely it would be more appropriate to make thye rump kernel directly
  forward some paths to the real kernel?

Yeah, that...

-- 
David A. Holland
dholl...@netbsd.org