Re: CVS commit: src/crypto/external/bsd/libsaslc/dist/src
Christos Zoulas chris...@netbsd.org wrote Module Name: src Committed By: christos Date: Sun Feb 13 05:39:52 UTC 2011 Modified Files: src/crypto/external/bsd/libsaslc/dist/src: mech.c Log Message: Make all mechanisms optional, so we can compile in only the ones we want. @@ -100,7 +106,9 @@ saslc__error_set_errno(ERR(ctx), ERROR_NOMEM); return NULL; } - for (i = 0; saslc__mechanisms[i] != NULL; i++) { + for (i = 0; __arraycount(saslc__mechanisms); i++) { + if (saslc__mechanisms[i] == NULL) + continue; if ((node = calloc(1, sizeof(*node))) == NULL) goto error; i is missing? -- Takeshi Nakayama
Re: CVS commit: src/crypto/external/bsd/libsaslc/dist/src
On Feb 14, 9:30pm, t...@catvmics.ne.jp (Takeshi Nakayama) wrote: -- Subject: Re: CVS commit: src/crypto/external/bsd/libsaslc/dist/src | Christos Zoulas chris...@netbsd.org wrote | | Module Name:src | Committed By: christos | Date: Sun Feb 13 05:39:52 UTC 2011 | | Modified Files: | src/crypto/external/bsd/libsaslc/dist/src: mech.c | | Log Message: | Make all mechanisms optional, so we can compile in only the ones we want. | | @@ -100,7 +106,9 @@ | saslc__error_set_errno(ERR(ctx), ERROR_NOMEM); | return NULL; | } | - for (i = 0; saslc__mechanisms[i] != NULL; i++) { | + for (i = 0; __arraycount(saslc__mechanisms); i++) { | + if (saslc__mechanisms[i] == NULL) | + continue; | if ((node = calloc(1, sizeof(*node))) == NULL) | goto error; Fixed, thanks. christos
Re: CVS commit: src/external/ibm-public/postfix
In article 20110214074822.ga...@colwyn.zhadum.org.uk, Matthias Scheler t...@netbsd.org wrote: On Sun, Feb 13, 2011 at 09:37:12PM +, Christos Zoulas wrote: Do we really want to support USE_LIB_SASL=cyrus? Linking stuff in base again libraries from pkgsrc sounds like a big hack to me and will e.g. break cross compiling. I did not put it there, I found it there. As far as I can tell you added it in revision 1.3: Ok, not intentionally :-) christos