Re: CVS commit: src/share/mk
On Mon, Mar 07, 2011 at 07:05:04PM +, Julio Merino wrote:
> Module Name: src
> Committed By: jmmv
> Date: Mon Mar 7 19:05:04 UTC 2011
>
> Modified Files:
> src/share/mk: bsd.prog.mk
>
> Log Message:
> Always convert PROG to its plural form independently of whether PROG_CXX
> is defined or not. From Garrett Cooper in private mail.
>
>
> To generate a diff of this commit:
> cvs rdiff -u -r1.260 -r1.261 src/share/mk/bsd.prog.mk
>
> Please note that diffs are not public domain; they are subject to the
> copyright notices on the relevant files.
>
> Modified files:
>
> Index: src/share/mk/bsd.prog.mk
> diff -u src/share/mk/bsd.prog.mk:1.260 src/share/mk/bsd.prog.mk:1.261
> --- src/share/mk/bsd.prog.mk:1.260Sun Feb 20 20:16:01 2011
> +++ src/share/mk/bsd.prog.mk Mon Mar 7 19:05:03 2011
> @@ -1,4 +1,4 @@
> -#$NetBSD: bsd.prog.mk,v 1.260 2011/02/20 20:16:01 jmmv Exp $
> +#$NetBSD: bsd.prog.mk,v 1.261 2011/03/07 19:05:03 jmmv Exp $
> #@(#)bsd.prog.mk 8.2 (Berkeley) 4/2/94
>
> .ifndef HOSTPROG
> @@ -262,7 +262,8 @@
> .if !defined(RUMPPRG)
> . if defined(PROG_CXX) && !defined(PROGS_CXX)
> PROGS_CXX= ${PROG_CXX}
> -. elif defined(PROG) && !defined(PROGS)
> +. endif
> +. if defined(PROG) && !defined(PROGS)
> PROGS= ${PROG}
> . endif
> .endif
>
Now if PROG_CXX is defined, both PROGS and PROGS_CXX refer to
PROG_CXX. Thus the ".for _P in ${PROGS} ${PROGS_CXX}" loop runs
twice.
Re: CVS commit: src/sys/arch/x86/x86
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hello, On Mar 7, 2011, at 10:48 PM, Jared McNeill wrote: On Tue, 8 Mar 2011, Michael Lorenz wrote: Modified Files: src/sys/arch/x86/x86: x86_autoconf.c lol I was tempted to add something like "Yes Jared, hell did freeze over" ;) have fun Michael -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.7 (Darwin) iQEVAwUBTXWoaspnzkX8Yg2nAQKd1gf+M4hCoLwaPVpvQy1gY+iv6rQKUNQ/r+mm tDKbOxDOZP0zQ5TO19ri3hwAvoeRgWKcxftrzYeomiGqWjrSuQ860jjmH2U8ocz9 f1HMPWhc04X3c6lJad5GAxSogOcet5xkan3byJt2JS4V7G9UJ1mET7UZyzIS/9Xx cUeJ6wMamPWX0SJrLkKNqJ8OpdaY6PZVMMXGU4zZu6cUTdXlLGs372xMMo1yDjYj c3qTtFXLA4idp58CS6Qr32fPIdKrh9PrlSb8+5QfazSz9E3VsajskO86+83A2lHU PBzJuMvx2G3tflBpDe8IQ2btIu+7ShoMCmIvbDxbFRZDJx4V9ySxTQ== =0uJJ -END PGP SIGNATURE-
Re: CVS commit: src/sys/arch/x86/x86
On Tue, 8 Mar 2011, Michael Lorenz wrote: Modified Files: src/sys/arch/x86/x86: x86_autoconf.c lol
Re: CVS commit: src/usr.bin/quota
On Mar 7, 12:47pm, bou...@antioche.eu.org (Manuel Bouyer) wrote: -- Subject: Re: CVS commit: src/usr.bin/quota | this was repoquota failing to properly format its output. I fixed it. Thanks! christos
Re: CVS commit: src/usr.bin/quota
On Mon, Mar 07, 2011 at 11:30:14AM +, Antti Kantee wrote: > On Sun, Mar 06, 2011 at 09:12:49PM +, Christos Zoulas wrote: > > In article <20110306205803.ga15...@antioche.eu.org>, > > Manuel Bouyer wrote: > > >On Sun, Mar 06, 2011 at 03:48:00PM -0500, Christos Zoulas wrote: > > >> Module Name: src > > >> Committed By:christos > > >> Date:Sun Mar 6 20:47:59 UTC 2011 > > >> > > >> Modified Files: > > >> src/usr.bin/quota: Makefile getvfsquota.c getvfsquota.h printquota.c > > >> printquota.h quota.c > > >> > > >> Log Message: > > >> - WARNS=4 > > >> - KNF > > >> - don't cast malloc > > >> - don't use static buffers > > >> - fix types > > >> - remove extra \n's from errors > > >> - fix prototypes > > > > > >this breaks the build. These utitilies are used bu other quota tools. > > >Why did you #if 0 timepprt() ? it's used by edquota > > > > I'll add them back. > > Can you also fix fallout so that tests pass once again? > > http://www.gson.org/netbsd/bugs/build/build/2011.03.07.03.29.26/test.html#failed-tcs-summary > > tests last passed here: > http://www.gson.org/netbsd/bugs/build/build/2011.03.06.20.36.29/test.html this was repoquota failing to properly format its output. I fixed it. -- Manuel Bouyer NetBSD: 26 ans d'experience feront toujours la difference --
Re: CVS commit: src/usr.bin/quota
On Sun, Mar 06, 2011 at 09:12:49PM +, Christos Zoulas wrote: > In article <20110306205803.ga15...@antioche.eu.org>, > Manuel Bouyer wrote: > >On Sun, Mar 06, 2011 at 03:48:00PM -0500, Christos Zoulas wrote: > >> Module Name: src > >> Committed By: christos > >> Date: Sun Mar 6 20:47:59 UTC 2011 > >> > >> Modified Files: > >>src/usr.bin/quota: Makefile getvfsquota.c getvfsquota.h printquota.c > >>printquota.h quota.c > >> > >> Log Message: > >> - WARNS=4 > >> - KNF > >> - don't cast malloc > >> - don't use static buffers > >> - fix types > >> - remove extra \n's from errors > >> - fix prototypes > > > >this breaks the build. These utitilies are used bu other quota tools. > >Why did you #if 0 timepprt() ? it's used by edquota > > I'll add them back. Can you also fix fallout so that tests pass once again? http://www.gson.org/netbsd/bugs/build/build/2011.03.07.03.29.26/test.html#failed-tcs-summary tests last passed here: http://www.gson.org/netbsd/bugs/build/build/2011.03.06.20.36.29/test.html
