Re: CVS commit: src/sys/dev/sysmon

2011-06-15 Thread Paul Goyette

On Wed, 15 Jun 2011, Paul Goyette wrote:


Module Name:src
Committed By:   pgoyette
Date:   Wed Jun 15 13:34:13 UTC 2011

Modified Files:
src/sys/dev/sysmon: sysmon_envsys.c

Log Message:
Previous fix broke the setting of current value for Indicator and
Battery-Charge sensors.  Fix this.


Forgot to add:

Thanks to jruoho@ for finding this.


-
| Paul Goyette | PGP Key fingerprint: | E-mail addresses:   |
| Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com|
| Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at juniper.net |
| Kernel Developer |  | pgoyette at netbsd.org  |
-


Re: CVS commit: src/tests

2011-06-15 Thread Julio Merino

On 6/15/11 3:36 AM, Christos Zoulas wrote:

On Jun 14,  5:14am, jruoho...@iki.fi (Jukka Ruohonen) wrote:
-- Subject: Re: CVS commit: src/tests

| On Sat, Jun 11, 2011 at 02:03:20PM -0400, Christos Zoulas wrote:
|>  Log Message:
|>  Turn warns on for all tests and fix all the bugs.
|
| Thanks for the cleanup.
|
| Now the "wscrl"-test (lib/libcurses/t_curses) however fails:
|

Peeling though the layers and trying to figure out what's going on is really
annoying. So:

Let's start: t_curses is a shell script.

Try to run it from source:

$ cd /usr/src/tests/lib/libcurses
$ atf-run obj.amd64/t_curses
atf-run: ERROR: Cannot open Atffile


$ cd /usr/src/tests/lib/libcurses
$ make test


Beautiful, we have a command that takes arguments from the command line,
the environment, and has default arguments, that I need to read the source
to find them.

I won't bore you any more with this, but I am still peeling layers of brown
cylindrical items to find out what's going on with the test program.

Surely, there must be a simpler way to isolate the test program that is
running so that I can run it by hand and debug it! So what is it?


I'm not sure how the curses tests work, but based on what you show above 
they seem complex.  In general, just doing the "t_foo bar" dance is 
enough for debugging.


--
Julio Merino / @jmmv