Re: CVS commit: src/external/mit/lua/dist/src

2012-03-14 Thread Bernd Ernesti 
On Thu, Mar 15, 2012 at 01:25:06AM +, Alexander Nasonov wrote:
> Alexander Nasonov wrote:
> > Log Message:
> > Don't overwrite Roberto's external $Id.
> 
> This made me realise that all external "$Id" were changed to "Id"
> by the previous import and that there is a script that does this
> replacement (external/mit/lua/dist/lua2netbsd). I will use it next
> time.
> 
> Hopefully, everything else is fine, this was my first import over
> existing code.

It would be great to have a short summary in the cvs import log
what changed in the new version instead of just 'Import Lua 5.1.5'.
That doesn't have to be the full changelog.

Bernd

Re: CVS commit: src/external/mit/lua/dist/src

2012-03-14 Thread Christos Zoulas 
In article <20120315012505.GA30246@x1000.localdomain>,
Alexander Nasonov   wrote:
>Alexander Nasonov wrote:
>> Log Message:
>> Don't overwrite Roberto's external $Id.
>
>This made me realise that all external "$Id" were changed to "Id"
>by the previous import and that there is a script that does this
>replacement (external/mit/lua/dist/lua2netbsd). I will use it next
>time.
>
>Hopefully, everything else is fine, this was my first import over
>existing code.

You could just re-import it with the same tag on top.

christos

Re: CVS commit: src/external/mit/lua/dist/src

2012-03-14 Thread Alexander Nasonov 
Alexander Nasonov wrote:
> Log Message:
> Don't overwrite Roberto's external $Id.

This made me realise that all external "$Id" were changed to "Id"
by the previous import and that there is a script that does this
replacement (external/mit/lua/dist/lua2netbsd). I will use it next
time.

Hopefully, everything else is fine, this was my first import over
existing code.

Alex

Re: CVS commit: src/lib/libc

2012-03-14 Thread Christos Zoulas 
On Mar 14, 10:40pm, mar...@duskware.de (Martin Husemann) wrote:
-- Subject: Re: CVS commit: src/lib/libc

| On Wed, Mar 14, 2012 at 04:02:28PM -0400, Christos Zoulas wrote:
| > This means we cannot use them for the PIC build of libc... I will fix it.
| 
| Or we need to provide stubs for ld.elf_so (the PIC libc might find other
| uses).

I added a __diagassert13() stub to rtld for now. A better fix is forthcoming.

christos

Re: CVS commit: src/lib/libc

2012-03-14 Thread Joerg Sonnenberger 
On Wed, Mar 14, 2012 at 10:40:27PM +0100, Martin Husemann wrote:
> On Wed, Mar 14, 2012 at 04:02:28PM -0400, Christos Zoulas wrote:
> > This means we cannot use them for the PIC build of libc... I will fix it.
> 
> Or we need to provide stubs for ld.elf_so (the PIC libc might find other
> uses).

I posted a patch a while ago to hand pick the closure for ld.elf_so.
It might need a bit more work to get the correct choices for all the
libgcc parts, but it would avoid unintentional junk getting pulled in.

Joerg

Re: CVS commit: src/lib/libc

2012-03-14 Thread Martin Husemann 
On Wed, Mar 14, 2012 at 04:02:28PM -0400, Christos Zoulas wrote:
> This means we cannot use them for the PIC build of libc... I will fix it.

Or we need to provide stubs for ld.elf_so (the PIC libc might find other
uses).

Martin

Re: CVS commit: src/lib/libc

2012-03-14 Thread Christos Zoulas 
On Mar 14,  8:44pm, mar...@duskware.de (Martin Husemann) wrote:
-- Subject: Re: CVS commit: src/lib/libc

| On Wed, Mar 14, 2012 at 04:55:01PM +, Christos Zoulas wrote:
| > 1. commit the changes as they are (cast+diagassert)
| 
| The diagasserts are pulled into ld.elf_so and break the build for
| at least sparc64.
| 
| A map of -current ld.elf_so and netbsd-6 are attached for comparision.
| It starts with:
| 
|  /usr/obj/sparc64/lib/libc/libc_pic.a(ctype_.pico)
|expand.o (_ctype_)
| +/usr/obj/sparc64/lib/libc/libc_pic.a(assert.pico)
| +  
/usr/obj/sparc64/lib/libc/libc_pic.a(strsep.pico)
|  (__diagassert13)
| 
| and then goes via getenv, fprintf, citrus, 

This means we cannot use them for the PIC build of libc... I will fix it.

christos

Re: CVS commit: src/lib/libc

2012-03-14 Thread Christos Zoulas 
In article <20120313212708.ga29...@britannica.bec.de>,
Joerg Sonnenberger   wrote:
>
>Thanks for ignoring my comments. It's especially useful that you
>haven't really addressed any of the points. Checking casts from size_t
>to uint32_t is useless on a good number of our architectures. Other
>places have proper checks already in place, so this just adds bloat.

I did not ignore your comments. I brought them up to core, since it
became apparent to me that we would not reach agreement in this. I
offered core 4 solutions:

1. commit the changes as they are (cast+diagassert)
2. commit just the casts without diagassert
3. close the lint PR, and say this is not going to be fixed
   leaving things as they are.
4. give up on lint and remove it alltogether.

Core voted for (1). They can change their minds and vote again, and I will
make the necessary changes.

christos

Re: CVS commit: src/sys/sys

2012-03-14 Thread NONAKA Kimihiro 
Hi,

2012/3/14 Christos Zoulas :

> Module Name:    src
> Committed By:   christos
> Date:           Tue Mar 13 21:07:28 UTC 2012
>
> Modified Files:
>        src/sys/sys: cdefs.h
>
> Log Message:
> Type macros providing min and max values for the given type, plus one that
> returns if a value can be represented in a given type.
>
>
> To generate a diff of this commit:
> cvs rdiff -u -r1.92 -r1.93 src/sys/sys/cdefs.h
>
> Please note that diffs are not public domain; they are subject to the
> copyright notices on the relevant files.
>

depending the kern library objects
depending the compat library objects
making sure the compat library is up to date...
`libcompat.a' is up to date.
making sure the kern library is up to date...
#   compile  kern/atomic_add.o
/usr/local/netbsd-tools/evbmips64-el/bin/mips64el--netbsd-gcc -msym32
-mabi=64 -mno-abicalls -x assembler-with-cpp  -D_LOCORE
-Wa,--fatal-warnings  -mips3 -mdivide-breaks -Wa,-mfix-loongson2f-btb
-Wa,--fatal-warnings
--sysroot=/home/snapshot/20120313/root/evbmips64-el
-I/usr/src/sys/lib/libkern/arch/mips
--sysroot=/home/snapshot/20120313/root/evbmips64-el -Devbmips
-I../../. -I/usr/src/sys/../common/include -I/usr/src/sys/arch
-I/usr/src/sys -nostdinc -DMIPS3_ENABLE_CLOCK_INTR -DMIPS3_LOONGSON2
-DMIPS3 -DMIPS3_LOONGSON2F -DLOONGSON2 -DDIAGNOSTIC
-DMSGBUFSIZE="8192" -DMAXUSERS=16 -D_KERNEL -D_KERNEL_OPT -std=gnu99
-I/usr/src/sys/lib/libkern/../../../common/lib/libc/quad
-I/usr/src/sys/lib/libkern/../../../common/lib/libc/string
-I/usr/src/sys/lib/libkern/../../../common/lib/libc/arch/mips/string
-I/usr/src/sys/dist/ipf
-I/usr/src/sys/lib/libkern/../../../common/lib/libc/quad
-I/usr/src/sys/lib/libkern/../../../common/lib/libc/string
-I/usr/src/sys/lib/libkern/../../../common/lib/libc/arch/mips/string
-I/usr/src/sys/lib/libkern/../../../common/include  -x
assembler-with-cpp -c
/usr/src/sys/lib/libkern/../../../common/lib/libc/arch/mips/atomic/atomic_add.S
-o atomic_add.o
/usr/src/sys/sys/cdefs.h: Assembler messages:
/usr/src/sys/sys/cdefs.h:536: Error: unrecognized opcode `static
inline long long __zero(void){return 0'
/usr/src/sys/sys/cdefs.h:536: Error: junk at end of line, first
unrecognized character is `}'
/usr/src/sys/sys/cdefs.h:537: Error: unrecognized opcode `static
__inline int __negative(double x){return x<0'
/usr/src/sys/sys/cdefs.h:537: Error: junk at end of line, first
unrecognized character is `}'

*** Failed target:  atomic_add.o
*** Failed command:
/usr/local/netbsd-tools/evbmips64-el/bin/mips64el--netbsd-gcc -msym32
-mabi=64 -mno-abicalls -x assembler-with-cpp -D_LOCORE
-Wa,--fatal-warnings -mips3 -mdivide-breaks -Wa,-mfix-loongson2f-btb
-Wa,--fatal-warnings
--sysroot=/home/snapshot/20120313/root/evbmips64-el
-I/usr/src/sys/lib/libkern/arch/mips
--sysroot=/home/snapshot/20120313/root/evbmips64-el -Devbmips
-I../../. -I/usr/src/sys/../common/include -I/usr/src/sys/arch
-I/usr/src/sys -nostdinc -DMIPS3_ENABLE_CLOCK_INTR -DMIPS3_LOONGSON2
-DMIPS3 -DMIPS3_LOONGSON2F -DLOONGSON2 -DDIAGNOSTIC
-DMSGBUFSIZE="8192" -DMAXUSERS=16 -D_KERNEL -D_KERNEL_OPT -std=gnu99
-I/usr/src/sys/lib/libkern/../../../common/lib/libc/quad
-I/usr/src/sys/lib/libkern/../../../common/lib/libc/string
-I/usr/src/sys/lib/libkern/../../../common/lib/libc/arch/mips/string
-I/usr/src/sys/dist/ipf
-I/usr/src/sys/lib/libkern/../../../common/lib/libc/quad
-I/usr/src/sys/lib/libkern/../../../common/lib/libc/string
-I/usr/src/sys/lib/libkern/../../../common/lib/libc/arch/mips/string
-I/usr/src/sys/lib/libkern/../../../common/include -x
assembler-with-cpp -c
/usr/src/sys/lib/libkern/../../../common/lib/libc/arch/mips/atomic/atomic_add.S
-o atomic_add.o
*** Error code 1

Stop.
nbmake: stopped in /usr/obj.evbmips/sys/arch/evbmips/compile/LOONGSON/lib/kern

*** Failed target:
/usr/obj.evbmips/sys/arch/evbmips/compile/LOONGSON/lib/kern/libkern.a
*** Failed command: cd
/usr/obj.evbmips/sys/arch/evbmips/compile/LOONGSON/lib/kern &&
/usr/local/netbsd-tools/evbmips64-el/bin/nbmake -f
/usr/src/sys/lib/libkern/Makefile KERNDIR=/usr/src/sys/lib/libkern
CC=/usr/local/netbsd-tools/evbmips64-el/bin/mips64el--netbsd-gcc
CFLAGS=\ -G\ 0\ -mno-abicalls\ -msoft-float\ -ffixed-24\ -msym32\
-mabi=64\ -ffreestanding\ -fno-zero-initialized-in-bss\ -g\ -O2\
-msoft-float\ -fno-strict-aliasing\ \ \ -std=gnu99\ -Werror\ -Wall\
-Wno-main\ -Wno-format-zero-length\ -Wpointer-arith\
-Wmissing-prototypes\ -Wstrict-prototypes\ -Wold-style-definition\
-Wswitch\ -Wshadow\ -Wcast-qual\ -Wwrite-strings\
-Wno-unreachable-code\ -Wno-pointer-sign\ -Wno-attributes\
-Wno-sign-compare\ \ \ -mips3\ -mdivide-breaks\
-Wa,-mfix-loongson2f-btb\ -Wa,--fatal-warnings
AS=/usr/local/netbsd-tools/evbmips64-el/bin/mips64el--netbsd-as
AFLAGS=\ -msym32\ -mabi=64\ -mno-abicalls\ -x\ assembler-with-cpp\ \
-D_LOCORE\ -Wa,--fatal-warnings\ \ -mips3\ -mdivide-breaks\
-Wa,-mfix-loongson2f-btb\ -Wa,--fatal-warnings
LORDER=NM=/usr/local/netbsd-tools/evbmips64-el/bin/mips64el--netbsd-nm\
MKTEMP=/usr/local/netbsd-tools/evbmips64-el/bin/nbmktemp\