Re: CVS commit: src

2013-07-24 Thread Jukka Ruohonen
On Wed, Jul 24, 2013 at 11:45:48AM +, Nick Hudson wrote:
> Module Name:  src
> Committed By: skrll
> Date: Wed Jul 24 11:45:48 UTC 2013
> 
> Modified Files:
>   src/doc: HACKS
>   src/tests/lib/libc/sys: Makefile
> 
> Log Message:
> There wasn't a codegen bug - the test program itself was buggy.
> 
> Nothing to see hear... move along.

Thanks, my bug. I am not sure why I have interpreted the size of a message
to be the size of the structure. Maybe some indirect note could be added to
the manual page for dummies like me.

- Jukka.


Re: CVS commit: [riastradh-drm2] src/sys/external/bsd/drm2/include/linux

2013-07-24 Thread Alan Barrett

On Wed, 24 Jul 2013, Taylor R Campbell wrote:

Module Name:src
Committed By:   riastradh
Date:   Wed Jul 24 01:54:19 UTC 2013

Modified Files:
src/sys/external/bsd/drm2/include/linux [riastradh-drm2]: types.h

Log Message:
Define cycles_t to be unsigned long long for now in .


Could we use a fixed-size type?  Perhaps uint64_t?

If this type is never exposed to userland then it doesn't matter, 
but if it is exposed to userland then a fixed-size type makes it 
easier to provide compatibility between 32-bit and 64-bit versions 
of related platforms.  i386 and amd64 both have 64-bit long long, 
so it doesn't affect them, but other pairs of related platforms 
(perhaps in the future) might be different.


--apb (Alan Barrett)


Re: CVS commit: src/bin/hostname

2013-07-24 Thread Alan Barrett

On Fri, 19 Jul 2013, Roy Marples wrote:

Module Name:src
Committed By:   roy
Date:   Fri Jul 19 10:34:51 UTC 2013

Modified Files:
src/bin/hostname: hostname.1 hostname.c


If we want these changes (which is by no means clear -- I can't 
find any discussion of these new options, what they are good 
for, or why we want them), then we should at least document them 
better.



+.It Fl A
+Display the FQDN of each address on all interfaces.
+.It Fl a
+Display alias name(s) of the host.
+.It Fl d
+Display the DNS domain.
+.It Fl f
+Display the FQDN for the hostname.
+.It Fl I
+Display each IP address on all interfaces.
+.It Fl i
+Display the IP address(es) for the hostname.
.It Fl s
-Trims off any domain information from the printed
-name.
+Display the short hostname.


The man page should define all these terms, and explain how they are
related to each other.

--apb (Alan Barrett)


Re: CVS commit: src/bin/hostname

2013-07-24 Thread Alan Barrett

On Fri, 19 Jul 2013, Erik Fair wrote:

Modified Files:
src/bin/hostname: hostname.1 hostname.c

Log Message:
Add the following options
-A Display the FQDN of each address on all interfaces.
-a Display alias name(s) of the host.
-d Display the DNS domain.
-f Display the FQDN for the hostname.
-I Display each IP address on all interfaces.
-i Display the IP address(es) for the hostname.
Not to go all Rob Pike on you (cf. "cat -v considered harmful"), 
but what the heck is all this for?


And also: Where was this change discussed?

--apb (Alan Barrett)


Re: CVS commit: [riastradh-drm2] src/sys/external/bsd/drm2/dist/drm/i915

2013-07-24 Thread David Laight
On Wed, Jul 24, 2013 at 03:47:07AM +, Taylor R Campbell wrote:
> Module Name:  src
> Committed By: riastradh
> Date: Wed Jul 24 03:47:07 UTC 2013
> 
> Modified Files:
>   src/sys/external/bsd/drm2/dist/drm/i915 [riastradh-drm2]: intel_panel.c
> 
> Log Message:
> Kludge around max as a local variable in intel_panel.c.

Possibly adding a #define for max/min before/after including the
netbsd header that defines these as a function/define would solve
this in the wrapper headers?

David

-- 
David Laight: da...@l8s.co.uk