Re: CVS commit: src/sys/arch/x86/x86

2013-12-08 Thread Jukka Ruohonen
On Sun, Dec 08, 2013 at 04:07:38AM +, SAITOH Masanobu wrote:
 Module Name:  src
 Committed By: msaitoh
 Date: Sun Dec  8 04:07:38 UTC 2013
 
 Modified Files:
   src/sys/arch/x86/x86: tsc.c
 
 Log Message:
  Update invariant TSC detect code from both Intel and AMD documents.
 The best way to check whether the TSC counter is invariant or not is to check
 CPUID 8007.

It might be worth to refactor this as a function, given that the code is
replicated in arch/x86/acpi/acpi_cpu_md.c.

- Jukkal.


Re: CVS commit: src/sys/arch/x86/x86

2013-12-08 Thread SAITOH Masanobu
(2013/12/08 19:21), Jukka Ruohonen wrote:
 On Sun, Dec 08, 2013 at 04:07:38AM +, SAITOH Masanobu wrote:
 Module Name: src
 Committed By:msaitoh
 Date:Sun Dec  8 04:07:38 UTC 2013

 Modified Files:
  src/sys/arch/x86/x86: tsc.c

 Log Message:
  Update invariant TSC detect code from both Intel and AMD documents.
 The best way to check whether the TSC counter is invariant or not is to check
 CPUID 8007.
 
 It might be worth to refactor this as a function, given that the code is
 replicated in arch/x86/acpi/acpi_cpu_md.c.
 
 - Jukkal.

 Yes, the code can be shared. I'm new to x86 and I'm not familiar
with acpi, so please do it if you can :)

 For last few months, I have been reading documents and code around
CPUID and MSR registers. While reading the code, I knew I had to check
ACPI stuff, but I've not done it yet :-

-- 
---
SAITOH Masanobu (msai...@execsw.org
 msai...@netbsd.org)

  * 英語 - 自動検出
  * 英語
  * 日本語

  * 英語
  * 日本語

 javascript:void(0); #