Re: CVS commit: src/sys

[Mindaugas Rasiukevicius]

David Holland  wrote:
> On Tue, Jul 01, 2014 at 10:16:02AM +, Ryota Ozaki wrote:
>  > Log Message:
>  > Lock IFQ operations when NET_MPSAFE
>  > 
>  > - Introduce NET_MPSAFE
>  >   - not defined by default
> 
> If it compiles (and is expected to continue to compile) please add it
> to ALL.
> 

While it is okay for now, I think this knob should be only for the short
term (i.e. only for transitional period while making changes to the APIs).

-- 
Mindaugas

Re: CVS commit: src/sys/dev/pci

[Joerg Sonnenberger]

On Tue, Jul 01, 2014 at 04:43:17PM -0500, Jonathan A. Kollasch wrote:
> On Tue, Jul 01, 2014 at 12:07:39AM +0200, Joerg Sonnenberger wrote:
> > On Mon, Jun 30, 2014 at 09:33:40PM +, Jonathan A. Kollasch wrote:
> > > Module Name:  src
> > > Committed By: jakllsch
> > > Date: Mon Jun 30 21:33:40 UTC 2014
> > > 
> > > Modified Files:
> > >   src/sys/dev/pci: if_wpireg.h
> > > 
> > > Log Message:
> > > Apply OpenBSD src/sys/dev/pci/if_wpireg.h 1.17.
> > 
> > Can we get a better commit message in the future?
> 
> Well, the whole goal here was to bring us closer to (historical) OpenBSD,
> and the original 1.17 OpenBSD message is nearly completely irrelevant
> what this commit did.

"Reduce diff to ..." is a perfectly valid commit message :)

Joerg