Re: CVS commit: src/sys/arch

2014-07-25 Thread Matt Thomas 

On Jul 24, 2014, at 5:23 PM, matthew green m...@eterna.com.au wrote:

 
 Taylor R Campbell writes:
 Module Name: src
 Committed By:riastradh
 Date:Thu Jul 24 13:42:29 UTC 2014
 
 Modified Files:
  src/sys/arch/amd64/include: vmparam.h
  src/sys/arch/i386/include: vmparam.h
  src/sys/arch/x86/x86: x86_machdep.c
 
 Log Message:
 Add a FIRST1G page freelist to x86, for old graphics devices.
 
 other devices that do this didn't have to change the
 platform code to do it.  see bce(4), which is limited
 to 1GB of ram on laptops that have 2GB.

That maybe true, but using a freelist makes the allocations
much cheaper.

Re: CVS commit: src/share/man/man9

2014-07-25 Thread David Holland 
On Fri, Jul 25, 2014 at 08:38:29AM +, Thomas Klausner wrote:
  Modified Files:
   src/share/man/man9: vnodeops.9
  
  Log Message:
  New sentence, new line. Punctuation formatting nits.

Woops, sorry about that.

-- 
David A. Holland
dholl...@netbsd.org

Re: CVS commit: src/sys/dev/ata

2014-07-25 Thread Alan Barrett 

On Fri, 25 Jul 2014, David A. Holland wrote:

Modified Files:
src/sys/dev/ata: wd.c

Log Message:
Drop the old discard/trim ioctls from wd.c.



-   case DIOCGDISCARDPARAMS: {
-   case DIOCDISCARD: {


These never appeared in a release, so I suppose there's no need to
implement these ioctls in any compat code.

--apb (Alan Barrett)

Re: CVS commit: src/sys/kern

2014-07-25 Thread Maxime Villard 
Le 25/07/2014 10:25, David A. Holland a écrit :
 
 Module Name:  src
 Committed By: dholland
 Date: Fri Jul 25 08:25:47 UTC 2014
 
 Modified Files:
   src/sys/kern: syscalls.master vfs_syscalls.c
 
 Log Message:
 Add fdiscard and posix_fallocate syscalls.
 
 
 To generate a diff of this commit:
 cvs rdiff -u -r1.269 -r1.270 src/sys/kern/syscalls.master
 cvs rdiff -u -r1.487 -r1.488 src/sys/kern/vfs_syscalls.c
 
 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.
 

I think 'error' instead of 'result' is better; it makes clear that it's
an error code, and it's consistent with the other functions in the file.

Re: CVS commit: src/sys/arch

2014-07-25 Thread Taylor R Campbell 
   Date: Fri, 25 Jul 2014 10:23:31 +1000
   from: matthew green m...@eterna.com.au

   Taylor R Campbell writes:
Add a FIRST1G page freelist to x86, for old graphics devices.

   other devices that do this didn't have to change the
   platform code to do it.  see bce(4), which is limited
   to 1GB of ram on laptops that have 2GB.

Yes...but those can just use bus_dmamem_alloc, which in turn can use
uvm_pglistalloc.  The graphics devices need to constrain the pages
allocated for uvm objects, which use uvm_pagealloc.  I proposed a
patch to allow configuring uao to allocate pages with uvm_pglistalloc
instead:

https://mail-index.netbsd.org/tech-kern/2014/05/20/msg017092.html

matt@ objected and suggested using page freelists instead, so I did
that.  Nobody on port-x86 objected to the page freelist code I added:

https://mail-index.netbsd.org/port-amd64/2014/05/21/msg002062.html
https://mail-index.netbsd.org/port-i386/2014/05/21/msg003277.html

So this week I asked about making the mechanism for choosing a
suitable page freelist a MI interface:

https://mail-index.netbsd.org/tech-kern/2014/07/22/msg017391.html

I would like to nail this down pronto so that we have a chance to pull
up graphics fixes to netbsd-7 without having to bring in whole new
bus_dma gizmos.  I don't care how it works -- I just want some MI way
to demand that the pages allocated for a uao be fit for bus_dma,
whether it be by page freelists or uvm_pglistalloc or something else
altogether.

Re: CVS commit: src/sys/kern

2014-07-25 Thread David Holland 
On Fri, Jul 25, 2014 at 11:21:47AM +0200, Maxime Villard wrote:
   Log Message:
   Add fdiscard and posix_fallocate syscalls.
  
  I think 'error' instead of 'result' is better; it makes clear that it's
  an error code, and it's consistent with the other functions in the file.

!

If you care that much, change it...

-- 
David A. Holland
dholl...@netbsd.org

Re: CVS commit: src/sys/kern

2014-07-25 Thread Maxime Villard 
Le 25/07/2014 16:47, David Holland a écrit :
 
 On Fri, Jul 25, 2014 at 11:21:47AM +0200, Maxime Villard wrote:
Log Message:
Add fdiscard and posix_fallocate syscalls.
   
   I think 'error' instead of 'result' is better; it makes clear that it's
   an error code, and it's consistent with the other functions in the file.
 
 !
 
 If you care that much, change it...
 

Also,


http://pubs.opengroup.org/onlinepubs/009695399/functions/posix_fallocate.html

indicates that

The posix_fallocate() function shall fail if:
[...]
[EINVAL]
The len argument was zero or the offset argument was less than zero.

but AFAICT there's no len == 0 check.

4718if (pos  0 || len  0 || len  OFF_T_MAX - pos) {
4719return EINVAL;
4720}