Re: CVS commit: [netbsd-7] src/distrib/atari/floppies/common

2015-03-30 Thread Erik Fair
Why doesn’t adding “-m68020=60” to CPUFLAGS work?

curious,

Erik Fair

 On Mar 29, 2015, at 00:44, Soren Jacobsen s...@netbsd.org wrote:
 
 Module Name:  src
 Committed By: snj
 Date: Sun Mar 29 07:44:46 UTC 2015
 
 Modified Files:
   src/distrib/atari/floppies/common [netbsd-7]: Makefile.images
 
 Log Message:
 Pull up following revision(s) (requested by martin in ticket #652):
   distrib/atari/floppies/common/Makefile.images: revision 1.9
 Use -Os -m68020-60 for DBG. It seems to generate smaller objects than -Os.
 gcc48 with -Os:
 -rwxr-xr-x  1 tsutsui  wheel  1319596 Nov 16 20:50 obj.atari/instbin
 gcc48 with -Os -m68020-60
 -rwxr-xr-x  1 tsutsui  wheel  1314516 Nov 16 20:49 obj.atari/instbin
 This allows ever growing sysinst.fs still fit into 1440KB even with gcc48.
 Acually we need a real solution (ustarfs based floppies etc.) soon
 but we can work around at least for NetBSD 7.0.
 Should be pulled up to netbsd-7 (if NetBSD/m68k 7.0 will switch to gcc48).
 
 
 To generate a diff of this commit:
 cvs rdiff -u -r1.8 -r1.8.26.1 \
src/distrib/atari/floppies/common/Makefile.images
 
 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.
 


Re: CVS commit: src/sys/net/if_vlan.c

2015-03-30 Thread Christoph Badura
On Sun, Mar 29, 2015 at 01:30:43PM +, Ryota Ozaki wrote:
 Module Name:  src
 Committed By: ozaki-r
 Date: Sun Mar 29 13:30:43 UTC 2015
 
 Modified Files:
   src/sys/net: if_vlan.c
 
 Log Message:
 Correct frame padding length
 
 vlan pads a frame with zeros up to 68 bytes
 (ETHER_MIN_LEN + ETHER_VLAN_ENCAP_LEN). It expects
 that even if the frame is untagged, it keeps 64 bytes
 at least. However, it lacks concern about CRC
 (4 bytes). So a sending frame can be 72 (68 + 4) bytes.

I don't get it. ETHER_MIN_LEN includes the 4 bytes for the CRC of a
minimum sized packet.  Therefore ETHER_MIN_LEN + ETHER_VLAN_ENCAP_LEN is
the right size, isn't it?

BTW, what do you mean by it lacks concern about CRC?

--chris