Re: CVS commit: src/sys/compat/netbsd32
On Tue, Jun 23, 2015 at 06:23:36PM +1000, matthew green wrote: > > Log Message: > > Don't reference netbsd32_nfssvc unless NFSSERVER is defined. > > Fixes PR 49994. > > thanks. *bow* -- David A. Holland dholl...@netbsd.org
Re: CVS commit: src/sys/dev/sysmon
yeah - done! thanks! On Tue, 23 Jun 2015, Christoph Badura wrote: On Tue, Jun 23, 2015 at 10:41:42AM +, Paul Goyette wrote: Committed By: pgoyette Date: Tue Jun 23 10:41:42 UTC 2015 Modified Files: src/sys/dev/sysmon: sysmon_envsys_events.c Log Message: Fix the KASSERT - we want to make sure that _both_ pointers are non-NULL, not just that one or the other is non-NULL! Wouldn't it be better written as: KASSERT(sme != NULL); KASSERT(edata != NULL); Same effect, but when one of the triggers you know immediately which pointer was NULL. --chris - | Paul Goyette | PGP Key fingerprint: | E-mail addresses: | | (Retired)| FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com| | Kernel Developer | 0786 F758 55DE 53BA 7731 | pgoyette at netbsd.org | -
Re: CVS commit: src/sys/dev/sysmon
On Tue, Jun 23, 2015 at 10:41:42AM +, Paul Goyette wrote: > Committed By: pgoyette > Date: Tue Jun 23 10:41:42 UTC 2015 > > Modified Files: > src/sys/dev/sysmon: sysmon_envsys_events.c > > Log Message: > Fix the KASSERT - we want to make sure that _both_ pointers are non-NULL, > not just that one or the other is non-NULL! Wouldn't it be better written as: KASSERT(sme != NULL); KASSERT(edata != NULL); Same effect, but when one of the triggers you know immediately which pointer was NULL. --chris
re: CVS commit: src/sys/compat/netbsd32
"David A. Holland" writes: > Module Name: src > Committed By: dholland > Date: Tue Jun 23 04:44:08 UTC 2015 > > Modified Files: > src/sys/compat/netbsd32: syscalls.master > > Log Message: > Don't reference netbsd32_nfssvc unless NFSSERVER is defined. > Fixes PR 49994. thanks.
