Re: CVS commit: src/sys/arch/zaurus/conf

2015-07-19 Thread Martin Husemann 
I backed it out, will try to fix differently.

Martin

Re: CVS commit: src/lib/libc/stdlib

2015-07-19 Thread Joerg Sonnenberger 
On Sun, Jul 19, 2015 at 11:13:48PM +0200, Kamil Rytarowski wrote:
 -BEGIN PGP SIGNED MESSAGE-
 Hash: SHA256
 
 On 19.07.2015 20:56, Joerg Sonnenberger wrote:
  On Thu, Jul 16, 2015 at 12:12:27PM +0200, Kamil Rytarowski wrote:
  The C standard permits memcpy(3) to affect errno(2).
  
  More like it hasn't explicitly ruled it out. That might or might 
  not be seen as an oversight, but pretty much any compiler uses 
  memcpy(3) under the assumption that it does not. If you really care
  about this case, please raise a DR against ISO C and get a 
  clarification of the intention, before further changes to src.
  
 
 Thanks.
 It is also for the consistency with lines 63-64 of the same file.

...which is quite different. free(3) is quite likely to set errno for a
number of reasons and historic versions at least have been known to
actually have failure modes.

Joerg

Re: CVS commit: src/lib/libc/stdlib

2015-07-19 Thread Kamil Rytarowski 
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

On 19.07.2015 20:56, Joerg Sonnenberger wrote:
 On Thu, Jul 16, 2015 at 12:12:27PM +0200, Kamil Rytarowski wrote:
 The C standard permits memcpy(3) to affect errno(2).
 
 More like it hasn't explicitly ruled it out. That might or might 
 not be seen as an oversight, but pretty much any compiler uses 
 memcpy(3) under the assumption that it does not. If you really care
 about this case, please raise a DR against ISO C and get a 
 clarification of the intention, before further changes to src.
 

Thanks.
It is also for the consistency with lines 63-64 of the same file.

Regards,
-BEGIN PGP SIGNATURE-
Version: GnuPG v2

iQIcBAEBCAAGBQJVrBMIAAoJEEuzCOmwLnZsvUsQAIMgD3/aL6pld6VZ521n0+kY
zsv3axqXVO4JwoEYj0g/B4W6vuuWBzkKrSVLJm6Hf/Xjv0ZfpvWwFbT9cq3p5zuH
3uYPhjxNuPM7HTSJvLaQUCK9X0kyB1DEVlF31UOqYE5Tg6zyH9I8SWWYH9uZx/kJ
2Tc3Fl1Vx/p9veyZTsQ0tddEokC97ABTo8tLkBrr7NTimi9G0WfgEMN9fcuMjzSt
BdsnEoYI/w3JZZOcE8HhmgAIJ3osX3Ys9RVmmKJzoIyQr5Sp61hrTsPBM4bx8n55
twbFygd7Fuo/Uc8muVhBDRRBkTLogwsDUz5htP0ydYy0PpLdGeZe1q+4yVUJwxMC
vQqwFDDk4lUvfhq/Rn3RPr8otE8/W9iltihkMF7BngDyWW+mQM4MjGmgfaesR/Kc
9CoIy1zylwD+Q9FcPQFNh0zMcxxtUQ0I4TFsMTaMZ6C2FzNWkuWp5rn2kvL/Io4c
xhiGZA+czOeEZBj9CNA3fWLAzA3R3UFWk66n8de8iWeWmWgBxv4d7LnHL5J4il/u
B/Pm5thHDHTBeSwsf2nAuCady6MXivxZJLSyAodXHDpWLNgBsOXCg7cTasXnCQOL
Oqeavut0qB6HeeaaOM2YhiO/eprE7kfA1UgxyXgysaBw23LiYAbaetKJ39K4A8L6
9mL4NLMc3uEvanz5goIZ
=Mayj
-END PGP SIGNATURE-

Re: CVS commit: src/lib/libc/stdlib

2015-07-19 Thread Joerg Sonnenberger 
On Thu, Jul 16, 2015 at 12:12:27PM +0200, Kamil Rytarowski wrote:
 The C standard permits memcpy(3) to affect errno(2).

More like it hasn't explicitly ruled it out. That might or might not be
seen as an oversight, but pretty much any compiler uses memcpy(3) under
the assumption that it does not. If you really care about this case,
please raise a DR against ISO C and get a clarification of the
intention, before further changes to src.

Joerg