In article 17847.1438021...@splode.eterna.com.au,
matthew green m...@eterna.com.au wrote:
Maxime Villard writes:
Module Name: src
Committed By:maxv
Date:Mon Jul 27 09:24:28 UTC 2015
Modified Files:
src/sys/kern: subr_kmem.c
src/sys/uvm: files.uvm
Removed Files:
src/sys/uvm: uvm_kmguard.c uvm_kmguard.h
Log Message:
Several changes and improvements in KMEM_GUARD:
- merge uvm_kmguard.{c,h} into subr_kmem.c. It is only user there, and
makes it more consistent. Also, it allows us to enable KMEM_GUARD
without enabling DEBUG.
- rename uvm_kmguard_XXX to kmem_guard_XXX, for consistency
- improve kmem_guard_alloc() so that it supports allocations bigger than
PAGE_SIZE
- remove the canary value, and use directly the kmem header as underflow
pattern.
- fix some comments
(The UAF fifo is disabled for the moment; we actually need to register
the va and its size, and add a weight support not to consume too much
memory.)
thanks for extending KMEM_GUARD beyond PAGE_SIZE. this will be
quite helpful, if even now requiring a lot more memory when
using kmguard :)
was this change presented for review anywhere before commit?
While the technical part of this change has been resolved, large
changes like this should be reviewed in tcsh-kern before they are
committed.
christos