Re: CVS commit: src

2015-08-09 Thread Joerg Sonnenberger 
On Tue, Jul 28, 2015 at 08:10:26PM -0400, Christos Zoulas wrote:
 Module Name:  src
 Committed By: christos
 Date: Wed Jul 29 00:10:26 UTC 2015
 
 Modified Files:
   src/include: Makefile
   src/sys/sys: Makefile pool.h types.h
 Added Files:
   src/sys/sys: stdbool.h
 Removed Files:
   src/include: stdbool.h
 
 Log Message:
 move stdbool.h to sys, reuire pool.h to include sys/stdbool.h for bool,
 centralize definitions of bool, true, false, to sys/stdbool.h

Are you quite sure this is not going to create quite a few headaches
with GCC's header handling for builds from pkgsrc etc?

Joerg

Re: CVS commit: src/lib/libc/stdlib

2015-08-09 Thread Joerg Sonnenberger 
On Tue, Jul 28, 2015 at 05:13:34PM +, Kamil Rytarowski wrote:
 Module Name:  src
 Committed By: kamil
 Date: Tue Jul 28 17:13:34 UTC 2015
 
 Modified Files:
   src/lib/libc/stdlib: reallocarr.3 reallocarr.c
 
 Log Message:
 Compatibility fixes in reallocarr(3)

Except it is worse now. There is now an obscure assumption that
CHAR_BITS is 8, spelled via 2 == log_2 CHAR_BITS - 1.

 While there: rename parameter name 'num' to 'number' to be in sync with
 the calloc(3) parameter naming.

This change doesn't even make sense.

Joerg

Re: CVS commit: src/usr.bin/patch

2015-08-09 Thread Joerg Sonnenberger 
On Fri, Jul 24, 2015 at 02:56:44PM -0400, Christos Zoulas wrote:
 Module Name:  src
 Committed By: christos
 Date: Fri Jul 24 18:56:44 UTC 2015
 
 Modified Files:
   src/usr.bin/patch: common.h
 
 Log Message:
 Use absolute paths for RCS commands (Martin Natano)

I'm against this. It doesn't make sense if we ever drop RCS and it
doesn't make sense for the portable version either.

Joerg

Re: CVS commit: src/external/mit/xorg

2015-08-09 Thread Aymeric Vincent 

matthew green m...@eterna.com.au writes:

 don't we also have TOOL_AWK to handle this?  (mind making that change too? :)

Sure, consider it done. :-) Waiting for a release to finish successfully
first.

Regards,
 Aymeric