Re: CVS commit: src/usr.bin/xlint/lint1

[David Holland]

On Wed, Jul 20, 2016 at 02:14:12PM -0400, Christos Zoulas wrote:
 > Modified Files:
 >  src/usr.bin/xlint/lint1: cgram.y
 > 
 > Log Message:
 > accept attributes in param decls

Parsing gcc attributes "correctly" (as in, where gcc accepts them) is
a trainwreck. Do we really want to bother trying?

-- 
David A. Holland
dholl...@netbsd.org

Re: CVS commit: src/sys/arch/x86/x86

[Takashi YAMAMOTO]

On Wed, Jul 20, 2016 at 3:54 AM, Maxime Villard  wrote:

> Module Name:src
> Committed By:   maxv
> Date:   Tue Jul 19 18:54:45 UTC 2016
>
> Modified Files:
> src/sys/arch/x86/x86: pmap.c
>
> Log Message:
> This loop makes no sense at all.
>

- can you provide more meaningful commit message?

- why don't you remove it then?


>
>
> To generate a diff of this commit:
> cvs rdiff -u -r1.211 -r1.212 src/sys/arch/x86/x86/pmap.c
>
> Please note that diffs are not public domain; they are subject to the
> copyright notices on the relevant files.
>
>

re: CVS commit: src/sys/uvm

[matthew green]

"Maxime Villard" writes:
> Module Name:  src
> Committed By: maxv
> Date: Wed Jul 20 12:38:44 UTC 2016
> 
> Modified Files:
>   src/sys/uvm: uvm_extern.h uvm_km.c
> 
> Log Message:
> Introduce uvm_km_protect.

can you bring this up on tech-kern and discuss what it is for?
this commit message is entirely useless today, let alone in the
future when someone tries to understand what is happening here.

changing UVM should always be discussed with UVM maintainers.

thanks.


.mrg.