re: CVS commit: src/sys/miscfs/specfs

[matthew green]

"Paul Goyette" writes:
> Module Name:  src
> Committed By: pgoyette
> Date: Thu Sep  8 00:07:48 UTC 2016
> 
> Modified Files:
>   src/sys/miscfs/specfs: spec_vnops.c
> 
> Log Message:
> if_config processing wants to auto-load modules named with an if_ prefix,
> while specfc wants to auto-load modules without the prefix.  For modules
> which can be loaded both ways (ie, if_tap and if_tun), provide a simple
> conversion table for specfs so it can auto-load the if_ module.
> 
> This table should always be quite small, and the auto-load operation is
> relatively infrequent, so the additional overhead of comparing names should
> be tolerable.

would you mind reverting this and implementing the "dependant"
module model mlelstv proposed?

the above is a hack and doesn't scale or work if a new module
with the same "problem" is introduced, as it requires the base
kernel to be patched, where as a pair of modules can be added
much more easily.

thanks.


.mrg.

Re: CVS commit: src/sys

[Kengo NAKAHARA]

Hi roy@n.o,

On 2016/09/08 0:41, Roy Marples wrote:
> Module Name:  src
> Committed By: roy
> Date: Wed Sep  7 15:41:44 UTC 2016
> 
> Modified Files:
>   src/sys/netinet: ip_input.c
>   src/sys/netinet6: ip6_input.c
> 
> Log Message:
> Disallow input to detached addresses because they are not yet valid.
> 
> 
> To generate a diff of this commit:
> cvs rdiff -u -r1.340 -r1.341 src/sys/netinet/ip_input.c
> cvs rdiff -u -r1.167 -r1.168 src/sys/netinet6/ip6_input.c
> 
> Please note that diffs are not public domain; they are subject to the
> copyright notices on the relevant files.

ATF net/if_pppoe/t_pppoe:pap fails after this commit. I revert this
commit locally, and then the ATF become successful.

Could you check your ATF results?


Thanks,

-- 
//
Internet Initiative Japan Inc.

Device Engineering Section,
IoT Platform Development Department,
Network Division,
Technology Unit

Kengo NAKAHARA