Re: CVS commit: src/sys

[Ryota Ozaki]

On Mon, Sep 12, 2016 at 6:28 PM, Kengo NAKAHARA  wrote:
> Hi,
>
> On 2016/09/12 17:28, Roy Marples wrote:
>> On 09/09/2016 20:08, Martin Husemann wrote:
>>> On Thu, Sep 08, 2016 at 02:19:15PM +0900, Kengo NAKAHARA wrote:

 On 2016/09/08 0:41, Roy Marples wrote:
> Module Name:   src
> Committed By:  roy
> Date:  Wed Sep  7 15:41:44 UTC 2016
>
> Modified Files:
>src/sys/netinet: ip_input.c
>src/sys/netinet6: ip6_input.c
>
> Log Message:
> Disallow input to detached addresses because they are not yet valid.
>
>
> To generate a diff of this commit:
> cvs rdiff -u -r1.340 -r1.341 src/sys/netinet/ip_input.c
> cvs rdiff -u -r1.167 -r1.168 src/sys/netinet6/ip6_input.c
>
> Please note that diffs are not public domain; they are subject to the
> copyright notices on the relevant files.

 ATF net/if_pppoe/t_pppoe:pap fails after this commit. I revert this
 commit locally, and then the ATF become successful.
>>>
>>> I see the failure too, but manually configuring two rump servers in a very
>>> similar setup than the test still works for me - something must be wrong
>>> in the test, but I don't see it right now.
>>
>> martin@ did more testing and discovered that the PPP connection works
>> fine, so something is wrong in the test.
>>
>> I believe that the function wait_for_session_established needs an
>> additional pause to wait for the detached flag to clear.
>> If the interface is marked IFF_UP at this point, it should be possible
>> to add ifconfig -w 5 -W -5 and the test should then succeed. I'm getting
>> symbol errors still trying to run this test so cannot fix it myself
>> right now.
>
> I add ifconfig -w 15 -W 15 in wait_for_session_established(), however
> net/if_pppoe/t_pppoe:pap still fails.
>
> Hmm, does my below modification match your pointing out, doesn't it?

It seems that DAD doesn't run on ifconfig pppoe0 up
and pppoe0 remains as detached.

The following processing is happening:
- ifconfig up calls ioctl(SIOCSIFFLAGS)
  that calls ifioctl_common normally
- ifioctl_common schedules DAD eventually
  but only if IFF_UP & IFF_RUNNING
  (see in_if_link_up)
- However, some interfaces including pppoe set
  IFF_RUNNING *after* calling ifioctl_common
- Such interfaces don't run DAD
  and remain as detached

I don't know how to fix it properly.

  ozaki-r

Re: CVS commit: src/sbin/newfs

[Sevan Janiyan]

On 13/09/2016 00:09, matthew green wrote:
> that never stopped them being referenced before.  infact, the macros
> appear know what they mean because it transforms:
> 
>.Bx 4.3 tahoe .
> 
> into:
> 
>The shells file format appeared in 4.3BSD-Tahoe.
> 
> ie, it capitalises and adds the dash.  i think it matter because there
> was a very long time between each of 4.3, reno, tahoe, 4.4 (closed)
> and 4.4-lite (and lite2).

For memfs support, it was actually covered in the 4.4BSD Release notes.
https://groups.google.com/d/msg/comp.unix.bsd/hZYO7xTDqQ8/NE-S-HWH9-wJ

"We  have also added amemory-based filesystem that runs in pageable
memory, allowing  large temporary filesystems without requiring
dedicated physical memory."

I can't seem to find the 4.3BSD-Reno release notes at the moment, but
the convention is interim releases do not count.
There are examples of that where 4.2BSD is being referenced in inherited
man pages when in-fact the tools actually showed up in 4.1{a,b,c}.



Sevan

re: CVS commit: src/sbin/newfs

[matthew green]

Sevan Janiyan writes:
> On 12/09/2016 22:02, matthew green wrote:
> > wouldn't "09/06/89" put it in 4.3RENO ?  from bsd-family-tree:
> > 
> > 4.3BSD Reno 1990-06-29 [QCU], [DOC]
> > 
> > 
> > .mrg.
> 
> Reno & Tahoe along with 4.1{a,b,c} were interim/beta releases.

that never stopped them being referenced before.  infact, the macros
appear know what they mean because it transforms:

   .Bx 4.3 tahoe .

into:

   The shells file format appeared in 4.3BSD-Tahoe.

ie, it capitalises and adds the dash.  i think it matter because there
was a very long time between each of 4.3, reno, tahoe, 4.4 (closed)
and 4.4-lite (and lite2).


.mrg.

re: CVS commit: src/sbin/newfs

[matthew green]

> Log Message:
> Memory File System support appeared in 4.4BSD, implemented as an extension to
> newfs(8). So while newfs may have appeared in 4.2BSD, MFS support was later.
> https://svnweb.freebsd.org/csrg/sbin/newfs/Makefile?r1=39047=39051
> Adjust HISTORY.
> Bump date.

wouldn't "09/06/89" put it in 4.3RENO ?  from bsd-family-tree:

4.3BSD Reno 1990-06-29 [QCU], [DOC]


.mrg.

Re: CVS commit: src/sys

[Kengo NAKAHARA]

Hi,

On 2016/09/12 17:28, Roy Marples wrote:
> On 09/09/2016 20:08, Martin Husemann wrote:
>> On Thu, Sep 08, 2016 at 02:19:15PM +0900, Kengo NAKAHARA wrote:
>>>
>>> On 2016/09/08 0:41, Roy Marples wrote:
 Module Name:   src
 Committed By:  roy
 Date:  Wed Sep  7 15:41:44 UTC 2016

 Modified Files:
src/sys/netinet: ip_input.c
src/sys/netinet6: ip6_input.c

 Log Message:
 Disallow input to detached addresses because they are not yet valid.


 To generate a diff of this commit:
 cvs rdiff -u -r1.340 -r1.341 src/sys/netinet/ip_input.c
 cvs rdiff -u -r1.167 -r1.168 src/sys/netinet6/ip6_input.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.
>>>
>>> ATF net/if_pppoe/t_pppoe:pap fails after this commit. I revert this
>>> commit locally, and then the ATF become successful.
>>
>> I see the failure too, but manually configuring two rump servers in a very
>> similar setup than the test still works for me - something must be wrong
>> in the test, but I don't see it right now.
> 
> martin@ did more testing and discovered that the PPP connection works
> fine, so something is wrong in the test.
> 
> I believe that the function wait_for_session_established needs an
> additional pause to wait for the detached flag to clear.
> If the interface is marked IFF_UP at this point, it should be possible
> to add ifconfig -w 5 -W -5 and the test should then succeed. I'm getting
> symbol errors still trying to run this test so cannot fix it myself
> right now.

I add ifconfig -w 15 -W 15 in wait_for_session_established(), however
net/if_pppoe/t_pppoe:pap still fails.

Hmm, does my below modification match your pointing out, doesn't it?

--- net/if_pppoe/t_pppoe.orig   2016-09-12 18:16:26.610435947 +0900
+++ net/if_pppoe/t_pppoe2016-09-12 18:30:14.756955057 +0900
@@ -99,6 +99,8 @@
sleep 1
done
 
+   env RUMP_SERVER=$CLIENT rump.ifconfig -w 15 -W 15
+
if [ $dontfail != "dontfail" ]; then
atf_fail "Couldn't connect to the server for $n seconds."
fi


 
Thanks,

-- 
//
Internet Initiative Japan Inc.

Device Engineering Section,
IoT Platform Development Department,
Network Division,
Technology Unit

Kengo NAKAHARA 

Re: CVS commit: src/sys

[Roy Marples]

On 09/09/2016 20:08, Martin Husemann wrote:
> On Thu, Sep 08, 2016 at 02:19:15PM +0900, Kengo NAKAHARA wrote:
>>
>> On 2016/09/08 0:41, Roy Marples wrote:
>>> Module Name:src
>>> Committed By:   roy
>>> Date:   Wed Sep  7 15:41:44 UTC 2016
>>>
>>> Modified Files:
>>> src/sys/netinet: ip_input.c
>>> src/sys/netinet6: ip6_input.c
>>>
>>> Log Message:
>>> Disallow input to detached addresses because they are not yet valid.
>>>
>>>
>>> To generate a diff of this commit:
>>> cvs rdiff -u -r1.340 -r1.341 src/sys/netinet/ip_input.c
>>> cvs rdiff -u -r1.167 -r1.168 src/sys/netinet6/ip6_input.c
>>>
>>> Please note that diffs are not public domain; they are subject to the
>>> copyright notices on the relevant files.
>>
>> ATF net/if_pppoe/t_pppoe:pap fails after this commit. I revert this
>> commit locally, and then the ATF become successful.
> 
> I see the failure too, but manually configuring two rump servers in a very
> similar setup than the test still works for me - something must be wrong
> in the test, but I don't see it right now.

martin@ did more testing and discovered that the PPP connection works
fine, so something is wrong in the test.

I believe that the function wait_for_session_established needs an
additional pause to wait for the detached flag to clear.
If the interface is marked IFF_UP at this point, it should be possible
to add ifconfig -w 5 -W -5 and the test should then succeed. I'm getting
symbol errors still trying to run this test so cannot fix it myself
right now.

Roy