Re: CVS commit: src/lib/libarch/i386

[Maxime Villard]

Le 12/08/2017 à 23:07, matthew green a écrit :

"Maxime Villard" writes:

Module Name:src
Committed By:   maxv
Date:   Sat Aug 12 19:48:28 UTC 2017

Modified Files:
src/lib/libarch/i386: shlib_version

Log Message:
Bump - removal of i386_vm86 and i386_pmc.


i didn't check the build, but this also needs set lists updates
normally.  eg:

base/md.amd64:./usr/lib/i386/libi386.so.1   
base-compat-shlib   compat,pic
base/md.amd64:./usr/lib/i386/libi386.so.1.0 
base-compat-shlib   compat,pic
base/md.i386:./usr/lib/libi386.so.1 base-sys-shlib  
pic
base/md.i386:./usr/lib/libi386.so.1.0   base-sys-shlib  
pic
debug/md.amd64:./usr/libdata/debug/usr/lib/i386/libi386.so.1.0.debug
comp-compat-shlib   compat,pic,debug
debug/md.i386:./usr/libdata/debug/usr/lib/libi386.so.1.0.debug  comp-sys-debug  
pic,debug


Sorry about this. I came back home yesterday just minutes before you sent your
mail, and when I saw it, I just committed the bump without thinking much before
leaving again.

Initially I hesitated about modifying the i386_mtrr API too, hence the delay.

Maxime

re: CVS commit: src

[matthew green]

> > Remember to bump major if you remove a function
> 
> verily, I'm not totally done yet

then please batch your changes all together instead of leaving the
tree in an inconsistent state.  always bump shlib versions when
you change the library.  recall we tend to have multiple autobuild
results every day so every a couple of hours delay is bad.


.mrg.

Re: CVS commit: src

[coypu]

On Sat, Aug 12, 2017 at 07:35:08AM +, Maxime Villard wrote:
> Module Name:  src
> Committed By: maxv
> Date: Sat Aug 12 07:35:08 UTC 2017
> 
> Modified Files:
>   src/distrib/sets/lists/comp: md.amd64 md.i386
>   src/sys/arch/i386/include: Makefile mcontext.h segments.h
> Removed Files:
>   src/sys/arch/i386/include: vm86.h
> 
> Log Message:
> Remove vm86.

Cool.

There is one leftover in lib/libarch/i386/i386_vm86.*
It's including vm86.h

Remember to bump major if you remove a function