Re: CVS commit: src/sys/arch/x86/x86

[Maxime Villard]

Le 07/02/2018 à 23:49, Maya Rashish a écrit :

Module Name:src
Committed By:   maya
Date:   Wed Feb  7 22:49:32 UTC 2018

Modified Files:
src/sys/arch/x86/x86: identcpu.c

Log Message:
stopgap fix: restrict XSAVEOPT to Intel CPUs

The current code causes floating point miscalculations on AMD Ryzen.
PR port-amd64/52966: amd64 FPU handling broken on AMD


To generate a diff of this commit:
cvs rdiff -u -r1.67 -r1.68 src/sys/arch/x86/x86/identcpu.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.


Thanks, mlelstv told me about this a week ago, and I just hadn't gotten
around to fixing it yet.

It would be better to disable XSAVEOPT entirely (including on Intel), until
I add a bunch of KASSERTs to ensure the spec is respected.

Maxime

re: CVS commit: src/lib/libkvm

[matthew green]

matthew green writes:
> "Maxime Villard" writes:
> > Module Name:src
> > Committed By:   maxv
> > Date:   Wed Feb  7 14:03:18 UTC 2018
> > 
> > Modified Files:
> > src/lib/libkvm: kvm.c
> > 
> > Log Message:
> > Keep /dev/ksyms open in _kvm_open(). This way /dev/ksyms can be put into
> > $g_kmem without breaking the tools that need kmem+ksyms.
> > 
> > Discussed on tech-kern@ three weeks ago. The original issue was reported
> > by maya@, the patch was written by Tom Ivar Helbekkmo, ok christos@.
> 
> hmmm, it just occurs to me that this is not safe against me
> re-opening /proc/mypid/N to get another fd on /dev/ksyms as
> a normal user.
> 
> i wonder if this pattern exists elsewhere...

ah, it shouldn't be a problem -- the user/group/mode are
taken from the original file, so whatever /dev/ksyms is.


.mrg.

re: CVS commit: src/lib/libkvm

[matthew green]

"Maxime Villard" writes:
> Module Name:  src
> Committed By: maxv
> Date: Wed Feb  7 14:03:18 UTC 2018
> 
> Modified Files:
>   src/lib/libkvm: kvm.c
> 
> Log Message:
> Keep /dev/ksyms open in _kvm_open(). This way /dev/ksyms can be put into
> $g_kmem without breaking the tools that need kmem+ksyms.
> 
> Discussed on tech-kern@ three weeks ago. The original issue was reported
> by maya@, the patch was written by Tom Ivar Helbekkmo, ok christos@.

hmmm, it just occurs to me that this is not safe against me
re-opening /proc/mypid/N to get another fd on /dev/ksyms as
a normal user.

i wonder if this pattern exists elsewhere...


.mrg.

Re: CVS commit: src/include

[Joerg Sonnenberger]

On Tue, Feb 06, 2018 at 03:21:21PM -0500, Christos Zoulas wrote:
> Module Name:  src
> Committed By: christos
> Date: Tue Feb  6 20:21:21 UTC 2018
> 
> Modified Files:
>   src/include: unistd.h
> 
> Log Message:
> detect duplicate declaration of pthread_atfork() in pthread.h

Is this for some new broken GCC warning?

Joerg

Re: CVS commit: src/share/man/man4

[Kengo NAKAHARA]

Hi,

On 2018/02/07 19:12, m...@netbsd.org wrote:
> Hi!
> 
> Please give credit in the future.
> 
> It can be very important for a new contributor, I used to show my
> friends, "look, I made this change, and it says I did it!" and it was
> very cool.
> 
> Even though they were small contributions, they were my biggest
> contributions.
> 
> (For example:
> Mention jumbo frame support.
> From David H. Gutteridge in PR misc/52890)

Sorry, I update the commit message. And I will be careful in future.


Thanks,

-- 
//
Internet Initiative Japan Inc.

Device Engineering Section,
IoT Platform Development Department,
Network Division,
Technology Unit

Kengo NAKAHARA 

Re: CVS commit: src/share/man/man4

[maya]

Hi!

Please give credit in the future.

It can be very important for a new contributor, I used to show my
friends, "look, I made this change, and it says I did it!" and it was
very cool.

Even though they were small contributions, they were my biggest
contributions.

(For example:
Mention jumbo frame support.
>From David H. Gutteridge in PR misc/52890)

Thanks.