Re: CVS commit: src/sys/kern
Hello, On Sun, 3 Jun 2018 20:52:46 +0200 Pierre Pronchery wrote: > On 03/06/2018 18:12, Michael wrote: > > Hello, > > > > On Sun, 3 Jun 2018 15:26:04 + > > "Jonathan A. Kollasch" wrote: > > > >> Module Name: src > >> Committed By: jakllsch > >> Date: Sun Jun 3 15:26:04 UTC 2018 > >> > >> Modified Files: > >>src/sys/kern: subr_prf.c > >> > >> Log Message: > >> Make identification of accounted aprint_error()s possible by putting a > >> big ugly "autoconfiguration error: " in the log when they occur. > > > > Maybe we can print them in red instead of the normal kernel green. > > Or black on green background? > It would give a bit less of a rainbow effect. > Also, some people are visually impaired (like me). options WS_ERROR_FG options WS_ERROR_BG so everyone can have whatever they want. We have all these different aprint_*() functions, may as well make their output (optionally) distinguishable. have fun Michael
Re: CVS commit: src/sys/kern
On 03/06/2018 18:12, Michael wrote: > Hello, > > On Sun, 3 Jun 2018 15:26:04 + > "Jonathan A. Kollasch" wrote: > >> Module Name: src >> Committed By:jakllsch >> Date:Sun Jun 3 15:26:04 UTC 2018 >> >> Modified Files: >> src/sys/kern: subr_prf.c >> >> Log Message: >> Make identification of accounted aprint_error()s possible by putting a >> big ugly "autoconfiguration error: " in the log when they occur. > > Maybe we can print them in red instead of the normal kernel green. Or black on green background? It would give a bit less of a rainbow effect. Also, some people are visually impaired (like me). HTH, -- khorben
Re: CVS commit: src/sys/kern
Hello, On Sun, 3 Jun 2018 15:26:04 + "Jonathan A. Kollasch" wrote: > Module Name: src > Committed By: jakllsch > Date: Sun Jun 3 15:26:04 UTC 2018 > > Modified Files: > src/sys/kern: subr_prf.c > > Log Message: > Make identification of accounted aprint_error()s possible by putting a > big ugly "autoconfiguration error: " in the log when they occur. Maybe we can print them in red instead of the normal kernel green. have fun Michael
re: CVS commit: src/external/bsd/top/dist
Christos Zoulas writes:
> On Jun 2, 7:36pm, li...@eitanadler.com (Eitan Adler) wrote:
> -- Subject: Re: CVS commit: src/external/bsd/top/dist
>
> | I don't mind reverting this: it came out of a discussion on IRC. That
> | said, perhaps "cd /tmp" would resolve both issues?
>
> This is a 3rd party program that behaves everywhere the same way;
> changing it for NetBSD will just produce unexpected results for
> the user: How will I even know to cd to /tmp to look for the core?
> As I said, if you want it to run from a different directory, wrap
> it in a shell script or use an alias. These user-specific customizations
> don't belong in a general purpose program. It is a slippery slope
> to start making programs behave in random ways just because it is
> convenient for some uses. For example, I've never needed top to
> chdir before it grew a 'machine' subdirectory to fix the mess of
> ifdefs it required to run on multiple OS's. Are you planning to
> change vmstat to do the same? iostat? systat? Why not? These changes
> don't make sense (to me).
yeah - you're right about what we should do here and i'm ok
that the revert happened.
... but we should probably keep that part that removes the
chdir("/tmp") right before calling exit().
.mrg.
re: CVS commit: src/usr.bin/kdump
> > On 2. Jun 2018, at 22:07, matthew green wrote:
> >
> > Module Name:src
> > Committed By: mrg
> > Date: Sat Jun 2 20:07:15 UTC 2018
> >
> > Modified Files:
> > src/usr.bin/kdump: mkioctls
> >
> > Log Message:
> > just include for mkioctls. this works fine for me
> > for several platforms and fixes the clang build.
> >
> >
> > To generate a diff of this commit:
> > cvs rdiff -u -r1.50 -r1.51 src/usr.bin/kdump/mkioctls
>
> This breaks the build:
>
> In file included from /build/devel/src/sys/net/if.h:99:0,
> from kdump-ioctl.c:23:
> /build/devel/src/sys/altq/if_altq.h:48:2: error: unknown type name 'kmutex_t'
> kmutex_t *ifq_lock;
> ^~~~
>
> The real problem seems the sys include search path:
>
> #include <...> search starts here:
> /build/devel/obj/dist.amd64/usr/X11R7/include/libdrm
> /build/devel/obj/dist.amd64/usr/X11R7/include/pixman-1
> /build/devel/obj/dist.amd64/usr/X11R7/include
> /build/devel/src/external/cddl/osnet/sys
> /build/devel/src/external/cddl/osnet/dist/uts/common
> /build/devel/src/usr.bin/ktrace
> /build/devel/src/sys
> /build/devel/obj/dist.amd64/usr/include/gcc-6
> /build/devel/obj/tools.amd64/lib/gcc/x86_64--netbsd/6.4.0/include-fixed
> /build/devel/obj/dist.amd64/usr/include
>
> Most includes come from "cddl/osnet/sys/sys" which looks wrong.
>
> Suppose the search better starts with "-I${NETBSDSRCDIR}/sys" ...
i remain unable to reproduce this on my own system. i guess
either your idea, or, -I${DESTDIR}/usr/include before the cddl
includes, and make them all last.
FWIW, this patch works for me (in that, it doesn't break).
please feel free to commit this or something similar that works
for you, as i'm hesitant to commit something else here without
confirming it helps the problem i don't see.
thanks.
.mrg.
Index: Makefile.ioctl-c
===
RCS file: /cvsroot/src/usr.bin/kdump/Makefile.ioctl-c,v
retrieving revision 1.35
diff -p -u -r1.35 Makefile.ioctl-c
--- Makefile.ioctl-c28 May 2018 21:05:02 - 1.35
+++ Makefile.ioctl-c3 Jun 2018 11:43:19 -
@@ -47,11 +47,6 @@ DPSRCS+= ${PROG}-ioctl.c
CPPFLAGS+= -I${DESTDIR}/usr/X11R7/include/libdrm
CPPFLAGS+= -I${DESTDIR}/usr/X11R7/include/pixman-1
CPPFLAGS+= -I${DESTDIR}/usr/X11R7/include
-.if ${MKDTRACE} != "no"
-CPPFLAGS+= -I${NETBSDSRCDIR}/external/cddl/osnet/sys
-CPPFLAGS+= -I${NETBSDSRCDIR}/external/cddl/osnet/dist/uts/common
-CWARNFLAGS+= -Wno-unknown-pragmas
-.endif
CPPFLAGS+= -D_DEV_IC_BT8XX_H_
CPPFLAGS+= -D_ALTQ_ALTQ_JOBS_H_# redefinition of inline
# De-select one, dup ioctls
@@ -65,4 +60,13 @@ CPPFLAGS+= -D__RADEON_DRM_H__ # Dup ioct
CPPFLAGS+= -D__MACH64_DRM_H__ # Dup ioctls
CPPFLAGS+= -D__MGA_DRM_H__ # Dup ioctls
+# Make sure these are last.
+.if ${MKDTRACE} != "no"
+# We put /usr/include here explicitly to always prefer NetBSD headers.
+CPPFLAGS+= -I${DESTDIR}/usr/include
+CPPFLAGS+= -I${NETBSDSRCDIR}/external/cddl/osnet/sys
+CPPFLAGS+= -I${NETBSDSRCDIR}/external/cddl/osnet/dist/uts/common
+CWARNFLAGS+= -Wno-unknown-pragmas
+.endif
+
${DEPFILES}: .PRECIOUS
Re: CVS commit: src/external/bsd/top/dist
On 03/06/2018 05:10, Christos Zoulas wrote: > On Jun 2, 7:36pm, li...@eitanadler.com (Eitan Adler) wrote: > -- Subject: Re: CVS commit: src/external/bsd/top/dist > > | I don't mind reverting this: it came out of a discussion on IRC. That > | said, perhaps "cd /tmp" would resolve both issues? > > This is a 3rd party program that behaves everywhere the same way; > changing it for NetBSD will just produce unexpected results for > the user: How will I even know to cd to /tmp to look for the core? > As I said, if you want it to run from a different directory, wrap > it in a shell script or use an alias. These user-specific customizations > don't belong in a general purpose program. It is a slippery slope > to start making programs behave in random ways just because it is > convenient for some uses. For example, I've never needed top to > chdir before it grew a 'machine' subdirectory to fix the mess of > ifdefs it required to run on multiple OS's. Are you planning to > change vmstat to do the same? iostat? systat? Why not? These changes > don't make sense (to me). I agree with Christos here. Cheers, -- khorben
Re: CVS commit: src/external/cddl/osnet/sys/sys
Hi, "Chuck Silvers" writes: > Committed By: chs > [...] > Log Message: > tweak the osnet compat headers to allow building on MacOS and Linux hosts. Thanks a lot. The tools build works for me under Linux now. Regards, Aymeric
Re: CVS commit: src/usr.bin/kdump
> On 2. Jun 2018, at 22:07, matthew green wrote:
>
> Module Name: src
> Committed By: mrg
> Date: Sat Jun 2 20:07:15 UTC 2018
>
> Modified Files:
> src/usr.bin/kdump: mkioctls
>
> Log Message:
> just include for mkioctls. this works fine for me
> for several platforms and fixes the clang build.
>
>
> To generate a diff of this commit:
> cvs rdiff -u -r1.50 -r1.51 src/usr.bin/kdump/mkioctls
This breaks the build:
In file included from /build/devel/src/sys/net/if.h:99:0,
from kdump-ioctl.c:23:
/build/devel/src/sys/altq/if_altq.h:48:2: error: unknown type name 'kmutex_t'
kmutex_t *ifq_lock;
^~~~
The real problem seems the sys include search path:
#include <...> search starts here:
/build/devel/obj/dist.amd64/usr/X11R7/include/libdrm
/build/devel/obj/dist.amd64/usr/X11R7/include/pixman-1
/build/devel/obj/dist.amd64/usr/X11R7/include
/build/devel/src/external/cddl/osnet/sys
/build/devel/src/external/cddl/osnet/dist/uts/common
/build/devel/src/usr.bin/ktrace
/build/devel/src/sys
/build/devel/obj/dist.amd64/usr/include/gcc-6
/build/devel/obj/tools.amd64/lib/gcc/x86_64--netbsd/6.4.0/include-fixed
/build/devel/obj/dist.amd64/usr/include
Most includes come from "cddl/osnet/sys/sys" which looks wrong.
Suppose the search better starts with "-I${NETBSDSRCDIR}/sys" ...
--
J. Hannken-Illjes - hann...@eis.cs.tu-bs.de - TU Braunschweig (Germa
