Re: CVS commit: src/sys/arch/aarch64/aarch64
On Jul 18, 12:04am, r...@nerv.org (Ryo Shimizu) wrote: -- Subject: Re: CVS commit: src/sys/arch/aarch64/aarch64 | kern_vtopdiff has already been fixed. (thanks christos@) | u_int uboot_args[4] (in various file :-P) has same problem. | Should I fix it? [Y/y] I just did. christos
Re: CVS commit: src/sys/arch/aarch64/aarch64
On Jul 18, 12:57am, r...@nerv.org (Ryo Shimizu) wrote: -- Subject: Re: CVS commit: src/sys/arch/aarch64/aarch64 | | >On Jul 18, 12:04am, r...@nerv.org (Ryo Shimizu) wrote: | >-- Subject: Re: CVS commit: src/sys/arch/aarch64/aarch64 | > | >| kern_vtopdiff has already been fixed. (thanks christos@) | >| u_int uboot_args[4] (in various file :-P) has same problem. | >| Should I fix it? [Y/y] | > | >Please do! Does the gcc kernel boot after all the changes? | | Yes. Now the kernel (GENERIC64 and RPI64) compiled by aarch64-gcc has been | booted fine. Thank you for everything! Thank you! | >Also I think that the '#define {fp,lr}', should probably go to the asm.h | >file, instead of putting it on each .S file? | | I see, you're right. | Apart from that, I wonder why gcc/gas cannot handle the symbols of fp and lr... Perhaps because our binutils is ancient. But moving to 2.30 has other problems that I need to resolve first... So let's do it for now. Best, christos
Re: CVS commit: src/sys/arch/aarch64/aarch64
>On Jul 18, 12:04am, r...@nerv.org (Ryo Shimizu) wrote: >-- Subject: Re: CVS commit: src/sys/arch/aarch64/aarch64 > >| kern_vtopdiff has already been fixed. (thanks christos@) >| u_int uboot_args[4] (in various file :-P) has same problem. >| Should I fix it? [Y/y] > >Please do! Does the gcc kernel boot after all the changes? Yes. Now the kernel (GENERIC64 and RPI64) compiled by aarch64-gcc has been booted fine. Thank you for everything! >Also I think that the '#define {fp,lr}', should probably go to the asm.h file, >instead of putting it on each .S file? I see, you're right. Apart from that, I wonder why gcc/gas cannot handle the symbols of fp and lr... -- ryo shimizu
Re: CVS commit: src/sys/arch/aarch64/aarch64
>On Tue, Jul 17, 2018 at 11:12:41AM +, Ryo Shimizu wrote: >> Module Name: src >> Committed By:ryo >> Date:Tue Jul 17 11:12:41 UTC 2018 >> >> Modified Files: >> src/sys/arch/aarch64/aarch64: aarch64_machdep.c >> >> Log Message: >> kern_vtopdiff is stored in fdt_start.S. that is before cleaning bss. >> decl "kern_vtopdiff = 0" for keep in .data section. > >That sounds really fragile. Put it explicitly into .data via section >attribute? kern_vtopdiff has already been fixed. (thanks christos@) u_int uboot_args[4] (in various file :-P) has same problem. Should I fix it? [Y/y] -- ryo shimizu
Re: CVS commit: src/sys/arch/aarch64/include
In article <2018071711.5b119f...@cvs.netbsd.org>, Joerg Sonnenberger wrote: >-=-=-=-=-=- > >Module Name: src >Committed By: joerg >Date: Tue Jul 17 11:55:55 UTC 2018 > >Modified Files: > src/sys/arch/aarch64/include: types.h > >Log Message: >Be consistent and explicitly size register32_t too. The reason I did not do that (I don't disagree with the change though) is that in reg.h they are declared as unsigned int, not __uint32_t. christos
Re: CVS commit: src/sys/arch/aarch64/aarch64
On Tue, Jul 17, 2018 at 11:12:41AM +, Ryo Shimizu wrote: > Module Name: src > Committed By: ryo > Date: Tue Jul 17 11:12:41 UTC 2018 > > Modified Files: > src/sys/arch/aarch64/aarch64: aarch64_machdep.c > > Log Message: > kern_vtopdiff is stored in fdt_start.S. that is before cleaning bss. > decl "kern_vtopdiff = 0" for keep in .data section. That sounds really fragile. Put it explicitly into .data via section attribute? Joerg
Re: CVS commit: src/sys/arch/arm/arm32
On Tue, Jul 17, 2018 at 05:29:07AM +, Martin Husemann wrote: > Module Name: src > Committed By: martin > Date: Tue Jul 17 05:29:07 UTC 2018 > > Modified Files: > src/sys/arch/arm/arm32: bus_dma.c > > Log Message: > Revert previous and cast to u_quad_t instead (t is for ptrdiff_t and off_t > does not match that on all arm) Please do not use *quad_t. Joerg