Re: CVS commit: src/usr.sbin/tprof

2018-07-18 Thread Maxime Villard

Le 18/07/2018 à 19:35, Alexander Nasonov a écrit :

Thomas Klausner wrote:

Module Name:src
Committed By:   wiz
Date:   Wed Jul 18 16:50:05 UTC 2018

Modified Files:
src/usr.sbin/tprof: tprof.8 tprof.c

Log Message:
Various improvements to man page. Sync usage.



Does tprof work on amd64? When I tried it a couple of days ago, tprof
complained about missing /dev/tprof. I recompiled the kernel with

options GPROF
pseudo-device tprof

then tried creating the device with MAKEDEV. It didn't know about
tprof and I had to dig a major number in the code to create it manually.

With /dev/tproj available, the tool complained about unsupported cpu.
I'm on haswell notebook.

It'd be nice to mention /dev/tprof in the man page and list common
errors.


Without recompiling the kernel (which is how I use it)

mknod /dev/tprof c 191 0
modload /usr/src/sys/modules/tprof/./tprof.kmod
modload /usr/src/sys/modules/tprof_pmi/./tprof_pmi.kmod

You probably forgot to modload tprof_pmi, this provides the Intel backend,
and you should have at least the "Intel Architectural Version 1" events. It
shouldn't be complicated to add Haswell by the way.

If you're using amd you need to modload tprof_amdpmi

I know it's not clear, I intended to rename the modules and improve the man


Re: CVS commit: src/usr.sbin/tprof

2018-07-18 Thread Alexander Nasonov
Thomas Klausner wrote:
> Module Name:  src
> Committed By: wiz
> Date: Wed Jul 18 16:50:05 UTC 2018
> 
> Modified Files:
>   src/usr.sbin/tprof: tprof.8 tprof.c
> 
> Log Message:
> Various improvements to man page. Sync usage.
> 

Does tprof work on amd64? When I tried it a couple of days ago, tprof
complained about missing /dev/tprof. I recompiled the kernel with

options GPROF
pseudo-device tprof

then tried creating the device with MAKEDEV. It didn't know about
tprof and I had to dig a major number in the code to create it manually.

With /dev/tproj available, the tool complained about unsupported cpu.
I'm on haswell notebook.

It'd be nice to mention /dev/tprof in the man page and list common
errors.

Alex