re: CVS commit: src/external/gpl3/gcc/lib

2019-02-08 Thread matthew green
> UBSan can be combined with ASan and TSan.
> 
> The way to go is to link UBSan into ASan/TSan/etc.
> 
> I'm doing this in LLVM ones here:
> http://netbsd.org/~kamil/llvm/llvm-sanitizers-patch1.txt
> 
> Additionally ASan should link LSan code.
> 
> We apparently want more tests in ATF verifying *San + UBSan used
> concurrently.

the code in GCC 7 explicitly sets the CAN_SANITIZE_UB how
i've done it in our reach over makefiles.

i'm at first only interested in making things work as they
are expected to upstream (which in this case, is gcc, not
their upstream :-).

you or someone else are welcome to advance this state again,
but i'm unlikely to look at it.

thanks.


.mrg.


Re: CVS commit: src/external/gpl3/gcc/lib

2019-02-08 Thread Kamil Rytarowski
On 08.02.2019 23:06, matthew green wrote:
> Module Name:  src
> Committed By: mrg
> Date: Fri Feb  8 22:06:12 UTC 2019
> 
> Modified Files:
>   src/external/gpl3/gcc/lib/libasan: Makefile
>   src/external/gpl3/gcc/lib/libtsan: Makefile
>   src/external/gpl3/gcc/lib/libubsan: Makefile
> 
> Log Message:
> define CAN_SANITIZE_UB properly:  libasan and libtsan need to not
> have it set, libubsan needs to have it set.
> 
> fixes almost all the new atf failures from GCC 7 switch.
> 
> 

UBSan can be combined with ASan and TSan.

The way to go is to link UBSan into ASan/TSan/etc.

I'm doing this in LLVM ones here:
http://netbsd.org/~kamil/llvm/llvm-sanitizers-patch1.txt

Additionally ASan should link LSan code.

We apparently want more tests in ATF verifying *San + UBSan used
concurrently.



signature.asc
Description: OpenPGP digital signature


Re: CVS commit: src/etc

2019-02-08 Thread Pierre Pronchery
On 14/01/2019 12:27, m...@netbsd.org wrote:
> [...]
> This does give the ability to configure wifi with a GUI w/o root or
> something akin to polkit, via some pkgsrc packages (There's wpa_gui, for
> example, it's a QT5 thing. I imagine writing other things is not much
> harder)

Yes, that's also what x11/deforaos-panel uses to configure wireless.

> I just figured this change might be controversial so we need to be
> honest about it happening.

The change Roy made is something I also perform systematically on any
system I install and expect to connect to a wireless networks. It is
harmless when wpa_supplicant(8) is not running.

I agree that a dedicated group to allow network configuration would be
nice. However users in the "wheel" group are usually expected to be
allowed to su(1) anyway, and I think the balance is already very good
with this group to perform the corresponding privileged operations
without prompting for a password nor exposing too much.

Cheers,
-- 
khorben


Re: CVS commit: src/sys/dev/usb

2019-02-08 Thread sc dying
On 2019/01/31 05:51, Rin Okuyama wrote:
> By the way, I find that the system hangs silently by
> "ifconfig mueN down" or detaching LAN7500 from USB port when
> multiple outstanding requests are enabled. This does not occur
> when MUE_TX_LIST_CNT = MUE_RX_LIST_CNT = 1. Do you have any ideas
> to fix it?

My axen dongle locks up if AXEN_RX_LIST_CNT > 1
when ifconfig down on amd64 8.99.34.

db{0}> bt
breakpoint() at netbsd:breakpoint+0x5
comintr() at netbsd:comintr+0x861
Xhandle_ioapic_edge4() at netbsd:Xhandle_ioapic_edge4+0x66
--- interrupt ---
xhci_device_bulk_abort() at netbsd:xhci_device_bulk_abort+0x1c
usbd_ar_pipe() at netbsd:usbd_ar_pipe+0x1e9
usbd_abort_pipe() at netbsd:usbd_abort_pipe+0x27
axen_stop() at netbsd:axen_stop+0xc4
axen_ioctl() at netbsd:axen_ioctl+0x1d9
doifioctl() at netbsd:doifioctl+0xa99
sys_ioctl() at netbsd:sys_ioctl+0x11c
syscall() at netbsd:syscall+0xb4
--- syscall (number 54) ---
732731d1a88a:

Looks like kernel goes infinite loop in usbd_ar_pipe by some reason.
It tries to abort NOT_STARTED xfers.


re: CVS commit: src/usr.sbin/memswitch

2019-02-08 Thread matthew green
"Tetsuya Isaki" writes:
> Module Name:  src
> Committed By: isaki
> Date: Fri Feb  8 08:55:35 UTC 2019
> 
> Modified Files:
>   src/usr.sbin/memswitch: Makefile memswitch.c
> 
> Log Message:
> Rewrite modify_single() to make compilable on gcc7.

thanks!


.mrg.