Re: CVS commit: src/sys/dev/usb

2020-03-17 Thread Robert Elz
Date:Tue, 17 Mar 2020 22:58:24 -0400
From:"Christos Zoulas" 
Message-ID:  <20200318025824.93b28f...@cvs.netbsd.org>

  | Log Message:
  | define un (pointed out by kre@)

The reason I didn't suggest that change, is that now un is unused
when USB_DEBUG is not defined.   At the very least it would need a
__debugused or whatever that #define for the relevant attribute is.

But for just a single use, it seemed simpler just to use the value
used to init the var that is (now) only used the once.

kre



Re: CVS commit: src/sys/arch/x86/x86

2020-03-17 Thread Andrew Doran
On Tue, Mar 17, 2020 at 10:38:14PM +, Andrew Doran wrote:

> Log Message:
> - Change some expensive checks DEBUG -> DIAGNOSTIC.

That was meant to be the other way around, oops.

Andrew


Re: CVS commit: src/sys/arch/evbarm/conf

2020-03-17 Thread Jonathan A. Kollasch
On Mon, Mar 16, 2020 at 08:17:58AM +, Tohru Nishimura wrote:
> Module Name:  src
> Committed By: nisimura
> Date: Mon Mar 16 08:17:58 UTC 2020
> 
> Modified Files:
>   src/sys/arch/evbarm/conf: GENERIC64 files.generic64
> 
> Log Message:
> include files.sociox for generic64
> 
> 
> To generate a diff of this commit:
> cvs rdiff -u -r1.140 -r1.141 src/sys/arch/evbarm/conf/GENERIC64
> cvs rdiff -u -r1.15 -r1.16 src/sys/arch/evbarm/conf/files.generic64
> 
> Please note that diffs are not public domain; they are subject to the
> copyright notices on the relevant files.
> 


This (and the related changes) breaks the GENERIC64 build:

nbmake: nbmake: don't know how to make 
[...]/src/sys/arch/arm/sociox/sni_emmc.c. Stop



Re: CVS commit: src/share/man/man4

2020-03-17 Thread Tetsuya Isaki
At Tue, 17 Mar 2020 10:50:59 +,
Nia Alarie wrote:
> Module Name:  src
> Committed By: nia
> Date: Tue Mar 17 10:50:59 UTC 2020
> 
> Modified Files:
>   src/share/man/man4: audio.4
> 
> Log Message:
> audio.4: 1-12 channels are only universally supported for playback.
> 
> When a mono recording device is set to use 1 channel, the kernel will
> correct the number of channels back down to 1. This information can be
> obtained with AUDIO_GETINFO...

Please revert and send a bug report if so.
---
Tetsuya Isaki