re: CVS commit: src/sys/arch/x86/x86
"Jaromir Dolecek" writes: > Module Name: src > Committed By: jdolecek > Date: Wed Jun 24 22:28:08 UTC 2020 > > Modified Files: > src/sys/arch/x86/x86: multiboot2.c > > Log Message: > don't try allocating 16KB of scratch space on stack > > it's too early for kmem_alloc(), so use static variable in BSS; it's used > post reloc, so don't need to use the RELOC() macros > > XXX compile-tested only on i386 this one is quite a lot of lost wasted space. can you find a way to reuse these pages? or use the x86-specific ways to get early memory... thanks. .mrg.
re: CVS commit: src/sys/dev/ic
"Jaromir Dolecek" writes: > Module Name: src > Committed By: jdolecek > Date: Wed Jun 24 19:55:25 UTC 2020 > > Modified Files: > src/sys/dev/ic: ibm561.c > > Log Message: > avoid allocating almost 5k struct ibm561data on stack in ibm561_cninit(); > it's too early for kmem_alloc(), so use static variable in BSS this seems particularly wasteful for a driver that won't be useful for most systems. seems like a candidate for allow-listing instead, and as it seems to only be relevant for alpha systems, that have a fairly large stack (16K), and this will be called with a fairly short call stack. .mrg.
Re: CVS commit: src/sys/arch/x86/x86
On Wed, Jun 24, 2020 at 10:28:08PM +, Jaromir Dolecek wrote: > Module Name: src > Committed By: jdolecek > Date: Wed Jun 24 22:28:08 UTC 2020 > > Modified Files: > src/sys/arch/x86/x86: multiboot2.c > > Log Message: > don't try allocating 16KB of scratch space on stack > > it's too early for kmem_alloc(), so use static variable in BSS; it's used > post reloc, so don't need to use the RELOC() macros Why? This is the initial early stack, not the normal LWP stack. Joerg
Re: CVS commit: src/tests/usr.sbin
On Wed, Jun 24, 2020 at 03:05:45PM +, Martin Husemann wrote: > Modified Files: > src/tests/usr.sbin/stdethers: Makefile > src/tests/usr.sbin/stdhosts: Makefile > > Log Message: > Add input files Ups. I try to be more careful, now that I again remember the nitty-gritties. - Jukka
Re: CVS commit: src/sys/arch/xen/xen
> Module Name:src > Committed By: jdolecek > Date: Fri Apr 10 18:03:06 UTC 2020 > > Modified Files: > src/sys/arch/xen/xen: if_xennet_xenbus.c > > Log Message: > convert to bus_dma(9), remove now not necessary XENPVHVM redefines > [...] > + KASSERT(req->rxreq_gntref = GRANT_INVALID_REF); I don't think this does quite what you meant it to do! I can fix it by adding the missing `=', but it may cause the kassert to fire because I don't see anywhere in xennet_rx_free_req that sets it to GRANT_INVALID_REF and I don't know the surrounding logic well enough to be confident that just changing it there is correct.
re: CVS commit: src/external/gpl3/gcc/usr.bin/host-libcpp
> Modified Files: > src/external/gpl3/gcc/usr.bin/host-libcpp: Makefile > > Log Message: > PR bin/55411 (Akihiko HAYASHI) > > Remove stray ``&&'' introduced in the previous revision, so that > host tools are correctly passed to configure script. > > No similar problem for gcc.old. No release branches are affected. thanks!
