re: CVS commit: src/share/mk
Joerg Sonnenberger writes: > On Mon, Jul 13, 2020 at 07:22:51AM +, matthew green wrote: > > Module Name:src > > Committed By: mrg > > Date: Mon Jul 13 07:22:51 UTC 2020 > > > > Modified Files: > > src/share/mk: bsd.README > > > > Log Message: > > MKLLVMRT is automatically enabled on x86 and arm64, not mesa18+. > > It is both. we only use mesa20 in xsrc now so there's no "choice" about mesa here. just haven't deleted mesa.old yet.. .mrg.
Re: CVS commit: src/share/mk
On Mon, Jul 13, 2020 at 07:22:51AM +, matthew green wrote: > Module Name: src > Committed By: mrg > Date: Mon Jul 13 07:22:51 UTC 2020 > > Modified Files: > src/share/mk: bsd.README > > Log Message: > MKLLVMRT is automatically enabled on x86 and arm64, not mesa18+. It is both. Joerg
Re: CVS commit: src/libexec/httpd
On Mon, Jul 13, 2020 at 07:15:45PM +1000, matthew green wrote: > i'm not sure i agree about 500 -> abusive behaviour. that's > when there's some _internal_ error and could just as easily > be caused by a human or code error on the server side. > > i don't know blocklist well enough to suggestion what we > should do here, but this feels wrong to me. Sure, though I think there are no clear definitions here. For 401, on the other hand, blocklistd(8) can be useful, given that bruteforcing passwords of embedded devices is supposedly a common scenario. - Jukka
re: CVS commit: src/libexec/httpd
thanks for this. please cc me directly for bozohttpd changes, i have a couple review comments :-) > Committed By: jruoho > Date: Sat Jul 11 08:10:52 UTC 2020 > > Modified Files: > src/libexec/httpd: Makefile auth-bozo.c bozohttpd.8 bozohttpd.c > bozohttpd.h > > Log Message: > Add blocklistd(8) support. > > > To generate a diff of this commit: > cvs rdiff -u -r1.28 -r1.29 src/libexec/httpd/Makefile > cvs rdiff -u -r1.24 -r1.25 src/libexec/httpd/auth-bozo.c > cvs rdiff -u -r1.80 -r1.81 src/libexec/httpd/bozohttpd.8 > cvs rdiff -u -r1.115 -r1.116 src/libexec/httpd/bozohttpd.c > cvs rdiff -u -r1.61 -r1.62 src/libexec/httpd/bozohttpd.h please add -DNO_BLOCKLIST_SUPPORT to Makefile.boot. i'm not sure i agree about 500 -> abusive behaviour. that's when there's some _internal_ error and could just as easily be caused by a human or code error on the server side. i don't know blocklist well enough to suggestion what we should do here, but this feels wrong to me. thanks again. .mrg.
re: [mii locking] Re: CVS commit: src/sys
> Since this change if_udav.c doesn't work. Simply plugging a USB-to-ethernet > device triggers a page fault on mutex_enter in udav_attach. > > Quickly looking at the code: > > 240 usbnet_lock_core(un); > 241 usbnet_busy(un); > 242 > 243 ///* reset the adapter */ > 244 //udav_reset(un); > 245 > 246 usbnet_attach(un, "udavdet"); > > usbnet_lock_core uses un_pri, but un_pri is initialized only in > usbnet_attach. can you move the lock_core/busy calls after attach, and see if that works? i'm pretty sure that's OK. this appears to be the only driver with this bug from my quick scan of them. thanks! .mrg.