Re: CVS commit: src/sys/arch
On 10/17/15 8:30 AM, Manuel Bouyer wrote:
Module Name:src
Committed By: bouyer
Date: Sat Oct 17 15:30:14 UTC 2015
Modified Files:
src/sys/arch/arm/allwinner: awin_board.c awin_reg.h awin_var.h
src/sys/arch/evbarm/awin: awin_machdep.c
src/sys/arch/evbarm/conf: BPI CUBIEBOARD
Log Message:
Implement CPU frequency switching for A20.
This requires adjusting the CPU voltage, so enable the axp20x driver for
A20 boards.
In evbarm/awin/awin_machdep.c, the DCDC powering up the CPU cores needs to
be defined for each board. The board machine-dependant code (at this time,
only awin_machdep.c) has to provide a awin_set_mpu_volt() function
which calls the right PMU driver to change the CPU core voltage.
The CPU frequency/voltage table in awin_board.c comes from various
sources: linux kernel, device tree and fex scripts, and experiments on
olimex lime2 and cubieboard 2.
The following sysctls are provided (compatible with estd):
machdep.frequency.min,machdep.frequency.max: writable lower and upper
bounds of the useable frequencies. Affects machdep.frequency.available.
Lower bound defaults to 700Mhz, as does linux.
Upper bound defaults to 960Mhz, which is the boot frequency
on the boards I tested. There is a 1008Mhz entry available,
but requires an out of spec CPU voltage (more than 1.4V) so it's
not available by default.
machdep.frequency.available: list of available frequencies. This is
the CPU frequency/voltage table, bound by machdep.frequency.{min,max}.
machdep.frequency.current: current CPU speed. Write a new value to change
the CPU speed, only values from machdep.frequency.available are
accepted.
You broke kernel compiles for some of the other allwinner kernels with
this commit; ALLWINNER_A80, for example:
awin_machdep.o: In function `awin_set_mpu_volt':
awin_machdep.c:(.text+0x870): undefined reference to `axp20x_set_dcdc'
It's not clear to me whether the A80 has the axp20x device, but not
having it in the kernel config has meant no arm builds for a few days...
Can you fix this, please?
Thanks,
+j
Re: CVS commit: src/sys/dev/sysmon
On 4/25/15 3:46 PM, Paul Goyette wrote: Module Name:src Committed By: pgoyette Date: Sat Apr 25 22:46:31 UTC 2015 + if (pmf_device_register(sysmon_dev, NULL, NULL)) + aprintf_error(%s: failed to register with pmf\n, I think you mean aprint_error. This doesn't link. +j
Re: CVS commit: src/sys/dev/mii
On 11/9/14 9:54 AM, NONAKA Kimihiro wrote: Module Name:src Committed By: nonaka Date: Sun Nov 9 17:54:02 UTC 2014 Modified Files: src/sys/dev/mii: miidevs_data.h Log Message: regen To generate a diff of this commit: cvs rdiff -u -r1.112 -r1.113 src/sys/dev/mii/miidevs_data.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. I think you forgot to commit the regen of miidevs.h - builds are breaking. I will get to it in a few minutes if you don't beat me to it. +j
Re: CVS commit: src/sys/conf
On 8/24/14 10:54 AM, Joerg Sonnenberger wrote: On Sun, Aug 24, 2014 at 04:42:46PM +, Matt Thomas wrote: Module Name:src Committed By: matt Date: Sun Aug 24 16:42:46 UTC 2014 Modified Files: src/sys/conf: files Log Message: Add entry for kern/kern_ksyms_buf.c This is wrong, the file is explicitly compiled as part of the kernel linking step and must *not* appear separately on the object list. Joerg ...except that, without this, many arm kernel builds (BEAGLEBONE, MIRABOX, probably others) fail with: kern_ksyms.o: In function `ksyms_init': /home/riz/src/sys/kern/kern_ksyms.c:224: undefined reference to `db_symtab' /home/riz/src/sys/kern/kern_ksyms.c:224: undefined reference to `db_symtab' /home/riz/src/sys/kern/kern_ksyms.c:225: undefined reference to `db_symtabsize' /home/riz/src/sys/kern/kern_ksyms.c:225: undefined reference to `db_symtabsize'
Re: CVS commit: src
This broke a lot of builds. I've fixed some of the arm/mips ones, but there's still a bunch failing because of no machine/pci_machdep.h . The timing of these failures is really, really annoying, as I'm hoping to branch within 24h. (heck, I would have liked to have done it already). Fiddling with arch-dependent setlists is not what I had in mind for today; please either fix it quickly or revert. Thanks, +j On 8/9/14 5:34 AM, Christoph Badura wrote: Module Name:src Committed By: bad Date: Sat Aug 9 12:34:05 UTC 2014 Modified Files: src/distrib/sets/lists/modules: ad.arm ad.mips md.alpha md.amd64 md.hppa md.i386 md.ia64 md.sparc md.sparc64 src/sys/modules: Makefile Log Message: Build ubsec(4) as a module on all arches where it was obivous how to do so. That excludes powerpc because evppc OEA is missing definitions for PPC_INTR_IMPL and PPC_PCI_MACHDEP_IMPL. Adjust set lists. Compile tested for most arches only. To generate a diff of this commit: cvs rdiff -u -r1.2 -r1.3 src/distrib/sets/lists/modules/ad.arm \ src/distrib/sets/lists/modules/md.sparc64 cvs rdiff -u -r1.1 -r1.2 src/distrib/sets/lists/modules/ad.mips \ src/distrib/sets/lists/modules/md.alpha \ src/distrib/sets/lists/modules/md.hppa \ src/distrib/sets/lists/modules/md.ia64 cvs rdiff -u -r1.38 -r1.39 src/distrib/sets/lists/modules/md.amd64 cvs rdiff -u -r1.43 -r1.44 src/distrib/sets/lists/modules/md.i386 cvs rdiff -u -r1.3 -r1.4 src/distrib/sets/lists/modules/md.sparc cvs rdiff -u -r1.136 -r1.137 src/sys/modules/Makefile Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. Modified files: Index: src/distrib/sets/lists/modules/ad.arm diff -u src/distrib/sets/lists/modules/ad.arm:1.2 src/distrib/sets/lists/modules/ad.arm:1.3 --- src/distrib/sets/lists/modules/ad.arm:1.2 Sun Aug 11 22:29:03 2013 +++ src/distrib/sets/lists/modules/ad.arm Sat Aug 9 12:34:05 2014 @@ -1,4 +1,6 @@ -# $NetBSD: ad.arm,v 1.2 2013/08/11 22:29:03 joerg Exp $ +# $NetBSD: ad.arm,v 1.3 2014/08/09 12:34:05 bad Exp $ ./@MODULEDIR@/exec_elf32 base-kernel-modules kmod ./@MODULEDIR@/exec_elf32/exec_elf32.kmod base-kernel-modules kmod +./@MODULEDIR@/ubsecbase-kernel-modules kmod +./@MODULEDIR@/ubsec/ubsec.kmod base-kernel-modules kmod Index: src/distrib/sets/lists/modules/md.sparc64 diff -u src/distrib/sets/lists/modules/md.sparc64:1.2 src/distrib/sets/lists/modules/md.sparc64:1.3 --- src/distrib/sets/lists/modules/md.sparc64:1.2 Thu Aug 11 12:03:58 2011 +++ src/distrib/sets/lists/modules/md.sparc64 Sat Aug 9 12:34:05 2014 @@ -1,7 +1,9 @@ -# $NetBSD: md.sparc64,v 1.2 2011/08/11 12:03:58 mbalmer Exp $ +# $NetBSD: md.sparc64,v 1.3 2014/08/09 12:34:05 bad Exp $ ./@MODULEDIR@/exec_elf32 base-kernel-modules kmod ./@MODULEDIR@/exec_elf32/exec_elf32.kmod base-kernel-modules kmod ./@MODULEDIR@/exec_elf64 base-kernel-modules kmod ./@MODULEDIR@/exec_elf64/exec_elf64.kmod base-kernel-modules kmod ./@MODULEDIR@/pwdog base-kernel-modules kmod ./@MODULEDIR@/pwdog/pwdog.kmodbase-kernel-modules kmod +./@MODULEDIR@/ubsecbase-kernel-modules kmod +./@MODULEDIR@/ubsec/ubsec.kmod base-kernel-modules kmod Index: src/distrib/sets/lists/modules/ad.mips diff -u src/distrib/sets/lists/modules/ad.mips:1.1 src/distrib/sets/lists/modules/ad.mips:1.2 --- src/distrib/sets/lists/modules/ad.mips:1.1 Tue Apr 30 23:41:24 2013 +++ src/distrib/sets/lists/modules/ad.mips Sat Aug 9 12:34:05 2014 @@ -1,3 +1,5 @@ -# $NetBSD: ad.mips,v 1.1 2013/04/30 23:41:24 matt Exp $ +# $NetBSD: ad.mips,v 1.2 2014/08/09 12:34:05 bad Exp $ ./@MODULEDIR@/exec_elf32 base-kernel-modules kmod ./@MODULEDIR@/exec_elf32/exec_elf32.kmod base-kernel-modules kmod +./@MODULEDIR@/ubsecbase-kernel-modules kmod +./@MODULEDIR@/ubsec/ubsec.kmod base-kernel-modules kmod Index: src/distrib/sets/lists/modules/md.alpha diff -u src/distrib/sets/lists/modules/md.alpha:1.1 src/distrib/sets/lists/modules/md.alpha:1.2 --- src/distrib/sets/lists/modules/md.alpha:1.1 Mon Sep 7 02:27:29 2009 +++ src/distrib/sets/lists/modules/md.alpha Sat Aug 9 12:34:05 2014 @@ -1,3 +1,5 @@ -# $NetBSD: md.alpha,v 1.1 2009/09/07 02:27:29 jnemeth Exp $ +# $NetBSD: md.alpha,v 1.2 2014/08/09 12:34:05 bad Exp $ ./@MODULEDIR@/exec_elf64 base-kernel-modules kmod ./@MODULEDIR@/exec_elf64/exec_elf64.kmod base-kernel-modules kmod +./@MODULEDIR@/ubsecbase-kernel-modules kmod +./@MODULEDIR@/ubsec/ubsec.kmod base-kernel-modules kmod Index: src/distrib/sets/lists/modules/md.hppa diff -u
Re: CVS commit: src/sys/arch
Manuel-
I think these changes (or one of the changes you've committed recently)
broke building the BEAGLEBOARDXM kernel:
--- beagle_machdep.o ---
/home/riz/src/sys/arch/evbarm/beagle/beagle_machdep.c: In function
'beagle_device_register':
/home/riz/src/sys/arch/evbarm/beagle/beagle_machdep.c:1115:3: error:
'pmic_dev' undeclared (first use in this function)
pmic_dev = self;
^
/home/riz/src/sys/arch/evbarm/beagle/beagle_machdep.c:1115:3: note: each
undeclared identifier is reported only once for each function it appears in
/home/riz/src/sys/arch/evbarm/beagle/beagle_machdep.c: At top level:
/home/riz/src/sys/arch/evbarm/beagle/beagle_machdep.c:1120:1: error: no
previous prototype for 'set_mpu_volt' [-Werror=missing-prototypes]
set_mpu_volt(int mvolt)
^
/home/riz/src/sys/arch/evbarm/beagle/beagle_machdep.c: In function
'set_mpu_volt':
/home/riz/src/sys/arch/evbarm/beagle/beagle_machdep.c:1122:6: error:
'pmic_dev' undeclared (first use in this function)
if (pmic_dev == NULL)
^
/home/riz/src/sys/arch/evbarm/beagle/beagle_machdep.c:1126:2: error:
implicit declaration of function 'tps65217pmic_set_volt'
[-Werror=implicit-function-declaration]
return tps65217pmic_set_volt(pmic_dev, DCDC2, mvolt);
^
On 7/20/14, 4:08 PM, Manuel Bouyer wrote:
Module Name:src
Committed By: bouyer
Date: Sun Jul 20 23:08:43 UTC 2014
Modified Files:
src/sys/arch/arm/omap: am335x_prcm.c am335x_prcm.h omap2_reg.h
src/sys/arch/evbarm/beagle: beagle_machdep.c
Log Message:
am335x: expect the board code to provide a set_mpu_volt() function,
to change the MPU code voltage. When changing MPU frequency also request
a voltage change. provide frequency/voltage tables for the blank revision
and de A revision, based on documents from www.ti.com (this means
it's not possible anymore to request a beaglebone white to run at 1Ghz,
but this was not working anyway).
beagle_machdep.c: callback to the tps65217pmic to change the MPU voltage.
Tested on beaglebone, from 275 to 720Mhz, and on beaglebone black from
300 to 1000Mhz.
To generate a diff of this commit:
cvs rdiff -u -r1.6 -r1.7 src/sys/arch/arm/omap/am335x_prcm.c
cvs rdiff -u -r1.7 -r1.8 src/sys/arch/arm/omap/am335x_prcm.h
cvs rdiff -u -r1.27 -r1.28 src/sys/arch/arm/omap/omap2_reg.h
cvs rdiff -u -r1.58 -r1.59 src/sys/arch/evbarm/beagle/beagle_machdep.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/sys/arch/arm/omap/am335x_prcm.c
diff -u src/sys/arch/arm/omap/am335x_prcm.c:1.6
src/sys/arch/arm/omap/am335x_prcm.c:1.7
--- src/sys/arch/arm/omap/am335x_prcm.c:1.6 Sat Aug 17 00:40:10 2013
+++ src/sys/arch/arm/omap/am335x_prcm.c Sun Jul 20 23:08:43 2014
@@ -1,4 +1,4 @@
-/* $NetBSD: am335x_prcm.c,v 1.6 2013/08/17 00:40:10 matt Exp $ */
+/* $NetBSD: am335x_prcm.c,v 1.7 2014/07/20 23:08:43 bouyer Exp $ */
/*
* TI OMAP Power, Reset, and Clock Management on the AM335x
@@ -34,7 +34,7 @@
*/
#include sys/cdefs.h
-__KERNEL_RCSID(0, $NetBSD: am335x_prcm.c,v 1.6 2013/08/17 00:40:10 matt Exp
$);
+__KERNEL_RCSID(0, $NetBSD: am335x_prcm.c,v 1.7 2014/07/20 23:08:43 bouyer Exp
$);
#include sys/types.h
#include sys/param.h
@@ -50,6 +50,8 @@ __KERNEL_RCSID(0, $NetBSD: am335x_prcm.
#define AM335X_CLKCTRL_MODULEMODE_DISABLED 0
#define AM335X_CLKCTRL_MODULEMODE_ENABLE2
+uint32_t am335x_devid;
+
static void
am335x_prcm_check_clkctrl(bus_size_t cm_module,
bus_size_t clkctrl_reg, uint32_t v)
@@ -98,19 +100,38 @@ prcm_module_disable(const struct omap_mo
am335x_prcm_check_clkctrl(cm_module, clkctrl_reg, clkctrl);
}
-static const uint16_t mpu_frequencies[] = {
- 550,
- 600,
- 650,
- 700,
- 720,
- 800,
- 900,
- 1000
+/*
+ * MPU frequency and power table, built from informations in
+ * http://processors.wiki.ti.com/index.php/AM335x_Power_Estimation_Tool
+ */
+
+struct mpu_frequency {
+ uint16_t freq; /* MPU frequency in Khz */
+ uint16_t mvolt; /* MPU voltage in millivolt */
};
-static int mpu_frequency;
-void
+static const struct mpu_frequency mpu_frequencies_rev0_zcz[] = {
+ {275, 1100},
+ {500, 1100},
+ {600, 1200},
+ {720, 1260},
+ {0, 0},
+};
+static const struct mpu_frequency mpu_frequencies_revA_zcz[] = {
+ {300, 950},
+ {550, 1100},
+ {600, 1100},
+ {720, 1200},
+ {800, 1260},
+ {900, 1325},
+ {1000, 1325},
+ {0, 0},
+};
+static const struct mpu_frequency *mpu_frequencies = NULL;
+
+static struct mpu_frequency mpu_frequency;
+
+static void
prcm_mpu_pll_config(u_int mpupll_m)
{
uint32_t clkmode = prcm_read_4(AM335X_PRCM_CM_WKUP,
AM335X_PRCM_CM_CLKMODE_DPLL_MPU);
@@ -144,12 +165,15 @@ static int
mpu_current_frequency_sysctl_helper(SYSCTLFN_ARGS)
{
struct sysctlnode node = *rnode;
-
Re: CVS commit: src/sys/arch
On 7/21/14, 2:16 PM, Jeff Rizzo wrote: Manuel- I think these changes (or one of the changes you've committed recently) broke building the BEAGLEBOARDXM kernel: The fix was straightforward so I just committed it. +j
Re: CVS commit: src/sys/arch/xen/xen
On 2/1/14, 2:49 PM, David Laight wrote: On Sat, Feb 01, 2014 at 08:07:07PM +, Manuel Bouyer wrote: I can't say I've actuallly looked a xen. Presumably we somewhere compile the hypervisor as part of a kernel? The hypervisor is in pkgsrc - sysutils/xenkernel42 (and the accompanying xentools42). It's not NetBSD-based. +j
Re: CVS commit: src/sys
On 11/24/13 12:19 PM, Christoph Egger wrote: Am 23.11.13 17:15, schrieb Jeff Rizzo: Module Name:src Committed By: riz Date: Sat Nov 23 16:15:25 UTC 2013 Modified Files: src/sys/coda: coda_vfsops.c src/sys/compat/netbsd32: netbsd32_compat_20.c src/sys/compat/osf1: osf1_mount.c src/sys/compat/ultrix: ultrix_fs.c src/sys/gdbscripts: vchain Log Message: Since mountlist is now a TAILQ, convert some missed usages so things build again. Why don't you use the TAILQ macros? I saw christos@ already did that for coda_vfsops.c. Christoph Be my guest...
Re: CVS commit: src/sys/arch/i386/conf
On 11/23/13 4:50 AM, Marc Balmer wrote: Zitat von Jeff Rizzo r...@netbsd.org: Module Name:src Committed By:riz Date:Fri Nov 22 18:58:01 UTC 2013 Modified Files: src/sys/arch/i386/conf: ALL Log Message: Comment out npf for now, as we can't have both NPF and PF in the same kernel - rmind has said he'll address this eventually, and for now PF is more likely to have unnoticed breakage. ALL now builds again! Wouldn't it make a more sense to disable pf since npf sees actual development, so testing it would actually help (and ALL is not meant to be run anyways)? To me compile testing npf would make much more sense than pf... ymmv. I did think about it, and I believe I laid out my reasoning in the commit message. +j
Re: CVS commit: src/external/lgpl3
On 8/19/13 3:25 PM, Matt Thomas wrote: Module Name:src Committed By: matt Date: Mon Aug 19 22:25:32 UTC 2013 Modified Files: src/external/lgpl3/gmp/lib/libgmp: Makefile src/external/lgpl3/mpfr/lib/libmpfr: Makefile Log Message: always compile GMP and MPFR as ARM To generate a diff of this commit: cvs rdiff -u -r1.16 -r1.17 src/external/lgpl3/gmp/lib/libgmp/Makefile cvs rdiff -u -r1.12 -r1.13 src/external/lgpl3/mpfr/lib/libmpfr/Makefile Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. This change broke the build for me (building for earmv6hf-el): --- uceil_log2.d --- /home/riz/src/external/lgpl3/mpfr/lib/libmpfr/../../dist/mpfr-impl.h:78:19: fatal error: gmp.h: No such file or directory (I *think* this was during the tools build, but I'm not 100% sure - backing out just this change allowed it to get past this point)
Re: CVS commit: src/sys/dev/usb
On 8/10/13 2:15 PM, John Nemeth wrote: Module Name:src Committed By: jnemeth Date: Sat Aug 10 21:15:26 UTC 2013 Modified Files: src/sys/dev/usb: if_urtwn.c usbdevs usbdevs.h usbdevs_data.h Log Message: PR/48112 - Kai-Uwe Eckhardt -- add support for Sitecom N300 usb wifi adapter To generate a diff of this commit: cvs rdiff -u -r1.24 -r1.25 src/sys/dev/usb/if_urtwn.c cvs rdiff -u -r1.651 -r1.652 src/sys/dev/usb/usbdevs cvs rdiff -u -r1.643 -r1.644 src/sys/dev/usb/usbdevs.h cvs rdiff -u -r1.644 -r1.645 src/sys/dev/usb/usbdevs_data.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. When making changes to usbdevs (or pcidevs, or similar files), you should always commit the change *first*, then regenerate usbdevs.h and usbdevs_data.h, because they embed the version of usbdevs. Also, it makes for easier pullups. +j
Re: CVS commit: [netbsd-6] src/share/zoneinfo
On 3/14/13 12:26 PM, Jeff Rizzo wrote: I aborted this commit partway through, which is why only one file made it to the mailing list (when I redid the commit). I have adjusted the commit logs in cvs. (curse non-atomic commits) +j
Re: CVS commit: [netbsd-6-0] src/external/bsd/bind/dist
On 12/14/12 12:22 AM, Erik Fair wrote: On Dec 13, 2012, at 09:42, Jeff Rizzo wrote: Module Name:src Committed By: riz Date: Thu Dec 13 17:42:04 UTC 2012 Modified Files: src/external/bsd/bind/dist [netbsd-6-0]: CHANGES version src/external/bsd/bind/dist/bin/named [netbsd-6-0]: query.c Log Message: external/bsd/bind/dist/CHANGES patch external/bsd/bind/dist/version patch external/bsd/bind/dist/bin/named/query.cpatch Address CVE-2012-5688: Named could die on specific queries with dns64 enabled. [spz, ticket #740] Is there some reason why this change was not also pulled up to netbsd-6? curious, Erik f...@netbsd.org Yes, netbsd-6 is getting a full-on new version of bind, but we're currently working out details of the patch. More soon. +j
Re: CVS commit: [netbsd-5] src/share/misc
On 10/24/12 1:59 AM, Martin Husemann wrote: On Wed, Oct 24, 2012 at 07:48:13AM +0400, Aleksej Saushev wrote: || 4.4BSD-Encumbered | | - | - NetBSD 0.8| BSD/386 1.0 - | / | | | -FreeBSD 1.0 ' NetBSD 0.9| BSD/386 1.1 + | NetBSD 0.8| BSD/386 1.0 + || | | +FreeBSD 1.0 NetBSD 0.9| BSD/386 1.1 And this part they always try to sneak in ;-) Martin Sigh. Can someone please fix these in -current, and request pullup? +j
Re: CVS commit: src/usr.sbin/postinstall
On 9/22/12 2:20 AM, Adrian Steinmann wrote: Module Name:src Committed By: ast Date: Sat Sep 22 09:20:07 UTC 2012 Modified Files: src/usr.sbin/postinstall: postinstall Log Message: Make sure that the to fix, run: ... instructions actually work cut-and-paste By default postinstall has mode 644 so /bin/sh or similar needs to be prepended To generate a diff of this commit: cvs rdiff -u -r1.146 -r1.147 src/usr.sbin/postinstall/postinstall Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. Um, /usr/sbin/postinstall is 555 by default. :) I don't know that we need to cater to uninstalled versions in the instructions. +j
Re: CVS commit: src/sys/dev/iscsi
On 5/28/12 6:12 AM, Christos Zoulas wrote: In article20120528034319.0c66217...@cvs.netbsd.org, Jeff Rizzosource-changes-d@NetBSD.org wrote: -=-=-=-=-=- Module Name:src Committed By: riz Date: Mon May 28 03:43:18 UTC 2012 Modified Files: src/sys/dev/iscsi: iscsi_main.c Log Message: Don't allow iscsi to autounload. The default unload timeout is short, and too much state is lost. This can be done better, I.e. instead of never unload, make it unload when it is not busy. christos Baby steps, baby steps. It can still be manually unloaded. The real problem is all the configuration from userland that gets lost when unloaded - the user needs to anticipate this, so he can reconfigure it when loaded again. +j
Re: CVS commit: [netbsd-5] src
On 4/21/12 10:58 AM, Takeshi Nakayama wrote: Pull up following revision(s) (requested by spz in ticket #1750): crypto/dist/openssl/crypto/mem.cpatch crypto/dist/openssl/crypto/asn1/a_d2i_fp.c patch crypto/dist/openssl/crypto/buffer/buffer.c patch sys/miscfs/genfs/genfs_io.c patch Address CVE-2012-2110. [spz, ticket #1750] Is the change for genfs_io.c intended? -- Takeshi Nakayama Clearly it doesn't belong - sorry for not catching it before. I've backed out that piece from all branches. +j
Re: CVS commit: [netbsd-6] src/doc
On 3/2/12 8:35 AM, Jeff Rizzo wrote: Module Name:src Committed By: riz Date: Fri Mar 2 16:35:50 UTC 2012 Modified Files: src/doc [netbsd-6]: CHANGES-6.0 Log Message: Tickets 62-66. This was actually tickets 62-65, the commit message has been fixed in the repo. +j
Re: CVS commit: src/sys/arch
On 1/6/12 10:26 AM, Manuel Bouyer wrote: On Fri, Jan 06, 2012 at 09:03:29PM +0530, Cherry G. Mathew wrote: The diagnostic message that it triggers is very verbose for XEN consoles, which ships with DIAGNOSTIC set by default ( not sure why this is the case ). GENERIC has DIAGNOSTIC set by default as well. It's been discussed removing this for releases; should we do this after the branch for 6.0? Or just prior to the release? +j
Re: CVS commit: src/lib/libperfuse
On 12/28/11 5:57 PM, Alistair Crooks wrote: On Thu, Dec 29, 2011 at 01:40:33AM +, Jeff Rizzo wrote: Module Name:src Committed By: riz Date: Thu Dec 29 01:40:32 UTC 2011 Modified Files: src/lib/libperfuse: debug.c Log Message: Cast time_t to intmax_t for printf purposes, and format with %j. Fixes build on amd64 and probably i386 as well. Thanks for fixing this one, Jeff. Any reason we're not using the PRI* definitions ininttypes.h? They didn't seem to add anything in this case, and muddled readability; am I missing something? +j
Re: CVS commit: src/sys/arch/xen
On 12/3/11 2:41 PM, Manuel Bouyer wrote: Module Name:src Committed By: bouyer Date: Sat Dec 3 22:41:40 UTC 2011 Modified Files: src/sys/arch/xen/x86: hypervisor_machdep.c src/sys/arch/xen/xen: xenevt.c Log Message: hypervisor_unmask_event(): don't check/update evtchn_pending_sel for the current CPU, but for any CPU which may accept this event. xen/xenevt.c: more use of atomic ops and locks where appropriate, and some other SMP fixes. Handle all events on the primary CPU (may be revisited later). Set/clear ci_evtmask[] for watched events. This should fix the problems on dom0 kernels reported by jym@ I can confirm that this fixes the problems I had starting domUs and ballooning with a -current dom0. Thanks! +j
Re: CVS commit: src/sys/dev/usb
On 7/30/11 1:05 PM, Jared D. McNeill wrote: Module Name:src Committed By: jmcneill Date: Sat Jul 30 20:05:36 UTC 2011 Modified Files: src/sys/dev/usb: ohci.c usbdi.c Log Message: PR# port-i386/18818: cannot enter ddb with usb keyboard - ohci: when polling, make sure sc_eintrs has the OHCI_WDH flag set otherwise ohci_intr1 won't actually read data - usbdi: kick the host controller by calling its soft_intr callback when switching out of polling mode too DDB with a USB keyboard works for me now with ohci. This fixes DDB-with-USB-keyboard on my macppc box, too! Thanks! +j
Re: CVS commit: src/crypto/external/bsd/netpgp/dist
On 7/21/11 10:33 AM, Julio Merino wrote: On 7/21/11 4:49 AM, Martin Husemann wrote: However, from my very practical experience (from all relevant sides: running tests, writing/extending them, and most importantly: fixing the troubles they show) it is not the framework that causes most problems in solving bugs, my top problem was: non working gdb (at least for threaded apps) How so? gdb with test programs should have been fixed a while ago. Or are we talking about something different? I believe this is a general gdb complaint, not specific to atf. I've run into this issue as well - there are some workarounds (threaded debugging works somewhat on core dumps), but it's a giant pain given than one of the key components of many tests (rump) is threaded... +j
Re: CVS commit: othersrc/external/bsd/iscsi/sys/dev/iscsi
On 6/9/11 3:08 PM, Jeff Rizzo wrote: struct cfdata * - caddr_t that's cfdata_t, not caddr_t. Sigh.
Re: CVS commit: [bouyer-quota2] src/sys/ufs/ffs
On 2/8/11 1:29 PM, Manuel Bouyer wrote: Module Name:src Committed By: bouyer Date: Tue Feb 8 21:29:46 UTC 2011 Modified Files: src/sys/ufs/ffs [bouyer-quota2]: ffs_subr.c Log Message: for !_KERNEL case, always define FFS_EI. Required for makefs, and maybe resize_ffs (it's not clear if resize_ffs supports swapped byte order or not - swapped endian tests are expected to fail but actually succeed :) Are you using an old version of the tests? Swapped byte order support for resize_ffs was added in early January, and the tests were updated to reflect that. I just checked the anita runs, and I see passing tests (not expected failures-which-pass). +j
Re: CVS commit: src
On 1/4/11 6:32 PM, Paul Goyette wrote: On Wed, 5 Jan 2011, Jeff Rizzo wrote: Log Message: Update resize_ffs tests for byteswapped file system support, and for UFS2 growth support. Also, reduce the number of tests run by default while still maintaining decent coverage of features and block sizes. Anyone working on resize_Ffs should run the tests with RESIZE_FFS_ALL_TESTS set in the environment, which adds a lot more testing. Jeff, I'm wondering if maybe it would be more correct to use an atf variable (ie, atf-run -v RESIZE_FFS_ALL_TESTS=true) rather than something in the environment? As an example, take a look at my recent commit for src/tests/lib/libc/string/t_popcount.c Yeah, that's probably a better way to handle it. I'll look into doing that tomorrow. +j
Re: CVS commit: src/external/bsd/bind
On 12/14/10 3:17 PM, Christos Zoulas wrote: Module Name:src Committed By: christos Date: Tue Dec 14 23:17:21 UTC 2010 Modified Files: src/external/bsd/bind: Makefile.inc Log Message: Handle NetBSD-5 and 4 lack of atomics by disabling threads. To generate a diff of this commit: cvs rdiff -u -r1.6 -r1.7 src/external/bsd/bind/Makefile.inc Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. Shouldn't you be testing atomic.h from the target system rather than the host? +.if exists(/usr/include/sys/atomic.h) ...seems wrong. +j
Re: CVS commit: [netbsd-5] src/sys/dev/usb
On 11/21/10 2:11 AM, Martin Husemann wrote: Module Name:src Committed By: martin Date: Sun Nov 21 10:11:59 UTC 2010 Modified Files: src/sys/dev/usb [netbsd-5]: usbdevs.h usbdevs_data.h Log Message: Regen (accidently mssing form [pullup-5 #1407]) To generate a diff of this commit: cvs rdiff -u -r1.515.4.6 -r1.515.4.7 src/sys/dev/usb/usbdevs.h cvs rdiff -u -r1.516.4.6 -r1.516.4.7 src/sys/dev/usb/usbdevs_data.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. Thanks for taking care of this. I knew I was forgetting something! +j
Re: CVS commit: src/lib/libc
On 6/19/10 12:44 PM, Izumi Tsutsui wrote: But isn't the whole point of building host tools to make sure that we DON'T depend on the installed userland? My point is: Just report a problem (with detailed info), but please don't complain. --- Izumi Tsutsui Yes, my apologies. It's true, complaining doesn't solve anything. I have a fix that I'm testing right now. I'll check it in once my test build is complete. +j
