CVS commit: src/etc
Module Name:src Committed By: tron Date: Sun Jul 30 09:09:38 UTC 2023 Modified Files: src/etc: services Log Message: Resolve the port 2049 conflict by commenting out the entries for "shilp". Now "netstat" will produce sensible output for NFS connections again. To generate a diff of this commit: cvs rdiff -u -r1.104 -r1.105 src/etc/services Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. Modified files: Index: src/etc/services diff -u src/etc/services:1.104 src/etc/services:1.105 --- src/etc/services:1.104 Mon Nov 28 02:48:33 2022 +++ src/etc/services Sun Jul 30 09:09:38 2023 @@ -1,4 +1,4 @@ -# $NetBSD: services,v 1.104 2022/11/28 02:48:33 jschauma Exp $ +# $NetBSD: services,v 1.105 2023/07/30 09:09:38 tron Exp $ # See also: services(5), https://www.iana.org/assignments/service-names-port-numbers/ # # Service Name and Transport Protocol Port Number Registry @@ -4659,8 +4659,8 @@ dls2047/tcp dls2047/udp dls-monitor2048/tcp dls-monitor2048/udp -shilp 2049/tcp# <== NOTE Conflict on 2049 ! -shilp 2049/udp# <== NOTE Conflict on 2049 ! +#shilp 2049/tcp# <== NOTE Conflict on 2049 ! +#shilp 2049/udp# <== NOTE Conflict on 2049 ! nfs2049/tcp# Network File System - Sun[Brent_Callaghan] [Brent_Callaghan]Defined TXT keys: path= # Microsystems nfs2049/udp# Network File System - Sun[Brent_Callaghan] [Brent_Callaghan]Defined TXT keys: path=
CVS commit: src/etc
Module Name:src Committed By: tron Date: Sun Jul 30 09:09:38 UTC 2023 Modified Files: src/etc: services Log Message: Resolve the port 2049 conflict by commenting out the entries for "shilp". Now "netstat" will produce sensible output for NFS connections again. To generate a diff of this commit: cvs rdiff -u -r1.104 -r1.105 src/etc/services Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
Re: CVS commit: src/lib/libc/rpc
On Wed, May 28, 2014 at 10:49:28AM -0400, Christos Zoulas wrote: Module Name: src Committed By: christos Date: Wed May 28 14:49:28 UTC 2014 Modified Files: src/lib/libc/rpc: svc_generic.c Log Message: CID 975117: check listen(2) return . To generate a diff of this commit: cvs rdiff -u -r1.15 -r1.16 src/lib/libc/rpc/svc_generic.c I don't think that this change is correct. It caused a lot of warnings svc_tli_create: could not listen at anonymous port when my NetBSD NIS client booted up. I suspected that this function is also used on UDP sockets where listen(2) will of course fail. Kind regards -- Matthias Scheler http://zhadum.org.uk/
Re: CVS commit: src/external/gpl3/gcc
On Wed, May 28, 2014 at 09:09:40AM +, Matthew Green wrote: Module Name: src Committed By: mrg Date: Wed May 28 09:09:39 UTC 2014 Modified Files: src/external/gpl3/gcc/lib/libstdc++-v3/arch/alpha: c++config.h config.h [...] src/external/gpl3/gcc/usr.bin/gcc/arch/x86_64: configargs.h Log Message: re-run mknative-gcc after threading fixes by skrll and myself. I get build failures on NetBSD/amd64 which seem to be related to threading: dependall === gnu/usr.bin/groff/src/devices/grodvi # link grodvi/grodvi /src/tools/bin/x86_64--netbsd-c++ --sysroot=/export/scratch/tron/obj/destdir.amd64 -o grodvi dvi.o -Wl,-rpath-link,/export/scratch/tron/obj/destdir.amd64/lib -L=/lib /export/scratch/tron/obj/gnu/usr.bin/groff/src/libs/libdriver/libdriver.a /export/scratch/tron/obj/gnu/usr.bin/groff/src/libs/libgroff/libgroff.a -lm /export/scratch/tron/obj/destdir.amd64/usr/lib/libstdc++.so: undefined reference to `std::__exception_ptr::exception_ptr::exception_ptr()'/export/scratch/tron/obj/destdir.amd64/usr/lib/libstdc++.so: undefined reference to `pthread_create' /export/scratch/tron/obj/destdir.amd64/usr/lib/libstdc++.so: undefined reference to `std::__exception_ptr::exception_ptr::~exception_ptr()'collect2: error: ld returned 1 exit status *** Failed target: grodvi *** Failed command: /src/tools/bin/x86_64--netbsd-c++ --sysroot=/export/scratch/tron/obj/destdir.amd64 -o grodvi dvi.o -Wl,-rpath-link,/export/scratch/tron/obj/destdir.amd64/lib -L=/lib /export/scratch/tron/obj/gnu/usr.bin/groff/src/libs/libdriver/libdriver.a /export/scratch/tron/obj/gnu/usr.bin/groff/src/libs/libgroff/libgroff.a -lm *** Error code 1 Stop. Kind regards -- Matthias Scheler https://zhadum.org.uk/
Re: CVS commit: src/external/gpl3/gcc
On Wed, May 28, 2014 at 02:12:40PM +0100, Matthias Scheler wrote: On Wed, May 28, 2014 at 09:09:40AM +, Matthew Green wrote: Module Name:src Committed By: mrg Date: Wed May 28 09:09:39 UTC 2014 Modified Files: src/external/gpl3/gcc/lib/libstdc++-v3/arch/alpha: c++config.h config.h [...] src/external/gpl3/gcc/usr.bin/gcc/arch/x86_64: configargs.h Log Message: re-run mknative-gcc after threading fixes by skrll and myself. I get build failures on NetBSD/amd64 which seem to be related to threading: The automated builds have reported the same failure in the meantime: http://mail-index.netbsd.org/current-users/2014/05/28/msg024980.html Kind regards -- Matthias Scheler https://zhadum.org.uk/
Re: CVS commit: src/gnu/usr.bin/texinfo/makeinfo
On Mon, Mar 24, 2014 at 11:20:04PM +, Christos Zoulas wrote: In article 20140324230302.1ad1...@cvs.netbsd.org, Matthias Scheler source-changes-d@NetBSD.org wrote: Module Name: src Committed By:tron Date:Mon Mar 24 23:03:02 UTC 2014 Modified Files: src/gnu/usr.bin/texinfo/makeinfo: Makefile Log Message: Don't compile with fortification. It breaks makeinfo(1) for certain input files (e.g. cl.texi shipped with Emacs 23.4) if it is compiled with GCC 4.8.3 and USE_SSP set to yes. How does it fail? Segv? Syntax error? It complains about a lot missing links between nodes. All nodes need to have up, next and prev link. And it has code to automatically populate those. But for some reason the string it is coping is empty and it therefore considers the links missing. I've tried to find out what and where goes wrong but failed to do so. Kind regards -- Matthias Scheler https://zhadum.org.uk/
Re: CVS commit: src/gnu/usr.bin/texinfo/makeinfo
On Tue, Mar 25, 2014 at 11:56:56AM -0400, Christos Zoulas wrote: | How does it fail? Segv? Syntax error? | | It complains about a lot missing links between nodes. All nodes need | to have up, next and prev link. And it has code to automatically | populate those. But for some reason the string it is coping is empty | and it therefore considers the links missing. I've tried to find | out what and where goes wrong but failed to do so. Thanks! Perhaps it is a real bug... I guess it is somewhere in the middle. There might be some questionable code which breaks because of the limit enforcing of fortification. But I couldn't find it yesterday and I really wanted to have emacs on my NetBSD-current machine. Kind regards -- Matthias Scheler https://zhadum.org.uk/
Re: CVS commit: src/tools
On Sun, Dec 16, 2012 at 06:47:40AM +, Alan Barrett wrote: Module Name: src Committed By: apb Date: Sun Dec 16 06:47:39 UTC 2012 Modified Files: src/tools/libctf: Makefile src/tools/libdwarf: Makefile src/tools/libelf: Makefile Log Message: If you are going to append things to CPPFLAGS and then transfer the result to HOST_CPPFLAGS later, then also include the value of HOST_CPPFLAGS in this process. This should fix a problem in which the value of HOST_CPPFLAGS set by compat/defs.mk was lost during a build with MKDTRACE=yes. That fixes the build for me. Thanks a lot -- Matthias Scheler http://zhadum.org.uk/
Re: CVS commit: src
On Sun, Mar 04, 2012 at 04:12:25PM +, Matthias Scheler wrote: Module Name: src Committed By: tron Date: Sun Mar 4 16:12:25 UTC 2012 Modified Files: src/distrib/sets/lists/man: mi src/external/ibm-public/postfix: Makefile.inc src/external/ibm-public/postfix/lib/global: Makefile src/external/ibm-public/postfix/man/man5: Makefile src/sys/sys: cdefs_elf.h Log Message: Add support for SQLite look-up tables to postfix(1), see sqlite_table(5) for more details. While here stop installation of pcre_table(5) as this table type is not supported. The change to src/sys/sys/cdefs_elf.h has nothing to do with this feature and was committed by accident. I've revert that change and updated the commit message in the repository. Sorry ... Kind regards -- Matthias Scheler http://zhadum.org.uk/
Re: CVS commit: src/external/mit/expat/dist
On Sat, Feb 11, 2012 at 10:40:03PM +0200, Alan Barrett wrote: On Sat, 11 Feb 2012, Matthias Scheler wrote: Log Message: Initial import of expat 2.0.1 into base: This is James Clark's expat XML parser library in C. It is a stream oriented parser that requires setting handlers to deal with the structure that the parser discovers in the document. This is the first part of the fix for PR lib/40346. Regardless of whether or not you got approval from releng, I think it's inappropriate to make major or controversial changes without public discussion. As far as I can tell from reading the PR you were the only objecting to it. Concerning your objection: There is nothing wrong with the apache package in particuluar. As long as libexpat in /usr/X11R7 all packages using libexpat that get built on a system with native X11 (e.g. the TNF package build machines) won't work on systems without X11 installed. And there a lot of package (like e.g. the apache package) where that is no good reason for that. The only semi-public discussion that I am aware of was in the comments on PR 40346, where there was not consensus that adding expat to base was a good idea. One of the last comments there said that discussion on that issue should go to tech-userlevel, but there was no discussion in tech-userlevel. Well, it is on the list of Important bugs for NetBSD 6.0. So my assumption was that it should be fixed. Kind regards -- Matthias Scheler http://zhadum.org.uk/
Re: CVS commit: src/sys
On Thu, Nov 24, 2011 at 03:51:33PM +, Adam Hoka wrote: Module Name: src Committed By: ahoka Date: Thu Nov 24 15:51:33 UTC 2011 Modified Files: src/sys/sys: vnode.h src/sys/ufs: files.ufs src/sys/ufs/ufs: ufsmount.h Added Files: src/sys/ufs/chfs: chfs.h chfs_args.h chfs_build.c chfs_erase.c chfs_gc.c chfs_ihash.c chfs_inode.h chfs_malloc.c chfs_nodeops.c chfs_pool.c chfs_pool.h chfs_readinode.c chfs_scan.c chfs_subr.c chfs_vfsops.c chfs_vnode.c chfs_vnode_cache.c chfs_vnops.c chfs_wbuf.c chfs_write.c debug.c debug.h ebh.c ebh.h ebh_media.h ebh_misc.h media.h Log Message: Import CHFS, which was formerly known as ChewieFS. Thanks a lot. But why was this imported into src/sys/ufs and not into src/sys? It is not a UFS derivative, is it? Kind regards -- Matthias Scheler http://zhadum.org.uk/
Re: CVS commit: src/share/man/man5
On Mon, Nov 07, 2011 at 06:51:58AM +0200, Jukka Ruohonen wrote: On Sun, Nov 06, 2011 at 10:34:48PM +, Matthias Scheler wrote: Module Name:src Committed By: tron Date: Sun Nov 6 22:34:48 UTC 2011 Modified Files: src/share/man/man5: mk.conf.5 Log Message: Stack-smash protection is not enabled by default, at least not for the complete source-tree. Pointed out by bch on current-users mailing list. Wasn't there an explicit decision to enable it by default? Yes, for kernel builds. Kind regards -- Matthias Scheler http://zhadum.org.uk/
Re: CVS commit: src/share/man/man4
On Tue, Aug 30, 2011 at 05:58:02AM +, Jukka Ruohonen wrote: Module Name: src Committed By: jruoho Date: Tue Aug 30 05:58:02 UTC 2011 Modified Files: src/share/man/man4: bktr.4 Log Message: Note that bktr(4) is not part of the dtv(4) infrastructure. XXX: This driver should be converted (or even bluntly removed, given the lack of general third-party software support). It is supported by pkgsrc/multimedia/fxtv which the last time I had an analog TV feed worked well enough to watch TV. Kind regards -- Matthias Scheler http://zhadum.org.uk/
Re: CVS commit: src/share/man/man4
On Tue, Aug 30, 2011 at 03:42:18PM +0200, Martin Husemann wrote: On Tue, Aug 30, 2011 at 01:31:50PM +0100, Matthias Scheler wrote: It is supported by pkgsrc/multimedia/fxtv which the last time I had an analog TV feed worked well enough to watch TV. Just curious: are there analog TV feeds out there, anywhere, still? I thought you can still get (or rather keep) analog Cable TV in Germany. And you might be able to feed the output of a digital set-top box into one of these cards as well. Kind regards -- Matthias Scheler http://zhadum.org.uk/
Re: CVS commit: src/share/man/man4
On Tue, Aug 30, 2011 at 03:42:34PM +0300, Jukka Ruohonen wrote: XXX: This driver should be converted (or even bluntly removed, given the lack of general third-party software support). It is supported by pkgsrc/multimedia/fxtv which the last time I had an analog TV feed worked well enough to watch TV. Yes, I know there may be few, largely irrelevant (old, non-maintained?), programs that may work with it. But the major ones in this field -- be it mplayer, MythTV, VDR, Kaffeine, VLC, Totem, you name it -- won't work. The open source scene in this field has made some big leaps. That's why we have dtv(4) and FreeBSD has Cuse4BSD. Old BSD-specific solutions have no future. I'm not argueing with any of that. I actually think it is great that NetBSD now provides video capture drivers that work with a lot of third party software. This is however not related to my comment. The bktr(4) driver allows users to watch TV with the fxtv package. As long as the driver can still support that use case and doesn't get in the way of a major other feature it should be left alone. The best solution would of course to replace it with a driver for the new framework. But that might be a lot of work for hardware which might become obsolete in the near future. Kind regards -- Matthias Scheler http://zhadum.org.uk/
Re: src/sys/modules/spdmem
On Fri, Aug 19, 2011 at 07:49:55PM +1000, matthew green wrote: If it helped, then it would also be fine to change const char * format = %s; to const char * const format = %s; but it doesn't help. martin discovered that this one works: const char fmt[] = ...; Which is the better choice anyway as it saves 4 or 8 bytes of static data. Kind regards -- Matthias Scheler http://zhadum.org.uk/
Re: CVS commit: src/sys
On Sat, Jul 30, 2011 at 01:01:05PM -0400, Christos Zoulas wrote: Module Name: src Committed By: christos Date: Sat Jul 30 17:01:05 UTC 2011 Modified Files: src/sys/conf: files src/sys/kern: init_main.c kern_lwp.c kern_synch.c Added Files: src/sys/kern: subr_pserialize.c src/sys/sys: pserialize.h Log Message: Add an implementation of passive serialization as described in expired US patent 4809168. This is a reader / writer synchronization mechanism, designed for lock-less read operations. Thanks a lot. Kind regards -- Matthias Scheler http://zhadum.org.uk/
Re: CVS commit: src/sys/modules
On Tue, Jul 19, 2011 at 11:13:32PM +, enami tsugutomo wrote: Module Name: src Committed By: enami Date: Tue Jul 19 23:13:31 UTC 2011 Modified Files: src/sys/modules: Makefile Log Message: Build v7fs module on all architecture rather than only on i386. Yes, that was the intention. Sorry about the mistake. Kind regards -- Matthias Scheler http://zhadum.org.uk/
Re: CVS commit: src/sbin/newfs_v7fs
On Tue, Jul 19, 2011 at 08:20:52AM +0900, tsugutomo.en...@jp.sony.com wrote: Log Message: Don't use roundup2(9) (which should have been howmany(9) anyway) to fix builds on platforms other than NetBSD. Since usr.sbin/makefs/cd9660.[ch] already uses howmany(), we can use it here too, can't we? Indeed, we can and we should. Thanks a lot -- Matthias Scheler http://zhadum.org.uk/
Re: CVS commit: src
On 7 Jul 2011, at 16:50, Jukka Ruohonen wrote: Module Name: src Committed By: jruoho Date: Thu Jul 7 15:50:23 UTC 2011 Modified Files: src/distrib/sets/lists/tests: mi src/tests/lib/libc/stdlib: Makefile Added Files: src/tests/lib/libc/stdlib: t_getenv.c Removed Files: src/tests/lib/libc/stdlib: t_environment.c t_environment_pth.c Log Message: Merge 't_environment' and 't_environment_pth'. Please undo that change. The point of two different tests was in particular that one binary is linked with libpthread and the other one isn't. Kind regards -- Matthias Scheler http://zhadum.org.uk/
Re: CVS commit: src
On Thu, Jul 07, 2011 at 10:05:53PM +0300, Jukka Ruohonen wrote: We have nearly five hundred test files. This is a problem why? ... whereas the libc-tests should be strictly about functional verification. This about functional testing. This is whether the environment code works with and without real locking, with and without libpthread present. Kind regards -- Matthias Scheler http://zhadum.org.uk/
Re: CVS commit: src
On Sat, May 28, 2011 at 11:42:37PM +0100, Julio M. Merino Vidal wrote: On 5/28/11 10:46 PM, Christos Zoulas wrote: In article20110528161256.ab89817...@cvs.netbsd.org, Matthias Schelersource-changes-d@NetBSD.org wrote: + assert(pipe(fds) == 0); [...] + assert(write(fds[1], , 1) == 1); [...] + assert(close(fds[0]) == 0); + assert(close(fds[1]) == 0); [...] + assert(sigfillset(mask) == 0); [...] + assert(sigprocmask(SIG_SETMASK, NULL,mask) == 0); [...] + assert(close(fd) == 0); Please don't create assertions that contain code, because compiled with -DNDEBUG they vanish. Are these test code? If so, just replace assert by one of: - ATF_REQUIRE(boolean_expression) - ATF_REQUIRE_EQ(expected_value, actual_value) like: ATF_REQUIRE(pipe(fds) != 0); ATF_REQUIRE_EQ(1, write(fds[1], , 1)); I've fixed it as suggested by you. Kind regards -- Matthias Scheler http://zhadum.org.uk/
Re: CVS commit: src/tests/syscall
On Sun, May 29, 2011 at 02:57:14PM +0100, Julio M. Merino Vidal wrote: On 5/29/11 1:57 PM, Matthias Scheler wrote: Modified Files: src/tests/syscall: t_pollts.c Log Message: [...] Also use ATF_REQUIRE_EQ_MSG() instead of ATF_REQUIRE_MSG() to avoid crashes if one of the required conditions isn't met. It could be a bug in the macro. I tried changing the last ATF_REQUIRE_EQ_MSG call in the program to ATF_REQUIRE_MSG but it did not fail. And I tried adding an explicitly-failing ATF_REQUIRE_MSG and did not see a crash either... I don't think it's a bug in the macro. The problem was that it use the 0 value as the format string which caused a crash. I'm not sure why I haven't seen this before. Kind regards -- Matthias Scheler http://zhadum.org.uk/
Re: CVS commit: src
On Sun, May 29, 2011 at 01:07:34PM +, Christos Zoulas wrote: I've fixed it as suggested by you. Thank you! Now if I could only figure out why the pselect tests work on virtual pc and not a real machine. They also fail on virtual machines: http://www.gson.org/netbsd/bugs/build/build/2011.05.29.12.57.14/test.html#syscall_t_pselect_pselect_signal_mask_with_signal Kind regards -- Matthias Scheler http://zhadum.org.uk/
Re: CVS commit: src
On Sun, May 29, 2011 at 06:18:11AM -0700, Paul Goyette wrote: Thank you! Now if I could only figure out why the pselect tests work on virtual pc and not a real machine. Perhaps it is because the real machine is SMP/multi-core? By default, qemu virtual machines are single-core. It fails for me on a virtual machine with four (virtual) cores as well. And yes, that VM can really use four cores. Kind regards -- Matthias Scheler http://zhadum.org.uk/
Re: CVS commit: src/tests/syscall
On Sat, May 28, 2011 at 11:34:49AM -0400, Christos Zoulas wrote: Module Name: src Committed By: christos Date: Sat May 28 15:34:49 UTC 2011 Modified Files: src/tests/syscall: t_pselect.c Log Message: add a timeout test Your tests don't pass on my setup: t_pselect (17/21): 2 test cases pselect_signal_mask_with_signal: Failed: pselect() did not receive signal pselect_signal_mask_with_timeout: Failed: pselect() did not receive signal Kind regards -- Matthias Scheler http://zhadum.org.uk/
Re: CVS commit: src/share/mk
On Sun, Apr 17, 2011 at 11:34:26PM +1000, matthew green wrote: Log Message: Don't use --sysroot=/ for host builds as nbhost-mkdep doesn't understand that option. This should unbreak tool builds. hmm, i haven't seen this problem. what failed for you? ./build -O /path/to/obj -u -U -j 8 -x distribution sets under NetBSD/i386 5.99.49 are you sure it was a completely clean build? Yes, tool and object directory were empty. we should fix nbhost-mkdep if it is broken, and revert this change. Please go ahead. Kind regards -- Matthias Scheler http://zhadum.org.uk/
Re: CVS commit: src/share/mk
On Sun, Apr 17, 2011 at 11:03:37AM -0400, Christos Zoulas wrote: Module Name: src Committed By: christos Date: Sun Apr 17 15:03:37 UTC 2011 Modified Files: src/share/mk: bsd.own.mk Log Message: Revert previous, breaks builds completely (cd /usr/src/bin/test make clean make) You have now broken the tools build again: === build.sh command:./build.sh -O /export/scratch/tron/obj -u -U -x tools === build.sh started:Sun Apr 17 18:52:12 BST 2011 === NetBSD version: 5.99.49 === MACHINE: i386 === MACHINE_ARCH:i386 === Build platform: NetBSD 5.99.49 i386 === HOST_SH: /bin/sh === No $TOOLDIR/bin/nbmake, needs building. === Bootstrapping nbmake [...] #create libelf/elf_begin.d /src/tools/bin/nbhost-mkdep -f elf_begin.d -- --sysroot=/ -I/src/NetBSD-current/src/tools/libelf/../compat -I/src/NetBSD-current/src/tools/libelf/../../external/bsd/libelf/dist -I/src/tools/include/nbinclude -DLIBELF_TEST_HOOKS -DHAVE_NBTOOL_CONFIG_H=1 -D_FILE_OFFSET_BITS=64 -I/export/scratch/tron/obj/tools/compat -I/src/tools/include /src/NetBSD-current/src/tools/libelf/../../external/bsd/libelf/dist/elf_begin.c /src/tools/bin/nbhost-mkdep: Unknown option: --sysroot=/ *** Failed target: elf_begin.d *** Failed command: /src/tools/bin/nbhost-mkdep -f elf_begin.d -- --sysroot=/ -I/src/NetBSD-current/src/tools/libelf/../compat -I/src/NetBSD-current/src/tools/libelf/../../external/bsd/libelf/dist -I/src/tools/include/nbinclude -DLIBELF_TEST_HOOKS -DHAVE_NBTOOL_CONFIG_H=1 -D_FILE_OFFSET_BITS=64 -I/export/scratch/tron/obj/tools/compat -I/src/tools/include /src/NetBSD-current/src/tools/libelf/../../external/bsd/libelf/dist/elf_begin.c *** Error code 1 Stop. nbmake: stopped in /src/NetBSD-current/src/tools/libelf *** Failed target: dependall-libelf *** Failed command: _makedirtarget() { dir=$1; shift; target=$1; shift; case ${dir} in /*) this=${dir}/; real=${dir} ;; .) this=; real=/src/NetBSD-current/src/tools ;; *) this=${dir}/; real=/src/NetBSD-current/src/tools/${dir} ;; esac; show=${this:-.}; echo ${target} === ${show%/}${1:+ (with: $@)}; cd ${real} /src/tools/bin/nbmake _THISDIR_=${this} $@ ${target}; }; _makedirtarget libelf dependall *** Error code 1 Stop. nbmake: stopped in /src/NetBSD-current/src/tools ERROR: Failed to make dependall in tools *** BUILD ABORTED *** Can you please fix that? Kind regards -- Matthias Scheler http://zhadum.org.uk/
Re: CVS commit: src/share/mk
On Sun, Apr 17, 2011 at 07:04:05PM +0100, Matthias Scheler wrote: You have now broken the tools build again: === build.sh command:./build.sh -O /export/scratch/tron/obj -u -U -x tools [...] Some testing revealed that this only happens if you MKDTRACE is set to yes. So please try this command line: ./build.sh -V MKDTRACE=yes -O /where/ever/obj -u -U -x tools Kind regards -- Matthias Scheler http://zhadum.org.uk/
Re: CVS commit: src/sys/fs/msdosfs
On Thu, Mar 03, 2011 at 08:10:45AM +, Antti Kantee wrote: Module Name: src Committed By: pooka Date: Thu Mar 3 08:10:45 UTC 2011 Modified Files: src/sys/fs/msdosfs: msdosfs_vnops.c Log Message: In rename, use char[12]?for new names instead of [11]. At least one routine called from here (unix2dosfn) expects and uses all of a [12]. This may fix the stack size exceeded problem which has been triggering in gson's test runs. (i'm not entirely sure why it doesn't trigger in anyone else's env) Is he perhaps using USE_SSP=yes? Kind regards -- Matthias Scheler http://zhadum.org.uk/
Re: CVS commit: src/sys/fs/msdosfs
On Thu, Mar 03, 2011 at 11:12:35AM +0200, Antti Kantee wrote: Is he perhaps using USE_SSP=yes? Isn't that the default? Only for kernels and certain directories e.g. src/lib/libc. Maybe we should: 1.) Build all tests with USE_SSP=yes. 2.) Run them with MALLOC_OPTIONS set to AJ. Kind regards -- Matthias Scheler http://zhadum.org.uk/
Re: CVS commit: src/external/ibm-public/postfix
On Sun, Feb 13, 2011 at 12:12:55AM -0500, Christos Zoulas wrote: Module Name: src Committed By: christos Date: Sun Feb 13 05:12:55 UTC 2011 Modified Files: src/external/ibm-public/postfix: Makefile.inc Log Message: change the variable to USE_LIB_SASL that can be set to saslc or cyrus Do we really want to support USE_LIB_SASL=cyrus? Linking stuff in base again libraries from pkgsrc sounds like a big hack to me and will e.g. break cross compiling. Kind regards -- Matthias Scheler http://zhadum.org.uk/
Re: CVS commit: src/external/ibm-public/postfix
On Sun, Feb 13, 2011 at 09:37:12PM +, Christos Zoulas wrote: Do we really want to support USE_LIB_SASL=cyrus? Linking stuff in base again libraries from pkgsrc sounds like a big hack to me and will e.g. break cross compiling. I did not put it there, I found it there. As far as I can tell you added it in revision 1.3: Index: Makefile.inc === RCS file: /cvsroot/src/external/ibm-public/postfix/Makefile.inc,v retrieving revision 1.2 retrieving revision 1.3 diff -u -r1.2 -r1.3 --- Makefile.inc25 Jun 2009 18:21:50 - 1.2 +++ Makefile.inc12 Feb 2011 19:07:08 - 1.3 @@ -1,20 +1,33 @@ -# $NetBSD: Makefile.inc,v 1.2 2009/06/25 18:21:50 tron Exp $ +# $NetBSD: Makefile.inc,v 1.3 2011/02/12 19:07:08 christos Exp $ .include bsd.own.mk USE_FORT?= yes # network client and server +HAVE_LIB_SASLC?= yes WARNS?=0 PFIX_DISTDIR= ${NETBSDSRCDIR}/external/ibm-public/postfix/dist -CPPFLAGS+= -DNETBSD4 -DUSE_SASL_AUTH -DDEF_SERVER_SASL_TYPE=\dovecot\ \ +CPPFLAGS+= -DNETBSD4 -DUSE_SASL_AUTH \ -I${DIST} \ -I${PFIX_DISTDIR}/src/dns -I${PFIX_DISTDIR}/src/global \ -I${PFIX_DISTDIR}/src/master -I${PFIX_DISTDIR}/src/util \ -I${PFIX_DISTDIR}/src/tls -I${PFIX_DISTDIR}/src/milter \ -I${PFIX_DISTDIR}/src/xsasl +.if defined(HAVE_LIB_SASLC) +CPPFLAGS+= -DUSE_SASL_AUTH -DUSE_SASLC_SASL +LDADD+= -lsaslc +.elif defined(HAVE_CYRUS_SASL) +CPPFLAGS+= -DUSE_SASL_AUTH -DUSE_CYRUS_SASL \ + -DDEF_SERVER_SASL_TYPE=\cyrus\ \ + -I/usr/pkg/include/sasl +LDADD+= -lsasl2 -L/usr/pkg/lib -Wl,-R/usr/pkg/lib +.else +CPPFLAGS+= -DDEF_SERVER_SASL_TYPE=\dovecot\ +.endif + .if defined(HAVE_PCC) # code uses gcc-specific aggregate dynamic array CPPFLAGS+= -DCANT_USE_SEND_RECV_MSG And yes there is less reason to use cyrus right now, which is what the libsaslc project is all about. I agree. Kind regards -- Matthias Scheler http://zhadum.org.uk/
Re: CVS commit: src
On 13 Jan 2011, at 22:28, Adam Hamsik wrote: Module Name: src Committed By: haad Date: Thu Jan 13 22:28:37 UTC 2011 Modified Files: src/distrib/sets/lists/base: mi src/distrib/sets/lists/comp: mi src/sbin: Makefile src/usr.sbin: Makefile Added Files: src/sbin/chown: Makefile chgrp.1 chown.8 chown.c Removed Files: src/usr.sbin/chown: Makefile chgrp.1 chown.8 chown.c Log Message: Move chown from usr.sbin to sbin and chgrp from usr.bin to bin directories. This was discussed and oked on tech-userlevel I have run full build release, test anita cycle with this patch. This will break installation on systems which use a separate /usr file-system because you create symlinks between /sbin and /usr/sbin respectively /bin and /usr/bin. Please consider using SYMLINKS for the compatibility links. Kind regards -- Matthias Scheler http://zhadum.org.uk/
Re: CVS commit: src/etc/rc.d
On Sun, Jan 09, 2011 at 02:47:27AM +, David Holland wrote: On Sat, Jan 08, 2011 at 11:49:54PM +, Matthias Scheler wrote: This is no longer true, for lvm and other things, so let's take a deep breath and move chown. Yes, but we should probably provide a symlink from /usr/sbin/chown to /sbin/chown for backwards compatibility reasons. Maybe for a while, but I hope not permanently... It's been in /usr/sbin for almost 18 years. And the symlink doesn't really hurt. Kind regards -- Matthias Scheler http://zhadum.org.uk/
Re: CVS commit: src/lib/libm
On Sun, Jan 09, 2011 at 02:32:14AM +, Jonathan A. Kollasch wrote: Module Name: src Committed By: jakllsch Date: Sun Jan 9 02:32:13 UTC 2011 Modified Files: src/lib/libm: Makefile Added Files: src/lib/libm/noieee_src: n_fmax.c n_fmaxf.c n_fmin.c n_fminf.c Log Message: Imlementations of fmax, fmaxf, fmin and fminf libm functions for VAX. Thank you. Kind regards -- Matthias Scheler http://zhadum.org.uk/
Re: CVS commit: src/etc/rc.d
On 8 Jan 2011, at 23:21, David Holland wrote: This is no longer true, for lvm and other things, so let's take a deep breath and move chown. Yes, but we should probably provide a symlink from /usr/sbin/chown to /sbin/chown for backwards compatibility reasons. I don't like the idea of having rc.d scripts depend on /rescue. Me neither. Kind regards -- Matthias Scheler http://zhadum.org.uk/
Re: CVS commit: src/bin/dd
On Tue, Nov 23, 2010 at 02:42:04PM +0200, Antti Kantee wrote: (on a slight tangent, wasn't getting rid of /usr vs. / on the roadmap?) I don't know that. I personally don't create /usr partitions on my NetBSD systems anymore. But they usually have hard disks with multiple gigabytes of storage space. /usr over NFS is useful for a system with a shortage of local disk space. Kind regards -- Matthias Scheler http://zhadum.org.uk/
Re: CVS commit: src/bin/cp
On Sun, Oct 24, 2010 at 10:56:40PM +, David Holland wrote: Anyway, ISTM that writing from the mmap buffer in say 64K chunks would retain nearly all the advantages and get rid of the latency problem. The way the code is currently written it only uses mmap(2) for files smaller than 8MB anyway. Your suggested change would require more work than reducing the size of the mapped memory. There is also the problem that the overhead per call to mmap(2) or munmap(2) is high on some platforms, IIRC alpha is one of them. Changing the code as you suggested above might therefore impact performance on some ports. Kind regards -- Matthias Scheler http://zhadum.org.uk/
Re: CVS commit: src/bin/cp
On Mon, Oct 25, 2010 at 08:52:43AM +0100, Matthias Scheler wrote: On Sun, Oct 24, 2010 at 10:56:40PM +, David Holland wrote: Anyway, ISTM that writing from the mmap buffer in say 64K chunks would retain nearly all the advantages and get rid of the latency problem. The way the code is currently written it only uses mmap(2) for files smaller than 8MB anyway. Your suggested change would require more work than reducing the size of the mapped memory. Forget that, I misunderstood what you said. We can still use one mmap(2) but should write out that memory with multile write(2) system calls. Kind regards -- Matthias Scheler http://zhadum.org.uk/
Re: CVS commit: src/bin/cp
On Tue, Oct 26, 2010 at 05:05:28AM +1100, matthew green wrote: On Mon, Oct 25, 2010 at 08:52:43AM +0100, Matthias Scheler wrote: On Sun, Oct 24, 2010 at 10:56:40PM +, David Holland wrote: Anyway, ISTM that writing from the mmap buffer in say 64K chunks would retain nearly all the advantages and get rid of the latency problem. The way the code is currently written it only uses mmap(2) for files smaller than 8MB anyway. Your suggested change would require more work than reducing the size of the mapped memory. Forget that, I misunderstood what you said. We can still use one mmap(2) but should write out that memory with multile write(2) system calls. FWIW, bozohttpd defaults to mapping upto 64MB regions and writing out up to 64KB at a time. cp(1) now maps a region upto 8MB and writes it out in chunks of at most 64KB. Kind regards -- Matthias Scheler http://zhadum.org.uk/
Re: CVS commit: src/lib/libc/stdio
On Mon, Oct 25, 2010 at 12:24:14AM +0700, Robert Elz wrote: Date:Sun, 24 Oct 2010 16:00:46 +0100 From:Matthias Scheler t...@netbsd.org Message-ID: 20101024150046.ga...@colwyn.zhadum.org.uk | It doesn't have to be a macro anyway as it used only ones. Yes, I meant to ask about that, simply written inline would be no problem. That's what I've done now. Kind regards -- Matthias Scheler http://zhadum.org.uk/
Re: CVS commit: src/lib/libc/stdio
On Sat, Oct 23, 2010 at 10:12:51AM -0400, Christos Zoulas wrote: Module Name: src Committed By: christos Date: Sat Oct 23 14:12:51 UTC 2010 Modified Files: src/lib/libc/stdio: local.h Log Message: tell lint to shut up. I'm sorry but this whole code is horrible. What is wrong with something as simple as this? Index: local.h === RCS file: /cvsroot/src/lib/libc/stdio/local.h,v retrieving revision 1.28 diff -u -r1.28 local.h --- local.h 23 Oct 2010 14:12:50 - 1.28 +++ local.h 23 Oct 2010 15:10:27 - @@ -37,6 +37,8 @@ #include wcio.h #include fileext.h +#include limits.h + /* * Information local to this implementation of stdio, * in particular, macros and private variables. @@ -117,5 +119,4 @@ /* * Detect if the current file position fits in a long int. */ -#define _FPOS_OVERFLOW(pos) (/*CONSTCOND*/sizeof(fpos_t) sizeof(long) \ - ((pos) (~0ULL ((sizeof(fpos_t) - sizeof(long)) * NBBY))) != 0) +#define _FPOS_OVERFLOW(pos) ((pos) LONG_MIN || (pos) LONG_MAX) It works fine under NetBSD/i386 and builts fine for NetBSD/amd64. And I would hope that the compiler is clever anough to optimize the code away on 64bit platforms. Kind regards -- Matthias Scheler http://zhadum.org.uk/
Re: putenv/setenv changes
On Sun, Oct 03, 2010 at 12:49:32AM +0200, Alan Barrett wrote: I suggest a BUGS section in putenv(3) stating that that the interface uses non-const char* for compatibility with POSIX brain damage, but the implementation guarantees to treat it as read-only. There is not such guarantee really. Strings in the environment should be writable. But in the past programs got away under NetBSD with adding non-writable strings. If the program afterwards behaved nicely e.g. by not writing to a pointer return by getenv(3) there wasn't a problem. All I wanted to do is restore that behaviour. I'm not sure whether it is good idea to document that we tolerate it. Kind regards -- Matthias Scheler http://zhadum.org.uk/
Re: putenv/setenv changes
On Sat, Oct 02, 2010 at 11:40:12PM +, Christos Zoulas wrote: I suggest a BUGS section in putenv(3) stating that that the interface uses non-const char* for compatibility with POSIX brain damage, but the implementation guarantees to treat it as read-only. Actually the string must be writeable because POSIX requires you to use the actual string passed to putenv() inside the environment array. All strings in the environment array must be writable. I am ambivalent about the binary compatibility restoration, ... I think it is important. There are several binaries distributed with NetBSD which did that (cron, date and rcp) or still do that (all of Postfix's setuid programs). There are probably a lot more in pkgsrc and it would be very bad if all of those suddenly start crashing after an upgrade to NetBSD 6.0. ... because while it fixes the common case, it might break programs that use both putenv and setenv (hopefully none). It shouldn't. I've tried to take care of that with the second half of the change. setenv(3) will not try to write to an environment string that it didn't allocate itself. Kind regards -- Matthias Scheler http://zhadum.org.uk/
Re: putenv/setenv changes
On Sun, Oct 03, 2010 at 09:07:45AM +0200, Alan Barrett wrote: Actually the string must be writeable because POSIX requires you to use the actual string passed to putenv() inside the environment array. All strings in the environment array must be writable. If you mess with the environment using putenv(const string), then you should expect the relevant portion to no longer be writable by your program; ... Yes, but something else might try to write to it. ... but the implementation can still guarantee that none of the putenv/setenv/getenv functions will write to it. Which is the case for our libc after my change. Kind regards -- Matthias Scheler http://zhadum.org.uk/
Re: CVS commit: src/lib/libc/stdlib
On Thu, Sep 30, 2010 at 03:05:26PM +0200, Nicolas Joly wrote: One possibility could be to not free memory at all in setenv, but only with unsetenv. I'm not convinced about that. IMHO, it's a programmer error to call setenv more than once on the same variable without a corresponding unsetenv in between (just like malloc()/free() behaviour). Is there any standard which backs this statement? Otherwise, if i understand things correctly, it's more putenv that shoud work that way. Our putenv(3) is implemented via setenv(3). Kind regards -- Matthias Scheler http://zhadum.org.uk/
Re: CVS commit: src/lib/libc/stdlib
On Thu, Sep 30, 2010 at 03:35:41PM +0200, Nicolas Joly wrote: That may be part of the problem (at least for zsh 4.2). http://www.opengroup.org/onlinepubs/009695399/functions/putenv.html From the OpenGroup function description; this function does not copy the provided string, but use it directly instead. It's the caller responsability to clean it when not in use anymore. I see. zsh 4.2 seems to follow this and try to deallocate the previous variable string when it has been replaced by a new one. But our putenv, which calls setenv, has already done the same ... So it assumes that it gets back from getenv(3) exactly what it passed into putenv(3). Well, it seesm our putenv(3) needs a rewrite. I think that setenv(3) and unsetenv(3) are correct as they are. Kind regards -- Matthias Scheler http://zhadum.org.uk/
Re: CVS commit: src/usr.bin/audiocfg
On 6 Sep 2010, at 23:35, Christos Zoulas wrote: Should we make perror() produce a warning so people will stop using it? No, as it is not a NetBSD specific API. Kind regards -- Matthias Scheler http://zhadum.org.uk/
Re: CVS commit: src/distrib/sets/lists/man
On 2 Sep 2010, at 0:28, John Nemeth wrote: The npf.conf manpages were moved to section 5. This should not have been added back here. You need to delete these files from your destdir. No, that's wrong. They are not only in the destdir, they are installed on a lot of systems and need to be removed. The instructions for the correct fix where in the diff you quoted: } # } # Note: don't delete entries from here - mark them as obsolete instead. } # It doesn't matter that it was only a few days. There is a well defined way how to handle renaming files. If people use it The Right Thing(TM) happens. Kind regards -- Matthias Scheler http://zhadum.org.uk/
Re: CVS commit: src/distrib/sets/lists/man
On 2 Sep 2010, at 6:18, John Nemeth wrote: } No, that's wrong. They are not only in the destdir, they are installed } on a lot of systems and need to be removed. The instructions for the I doubt it was on a lot of systems, it was probably only a few. My NetBSD-current system had npf.conf(8) installed and it didn't get purged before I fixed the set lists. } It doesn't matter that it was only a few days. There is a well defined It was two days and five hours. That is plenty for the getting the file installed on a lot of NetBSD-current system. } way how to handle renaming files. If people use it The Right Thing(TM) } happens. I am well aware of what The Right Thing(TM) is. However, for such a short time period I would argue for simply removing the entries. Why? Otherwise you get entries that are only useful to a handful of people that clutter up the lists until the end of time. It is much better to clutter up the lists then to clutter up a NetBSD installation. Removing obsolete files is one of the most time consuming parts of postinstall. And running postinstall is the least time consuming part of updating NetBSD-current on my system. Extracting the sets takes much longer, not to mention building the sets in the first place. I have no problems with adding things to the list when it is necessary, but this was borderline. I disagree. BTW, the same issue pops up when a library version is bumped since the old versions are deliberately not added to the obsolete lists so that they don't get removed from systems that are being upgraded. This means that you have to be prepared to deal with the occassional failure of this nature when doing update builds anyways. I'm aware of this case. But in this case there is a good reason. And I'm less concerned about the destdir anyway. I'm concerned about obsolete manual pages remaining on a system. Kind regards -- Matthias Scheler http://zhadum.org.uk/
Re: CVS commit: src/sys/dev/dm
On Tue, May 18, 2010 at 03:10:41PM +, Adam Hamsik wrote: Log Message: Add support for DIOCCACHESYNC ioctl for dm devices. Add new sync function pointer to dm_target_t because that is the only part of dm which know real block device. disk_ioctl_switch parses whole device table and for every entry it calls particular sync routine which propagates DIOCCACHESYNC to real disk. What happens if a logical volume consists of two slice of one physical device? Will the physical device get flushed twice? Kind regards -- Matthias Scheler http://zhadum.org.uk/
Re: CVS commit: src/lib/libc/stdio
On 6 May 2010, at 9:14, Jukka Ruohonen wrote: Module Name: src Committed By: jruoho Date: Thu May 6 08:14:08 UTC 2010 Modified Files: src/lib/libc/stdio: ferror.3 Log Message: Correct the discussion about return values: fileno() may fail and return -1. Note that in such cases the NetBSD implementation does not set errno to EBADF, hence diverging from the standard in this small detail. Is there any reason not to make in compliant? It seems like a reasonable change. Kind regards -- Matthias Scheler http://zhadum.org.uk/
Re: CVS commit: src/external/cddl/osnet/dev/dtrace/i386
On Thu, Mar 18, 2010 at 11:44:40PM +0900, Izumi Tsutsui wrote: Modified Files: src/external/cddl/osnet/dev/dtrace/i386: dtrace_subr.c Log Message: Fix the build: 1.) ifdef-out unused functions and global variables. 2.) Include x86/include/cpu_counter.h for amd64 and i386 to get the prototype of cpu_frequency. Probably this should be rewritten to use MI timecounter(9)? Well, it seems to be an architecture specific file anyway. But I don't know the details, I just mechanically fixed the build. Kind regards -- Matthias Scheler http://zhadum.org.uk/
CVS commit: src/distrib/sets/lists/modules
Module Name:src Committed By: tron Date: Wed Mar 3 14:32:29 UTC 2010 Modified Files: src/distrib/sets/lists/modules: mi Log Message: The solaris kernel module also gets build if ZFS is enabled. To generate a diff of this commit: cvs rdiff -u -r1.8 -r1.9 src/distrib/sets/lists/modules/mi Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. Modified files: Index: src/distrib/sets/lists/modules/mi diff -u src/distrib/sets/lists/modules/mi:1.8 src/distrib/sets/lists/modules/mi:1.9 --- src/distrib/sets/lists/modules/mi:1.8 Mon Mar 1 21:10:19 2010 +++ src/distrib/sets/lists/modules/mi Wed Mar 3 14:32:29 2010 @@ -1,4 +1,4 @@ -# $NetBSD: mi,v 1.8 2010/03/01 21:10:19 darran Exp $ +# $NetBSD: mi,v 1.9 2010/03/03 14:32:29 tron Exp $ # # Note: don't delete entries from here - mark them as obsolete instead. # @@ -103,7 +103,7 @@ ./@MODULEDIR@/smbfsbase-kernel-modules kmod ./@MODULEDIR@/smbfs/smbfs.kmod base-kernel-modules kmod ./@MODULEDIR@/solarisbase-kernel-modules kmod,dtrace -./@MODULEDIR@/solaris/solaris.kmod base-kernel-modules kmod,dtrace +./@MODULEDIR@/solaris/solaris.kmod base-kernel-modules kmod,dtrace,zfs ./@MODULEDIR@/suserbase-kernel-modules kmod ./@MODULEDIR@/suser/suser.kmod base-kernel-modules kmod ./@MODULEDIR@/sysvbfsbase-kernel-modules kmod
CVS commit: src/distrib/sets/lists/modules
Module Name:src Committed By: tron Date: Wed Mar 3 14:43:41 UTC 2010 Modified Files: src/distrib/sets/lists/modules: mi Log Message: The directory modules/solaris depends on ZFS as well. To generate a diff of this commit: cvs rdiff -u -r1.9 -r1.10 src/distrib/sets/lists/modules/mi Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. Modified files: Index: src/distrib/sets/lists/modules/mi diff -u src/distrib/sets/lists/modules/mi:1.9 src/distrib/sets/lists/modules/mi:1.10 --- src/distrib/sets/lists/modules/mi:1.9 Wed Mar 3 14:32:29 2010 +++ src/distrib/sets/lists/modules/mi Wed Mar 3 14:43:41 2010 @@ -1,4 +1,4 @@ -# $NetBSD: mi,v 1.9 2010/03/03 14:32:29 tron Exp $ +# $NetBSD: mi,v 1.10 2010/03/03 14:43:41 tron Exp $ # # Note: don't delete entries from here - mark them as obsolete instead. # @@ -102,7 +102,7 @@ ./@MODULEDIR@/securelevel/securelevel.kmod base-kernel-modules kmod ./@MODULEDIR@/smbfsbase-kernel-modules kmod ./@MODULEDIR@/smbfs/smbfs.kmod base-kernel-modules kmod -./@MODULEDIR@/solarisbase-kernel-modules kmod,dtrace +./@MODULEDIR@/solarisbase-kernel-modules kmod,dtrace,zfs ./@MODULEDIR@/solaris/solaris.kmod base-kernel-modules kmod,dtrace,zfs ./@MODULEDIR@/suserbase-kernel-modules kmod ./@MODULEDIR@/suser/suser.kmod base-kernel-modules kmod
CVS commit: src/distrib/sets
Module Name:src Committed By: tron Date: Wed Mar 3 16:13:42 UTC 2010 Modified Files: src/distrib/sets: mkvars.mk sets.subr src/distrib/sets/lists/modules: mi Log Message: dtrace,zfs means MKDTRACE=yes *and* MKZFS=yes which is not what we want. Invent a flag solaris which is the or of those two flags. To generate a diff of this commit: cvs rdiff -u -r1.1 -r1.2 src/distrib/sets/mkvars.mk cvs rdiff -u -r1.121 -r1.122 src/distrib/sets/sets.subr cvs rdiff -u -r1.10 -r1.11 src/distrib/sets/lists/modules/mi Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/distrib/sets
Module Name:src Committed By: tron Date: Wed Mar 3 16:13:42 UTC 2010 Modified Files: src/distrib/sets: mkvars.mk sets.subr src/distrib/sets/lists/modules: mi Log Message: dtrace,zfs means MKDTRACE=yes *and* MKZFS=yes which is not what we want. Invent a flag solaris which is the or of those two flags. To generate a diff of this commit: cvs rdiff -u -r1.1 -r1.2 src/distrib/sets/mkvars.mk cvs rdiff -u -r1.121 -r1.122 src/distrib/sets/sets.subr cvs rdiff -u -r1.10 -r1.11 src/distrib/sets/lists/modules/mi Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. Modified files: Index: src/distrib/sets/mkvars.mk diff -u src/distrib/sets/mkvars.mk:1.1 src/distrib/sets/mkvars.mk:1.2 --- src/distrib/sets/mkvars.mk:1.1 Thu Dec 10 15:51:24 2009 +++ src/distrib/sets/mkvars.mk Wed Mar 3 16:13:42 2010 @@ -1,4 +1,4 @@ -# $NetBSD: mkvars.mk,v 1.1 2009/12/10 15:51:24 uebayasi Exp $ +# $NetBSD: mkvars.mk,v 1.2 2010/03/03 16:13:42 tron Exp $ MKEXTRAVARS= \ MACHINE \ @@ -45,7 +45,7 @@ # -mkvars: mkvarsyesno mkextravars .PHONY +mkvars: mkvarsyesno mkextravars mksolaris .PHONY mkvarsyesno: .PHONY .for i in ${_MKVARS.yes} @@ -59,3 +59,10 @@ .for i in ${MKEXTRAVARS} @echo $i=${$i} .endfor + +mksolaris: .PHONY +.if (${MKDTRACE} != no || ${MKZFS} != no) + @echo MKSOLARIS=yes +.else + @echo MKSOLARIS=no +.endif Index: src/distrib/sets/sets.subr diff -u src/distrib/sets/sets.subr:1.121 src/distrib/sets/sets.subr:1.122 --- src/distrib/sets/sets.subr:1.121 Sun Feb 21 03:18:45 2010 +++ src/distrib/sets/sets.subr Wed Mar 3 16:13:42 2010 @@ -1,4 +1,4 @@ -# $NetBSD: sets.subr,v 1.121 2010/02/21 03:18:45 darran Exp $ +# $NetBSD: sets.subr,v 1.122 2010/03/03 16:13:42 tron Exp $ # # @@ -168,7 +168,7 @@ # In each file, a record consists of a path and a System Package name, # separated by whitespace. E.g., # -# # $NetBSD: sets.subr,v 1.121 2010/02/21 03:18:45 darran Exp $ +# # $NetBSD: sets.subr,v 1.122 2010/03/03 16:13:42 tron Exp $ # . base-sys-root [keyword[,...]] # ./altroot base-sys-root # ./bin base-sys-root @@ -232,6 +232,7 @@ # profile ${MKPROFILE} != no # share ${MKSHARE} != no # skey ${MKSKEY} != no +# solaris ${MKDTRACE} != no or ${MKZFS} != no # x11 ${MKX11} != no ${X11FLAVOUR} != Xorg # xorg ${MKX11} != no ${X11FLAVOUR} == Xorg # yp ${MKYP} != no Index: src/distrib/sets/lists/modules/mi diff -u src/distrib/sets/lists/modules/mi:1.10 src/distrib/sets/lists/modules/mi:1.11 --- src/distrib/sets/lists/modules/mi:1.10 Wed Mar 3 14:43:41 2010 +++ src/distrib/sets/lists/modules/mi Wed Mar 3 16:13:42 2010 @@ -1,4 +1,4 @@ -# $NetBSD: mi,v 1.10 2010/03/03 14:43:41 tron Exp $ +# $NetBSD: mi,v 1.11 2010/03/03 16:13:42 tron Exp $ # # Note: don't delete entries from here - mark them as obsolete instead. # @@ -102,8 +102,8 @@ ./@MODULEDIR@/securelevel/securelevel.kmod base-kernel-modules kmod ./@MODULEDIR@/smbfsbase-kernel-modules kmod ./@MODULEDIR@/smbfs/smbfs.kmod base-kernel-modules kmod -./@MODULEDIR@/solarisbase-kernel-modules kmod,dtrace,zfs -./@MODULEDIR@/solaris/solaris.kmod base-kernel-modules kmod,dtrace,zfs +./@MODULEDIR@/solarisbase-kernel-modules kmod,solaris +./@MODULEDIR@/solaris/solaris.kmod base-kernel-modules kmod,solaris ./@MODULEDIR@/suserbase-kernel-modules kmod ./@MODULEDIR@/suser/suser.kmod base-kernel-modules kmod ./@MODULEDIR@/sysvbfsbase-kernel-modules kmod
CVS commit: src/sys/sys
Module Name:src Committed By: tron Date: Wed Feb 24 10:18:19 UTC 2010 Modified Files: src/sys/sys: dtrace_bsd.h Log Message: Fix build of the dtrace kernel module. To generate a diff of this commit: cvs rdiff -u -r1.2 -r1.3 src/sys/sys/dtrace_bsd.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/external/cddl/osnet/usr.sbin/zdb
Module Name:src Committed By: tron Date: Wed Feb 24 11:56:35 UTC 2010 Modified Files: src/external/cddl/osnet/usr.sbin/zdb: Makefile Log Message: Disable stack protection warnings for zdb_il.c which uses a dynamically sized array on the stack. To generate a diff of this commit: cvs rdiff -u -r1.2 -r1.3 src/external/cddl/osnet/usr.sbin/zdb/Makefile Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/external/cddl/osnet/lib/libdtrace
Module Name:src Committed By: tron Date: Wed Feb 24 12:51:06 UTC 2010 Modified Files: src/external/cddl/osnet/lib/libdtrace: Makefile Log Message: Disable stack protection warnings for sources which use dynamically sized stack buffers. To generate a diff of this commit: cvs rdiff -u -r1.2 -r1.3 src/external/cddl/osnet/lib/libdtrace/Makefile Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/external/cddl/osnet/lib/libdtrace
Module Name:src Committed By: tron Date: Wed Feb 24 15:40:54 UTC 2010 Modified Files: src/external/cddl/osnet/lib/libdtrace: Makefile Log Message: Disable stack protection warnings for more sources which use dynamically sized stack buffers. To generate a diff of this commit: cvs rdiff -u -r1.3 -r1.4 src/external/cddl/osnet/lib/libdtrace/Makefile Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/external/cddl/osnet/usr.sbin/dtrace
Module Name:src Committed By: tron Date: Mon Feb 22 12:21:27 UTC 2010 Modified Files: src/external/cddl/osnet/usr.sbin/dtrace: Makefile Log Message: Disable stack protection warnings for dtrace.c which uses alloca(3). To generate a diff of this commit: cvs rdiff -u -r1.3 -r1.4 src/external/cddl/osnet/usr.sbin/dtrace/Makefile Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. Modified files: Index: src/external/cddl/osnet/usr.sbin/dtrace/Makefile diff -u src/external/cddl/osnet/usr.sbin/dtrace/Makefile:1.3 src/external/cddl/osnet/usr.sbin/dtrace/Makefile:1.4 --- src/external/cddl/osnet/usr.sbin/dtrace/Makefile:1.3 Sun Feb 21 11:00:02 2010 +++ src/external/cddl/osnet/usr.sbin/dtrace/Makefile Mon Feb 22 12:21:27 2010 @@ -1,4 +1,4 @@ -# $NetBSD: Makefile,v 1.3 2010/02/21 11:00:02 darran Exp $ +# $NetBSD: Makefile,v 1.4 2010/02/22 12:21:27 tron Exp $ # $FreeBSD: src/cddl/usr.sbin/dtrace/Makefile,v 1.1.4.1 2009/08/03 08:13:06 kensmith Exp $ @@ -27,6 +27,7 @@ #CFLAGS+= -DNEED_ERRLOC #YFLAGS+= -d +COPTS.dtrace.c += -Wno-stack-protector LDFLAGS+= -pthread
CVS commit: src/usr.bin/wc
Module Name:src Committed By: tron Date: Fri Feb 19 11:15:23 UTC 2010 Modified Files: src/usr.bin/wc: wc.c Log Message: Report the number of characters, not the number of bytes in the longest line. Problem pointed out by YAMAMOTO Takashi on tech-userlevel mailing list. To generate a diff of this commit: cvs rdiff -u -r1.33 -r1.34 src/usr.bin/wc/wc.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/external/mit/xorg/bin/xterm
Module Name:src Committed By: tron Date: Thu Feb 4 13:22:34 UTC 2010 Modified Files: src/external/mit/xorg/bin/xterm: Makefile Log Message: Define HAVE_TERMCAP_H to fix build with the new terminfo library. To generate a diff of this commit: cvs rdiff -u -r1.5 -r1.6 src/external/mit/xorg/bin/xterm/Makefile Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/ddb
Module Name:src Committed By: tron Date: Tue Feb 2 09:04:14 UTC 2010 Modified Files: src/sys/ddb: db_user.h db_write_cmd.c Log Message: Include ctype.h in the central place which deals with building the kernel debugger as a userland program. To generate a diff of this commit: cvs rdiff -u -r1.1 -r1.2 src/sys/ddb/db_user.h cvs rdiff -u -r1.25 -r1.26 src/sys/ddb/db_write_cmd.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/ddb
Module Name:src Committed By: tron Date: Mon Feb 1 09:56:58 UTC 2010 Modified Files: src/sys/ddb: db_write_cmd.c Log Message: Include ctype.h if we are not building a kernel to fix the build of crash(8). To generate a diff of this commit: cvs rdiff -u -r1.24 -r1.25 src/sys/ddb/db_write_cmd.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: xsrc/external/mit/expat/dist/lib
Module Name:xsrc Committed By: tron Date: Wed Jan 27 13:17:47 UTC 2010 Modified Files: xsrc/external/mit/expat/dist/lib: xmlparse.c Log Message: Add patch from upstream CVS to fix CVE-2009-3560 (possible DOS due to crash on bad input). To generate a diff of this commit: cvs rdiff -u -r1.1.1.1 -r1.2 xsrc/external/mit/expat/dist/lib/xmlparse.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: xsrc/xfree/xc/extras/expat/lib
Module Name:xsrc Committed By: tron Date: Wed Jan 27 13:47:28 UTC 2010 Modified Files: xsrc/xfree/xc/extras/expat/lib: xmlparse.c Log Message: Add patch from upstream CVS to fix CVE-2009-3560 (possible DOS due to crash on bad input). To generate a diff of this commit: cvs rdiff -u -r1.1.1.2 -r1.2 xsrc/xfree/xc/extras/expat/lib/xmlparse.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: xsrc/xfree/xc/config/pswrap
Module Name:xsrc Committed By: tron Date: Wed Jan 27 13:46:39 UTC 2010 Modified Files: xsrc/xfree/xc/config/pswrap: lexer.l Log Message: Remove EMX compatibility hack which breaks NetBSD/alpha cross-builds, at least under Mac OS X. To generate a diff of this commit: cvs rdiff -u -r1.2 -r1.3 xsrc/xfree/xc/config/pswrap/lexer.l Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
Re: CVS commit: src/share/mk
On Fri, Dec 04, 2009 at 11:21:07AM +, Adam Hamsik wrote: Module Name: src Committed By: haad Date: Fri Dec 4 11:21:07 UTC 2009 Modified Files: src/share/mk: bsd.own.mk Log Message: Switch MKLVM to default value to yes. There are only few bits missing and it would be great if it can receive more testing. Oked: core@, yamt@ To generate a diff of this commit: cvs rdiff -u -r1.601 -r1.602 src/share/mk/bsd.own.mk BTW: could you please also add pseudo-device dm to GENERIC, etc.? It should probably be added to all kernel configuration which use pseudo-device raid. Kind regards -- Matthias Scheler http://zhadum.org.uk/
Re: CVS commit: src/distrib/sets
On Tue, Dec 08, 2009 at 09:12:26AM +0900, Masao Uebayashi wrote: I wonder why we don't have ${TOOL_SH}. Because making our shell portable will probably be much harder than occasionally fixing some shell scripts. Kind regards -- Matthias Scheler http://zhadum.org.uk/
Re: CVS commit: src/share/mk
On Fri, Dec 04, 2009 at 12:45:22PM +0900, Masao Uebayashi wrote: Maybe this is simpler: sidebeach% nbmake-i386 -V MKZFS yes sidebeach% nbmake-i386 -V MKZFS MKZFS=no no sidebeach% nbmake-shark -V MKZFS no sidebeach% nbmake-shark -V MKZFS MKZFS=yes yes Yes, indeed. But this will only work if sets.subr actually checks for this variable, won't it? Kind regards -- Matthias Scheler http://zhadum.org.uk/
Re: CVS commit: src/usr.sbin/rpc.lockd
On Fri, Nov 27, 2009 at 06:22:30AM +, YAMAMOTO Takashi wrote: hi, Module Name:src Committed By: christos Date: Thu Nov 19 22:27:26 UTC 2009 Modified Files: src/usr.sbin/rpc.lockd: lockd_lock.c Log Message: allow comparing v2 and v3 filehandles. this seems loose to me. how about normalizing file handles? (ideally lockd should be in kernel) If I understood the Isilon presentation during EuroBSDCon 2009 correctly FreeBSD 8.0 has an in-kernel lockd. Porting their code might be an option to achieve that. Kind regards -- Matthias Scheler http://zhadum.org.uk/
Re: Subject: CVS commit: src/share/mk
On Thu, Nov 12, 2009 at 12:40:54PM +, Mindaugas Rasiukevicius wrote: Well, I do not really care about this type of philosophical security in the kernel, but by estimating the effect, I would say there is more cost than benefit - modern x86 machines have a PG_NX bit, which deals with this matter in a much better way. It only prevents attacks where code gets written on the stack. It doesn't stop attack which overwrite the return address to point and a random bit of the code segment. And if somebody can smash the kernel stack, then your system is doomed anyway.. Yes, but the question is whether the attack can panic the kernel (bad) or gain root access to your system (very, very bad). Kind regards -- Matthias Scheler http://zhadum.org.uk/
Re: Subject: CVS commit: src/share/mk
On Thu, Nov 12, 2009 at 07:19:55AM +, Mindaugas Rasiukevicius wrote: Log Message: Enable Stack Smash Protection (SSP) by default for NetBSD/amd64 and NetBSD/i386 as previously discussed on the port-amd64 and port-i386 mailing lists. No objections from the core team. My last impression from port-{i386|amd64} was that SSP wont be enabled. The majority of people seemed to be in favour of the change. Point that it can find some bugs is reasonable, but then why not enable it for, let's say, DIAGNOSTIC option? Because it is also a security feature. I can e.g. turn a remote root exploit into a DoS which will at least keep your data safe. Kind regards -- Matthias Scheler http://zhadum.org.uk/
Re: CVS commit: src/sys/dev
On Mon, Nov 09, 2009 at 07:04:41PM -0600, David Young wrote: Modified Files: src/sys/dev: cgd.c Log Message: Don't allocate block buffers on the stack. This can cause stack overflows in the kernel and breaks SSP builds. This is a step in the right direction, but now cgd(4) is doing malloc(..., M_WAITOK) in (software) interrupt context. I'm sorry, I didn't realise that it was called in that context. A LOCKDEBUG kernel will panic. How can we avoid the stack overflows and such in a different way? I'll try to rewrite the code to use M_NOWAIT. Kind regards -- Matthias Scheler http://zhadum.org.uk/
Re: CVS commit: src/sys/dev
On Mon, Nov 09, 2009 at 07:04:41PM -0600, David Young wrote: Log Message: Don't allocate block buffers on the stack. This can cause stack overflows in the kernel and breaks SSP builds. This is a step in the right direction, but now cgd(4) is doing malloc(..., M_WAITOK) in (software) interrupt context. A LOCKDEBUG kernel will panic. How can we avoid the stack overflows and such in a different way? 1.) I misunderstood the meaning of blocksize in this context. It is the not the disk blocksize but the blocksize of the cipher. The maximum value at the moment is 128 bytes which will result in a total of 384 bytes of buffers allocated on the stack. There is therefore no risk of stack overflows. 2.) I have backed out my changes to fix the LOCKDEBUG kernel panics. Thanks a lot for pointing out the problem. Kind regards -- Matthias Scheler http://zhadum.org.uk/
Re: CVS commit: src/sys/dev
On Tue, Nov 10, 2009 at 03:05:51PM -0500, Christos Zoulas wrote: Module Name: src Committed By: christos Date: Tue Nov 10 20:05:51 UTC 2009 Modified Files: src/sys/dev: cgd.c cgdvar.h Log Message: avoid variable array stack allocation by enforcing and allocating always the maximum. The change isn't completely correct. The code will later use sizeof(sink) and sizeof(blkno_buf) which is no the maximum and not the actual buffer size. You probably need to replace all those occurrences of sizeof by blocksize. Kind regards -- Matthias Scheler http://zhadum.org.uk/
Re: CVS commit: src/lib/libc/stdio
On Mon, Oct 26, 2009 at 06:14:36AM +, David Holland wrote: On Sun, Oct 25, 2009 at 05:09:34PM +, David Laight wrote: Lint is differentially far too picky... Remove some warnings that only appear on i386 (not on amd64) and that for some reason best known to others are deemed fatal for i386. Making this code 'pass lint' does absolutely nothing for its readability (etc). we need a new lint. Is Sun's lint (the one they use for OSnet builds) open source these days? I remember from my days at Sun that it was very good. Kind regards -- Matthias Scheler http://zhadum.org.uk/
Re: CVS commit: src/distrib/sets/lists/base
On Sun, Oct 11, 2009 at 01:17:04PM +0200, Christoph Badura wrote: Uh. Why is it in there anyway? Because NetBSD/amd64 and NetBSD/sparc64 provide 32 bit libraries for COMPAT_NETBSD32. Kind regards -- Matthias Scheler http://zhadum.org.uk/
Re: CVS commit: src/bin/sh
On Wed, Oct 07, 2009 at 10:45:53AM +0200, Alan Barrett wrote: On Wed, 07 Oct 2009, Thomas Klausner wrote: For me, on current/amd64, the boot (without -s) stops and asks for a shell. I've got the same problem under NetBSD/i386. I choose /bin/sh, then leave it, and I get the prompt again. When I replace /bin/sh with one from 20090922, boot succeeds to multi-user mode without these symptoms. Does /etc/rc run at all? Yes, it is run. You could add set -x in strategic places to try to figure out what's going wrong. It breaks here: scripts=$(for rcd in ${rc_directories:-/etc/rc.d}; do test -d ${rcd} echo ${rcd}/*; done) With the new /bin/sh the scripts variable is empty afterwards. Kind regards -- Matthias Scheler http://zhadum.org.uk/
Re: CVS commit: src
On Mon, Sep 14, 2009 at 11:17:25AM +, Michael Shalayeff wrote: pfsync never collided w/ anything. it used unassigned proto number. Does it still do that? Kind regards -- Matthias Scheler http://zhadum.org.uk/
Re: CVS commit: src/distrib/utils/sysinst
On Sun, Aug 23, 2009 at 09:16:17PM +, Jared D. McNeill wrote: Modified Files: src/distrib/utils/sysinst: menus.mi msg.mi.de msg.mi.en msg.mi.es msg.mi.fr msg.mi.pl util.c Log Message: Get rid of the 'select extraction verbosity' menu. Which option does it use now? The progress bar? Kind regards -- Matthias Scheler http://zhadum.org.uk/
Re: CVS commit: src/sys/sys
On Sun, Aug 09, 2009 at 09:20:02PM +, Christos Zoulas wrote: In article 20090809210918.gc22...@drowsy.duskware.de, Martin Husemann mar...@duskware.de wrote: On Sun, Aug 09, 2009 at 09:29:50PM +0200, Tonnerre LOMBARD wrote: Unfortunately, these are widely used headers. We don't want to break -Wold-style-casts in general. Why not? It is IMHO a very useless and stupid warning. The new style casts are very useful because they show programming intent. Can't we instead do what Solaris does? #ifdef __cplusplus extern C { #endif [...] #define __byte_swap_u64_constant(x) \ ((uint64_t) \ [...] #ifdef __cplusplus } #endif That should allows us to keep the old-casts and avoid warnings. Kind regards -- Matthias Scheler http://zhadum.org.uk/
Re: CVS commit: src/sys/sys
On Sun, Aug 09, 2009 at 11:23:53PM +0200, Tonnerre LOMBARD wrote: There may be valid reasons not to want to have them. Yes, in C++ sources and header files. System header files are C headers, not C++ headers. Kind regards P.S. The fundamental problem is of course that C++ tries to be backwards compatible without forcing you to use extern C. -- Matthias Scheler http://zhadum.org.uk/
Re: CVS commit: src/external/ibm-public
On Tue, Jun 23, 2009 at 06:02:04PM -0400, Perry E. Metzger wrote: Matthias Scheler t...@netbsd.org writes: Log Message: Add makefile framework to build Postfix 2.6.2. Don't turn it on yet as the Postfix 2.6.2 binary doesn't work yet because it cannot find /usr/libexec/postfix/postfix-script. That has to be /etc/postfix/postfix-script (yes, I know, it is unusual, but Wietse had reasons for wanting it that way -- it is partially configuration oriented.) Not any more. Even the Postfix makefiles install it to /usr/libexec now. Kind regards -- Matthias Scheler http://zhadum.org.uk/
Re: CVS commit: src/external/ibm-public
On Tue, Jun 23, 2009 at 03:07:05PM +, Christos Zoulas wrote: Shouldn't all the programs go to bin/program instead at the top level? Indeed. I'll fix that later. Kind regards -- Matthias Scheler http://zhadum.org.uk/
Re: CVS commit: src/external/ibm-public
On Thu, Jun 25, 2009 at 10:04:01AM -0400, Perry E. Metzger wrote: Ah, well, if that has changed, then clearly it should be left in the new setup. That does leave the question of whether we should obsolete the /etc/postfix/postfix-script etc files in the set lists. Yes, we should. And I've already done that. Kind regards -- Matthias Scheler http://zhadum.org.uk/
Re: CVS commit: src/lib/libiscsi
On Thu, Jun 25, 2009 at 08:47:45PM +, David Young wrote: Module Name: src Committed By: dyoung Date: Thu Jun 25 20:47:45 UTC 2009 Modified Files: src/lib/libiscsi: Makefile Log Message: Update the path to the iSCSI sources, which have moved to external/bsd/iscsi/dist/ from dist/iscsi/. I think this change is unnecessary. libiscsi is now built via the makefile in src/external/bsd/iscsi/lib. Kind regards -- Matthias Scheler http://zhadum.org.uk/
Re: CVS commit: src/usr.sbin/pwd_mkdb
On Thu, Jun 18, 2009 at 06:13:56PM -0400, Christos Zoulas wrote: Module Name: src Committed By: christos Date: Thu Jun 18 22:13:56 UTC 2009 Modified Files: src/usr.sbin/pwd_mkdb: pwd_mkdb.c Log Message: allow overwriting the version record. This change or one of the two previous ones breaks unprivileged builds: --- install-etc-files --- # install /export/scratch/tron/obj/destdir.i386/etc/master.passwd cd /src/NetBSD-current/src/etc /src/tools/bin/i486--netbsdelf-install -U -M /export/scratch/tron/obj/destdir.i386/METALOG -D /export/scratch/tron/obj/destdir.i386 -h sha256 -N /src/NetBSD-current/src/etc -c -p -r -T etc_pkg -o root -g wheel -m 600 master.passwd /export/scratch/tron/obj/destdir.i386/etc /src/tools/bin/nbpwd_mkdb -p -L -d /export/scratch/tron/obj/destdir.i386/ /export/scratch/tron/obj/destdir.i386/etc/master.passwd nbpwd_mkdb: Database /etc/pwd.db has no version info nbpwd_mkdb: Cannot open database /etc/spwd.db: Permission denied *** [install-etc-files] Error code 1 1 error Kind regards -- Matthias Scheler http://zhadum.org.uk/