CVS commit: src/sys/arch/hppa/gsc
Module Name:src
Committed By: gutteridge
Date: Sun May 15 00:25:15 UTC 2022
Modified Files:
src/sys/arch/hppa/gsc: harmony.c
Log Message:
harmony.c: expand and correct a couple of comments
To generate a diff of this commit:
cvs rdiff -u -r1.10 -r1.11 src/sys/arch/hppa/gsc/harmony.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
Index: src/sys/arch/hppa/gsc/harmony.c
diff -u src/sys/arch/hppa/gsc/harmony.c:1.10 src/sys/arch/hppa/gsc/harmony.c:1.11
--- src/sys/arch/hppa/gsc/harmony.c:1.10 Thu Feb 4 15:08:44 2021
+++ src/sys/arch/hppa/gsc/harmony.c Sun May 15 00:25:15 2022
@@ -1,4 +1,4 @@
-/* $NetBSD: harmony.c,v 1.10 2021/02/04 15:08:44 isaki Exp $ */
+/* $NetBSD: harmony.c,v 1.11 2022/05/15 00:25:15 gutteridge Exp $ */
/* $OpenBSD: harmony.c,v 1.23 2004/02/13 21:28:19 mickey Exp $ */
@@ -136,7 +136,10 @@ const struct audio_hw_if harmony_sa_hw_i
.get_locks = harmony_get_locks,
};
-/* The HW actually supports more frequencies, but these looks enough. */
+/*
+ * The HW actually supports more frequencies, but these are the standard ones.
+ * For the full list, see the definition of harmony_speeds below.
+ */
#define HARMONY_FORMAT(enc, prec) \
{ \
.mode = AUMODE_PLAY | AUMODE_RECORD, \
@@ -343,7 +346,7 @@ harmony_reset_codec(struct harmony_softc
/* start reset */
WRITE_REG(sc, HARMONY_RESET, RESET_RST);
- DELAY(10); /* wait at least 0.05 sec */
+ DELAY(10); /* wait at least 0.1 sec */
harmony_set_gainctl(sc);
WRITE_REG(sc, HARMONY_RESET, 0);
CVS commit: src/sys/arch/hppa/gsc
Module Name:src Committed By: gutteridge Date: Sun May 15 00:25:15 UTC 2022 Modified Files: src/sys/arch/hppa/gsc: harmony.c Log Message: harmony.c: expand and correct a couple of comments To generate a diff of this commit: cvs rdiff -u -r1.10 -r1.11 src/sys/arch/hppa/gsc/harmony.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
Re: CVS commit: src/sys/arch/hppa/gsc
Hello, On Fri, 05 Feb 2021 00:12:35 +0900 Tetsuya Isaki wrote: > At Wed, 3 Feb 2021 13:37:24 -0500, > Michael wrote: > > > Committed By: isaki > > > Date: Wed Feb 3 15:13:49 UTC 2021 > > > > > > Modified Files: > > > src/sys/arch/hppa/gsc: harmony.c > > > > > > Log Message: > > > Fix locking against myself. > > > trigger_output will be called with sc_intr_lock held. > > > From source code review, not tested. > > > > I just tested this on my C200 - playback works. > > Thank you for quick response! > > > The sample rate seems off - everything plays too slow, but that's > > probably completely unrelated. > > Oops, this was my mistake. > I hope that harmony.c,v 1.9 will fix this problem. Works perfectly now, thank you! have fun Michael
Re: CVS commit: src/sys/arch/hppa/gsc
Hello, At Wed, 3 Feb 2021 13:37:24 -0500, Michael wrote: > > Committed By: isaki > > Date: Wed Feb 3 15:13:49 UTC 2021 > > > > Modified Files: > > src/sys/arch/hppa/gsc: harmony.c > > > > Log Message: > > Fix locking against myself. > > trigger_output will be called with sc_intr_lock held. > > From source code review, not tested. > > I just tested this on my C200 - playback works. Thank you for quick response! > The sample rate seems off - everything plays too slow, but that's > probably completely unrelated. Oops, this was my mistake. I hope that harmony.c,v 1.9 will fix this problem. Sorry for breaking it. --- Tetsuya Isaki
Re: CVS commit: src/sys/arch/hppa/gsc
Hello, On Wed, 3 Feb 2021 15:13:49 + "Tetsuya Isaki" wrote: > Module Name: src > Committed By: isaki > Date: Wed Feb 3 15:13:49 UTC 2021 > > Modified Files: > src/sys/arch/hppa/gsc: harmony.c > > Log Message: > Fix locking against myself. > trigger_output will be called with sc_intr_lock held. > From source code review, not tested. I just tested this on my C200 - playback works. The sample rate seems off - everything plays too slow, but that's probably completely unrelated. have fun Michael
