Re: CVS commit: src/sys/arch/x86/include
On Sun, 15 Jul 2018, Paul Goyette wrote: Any chance that this will fix kern/52919? If not, can we do some additional re-arrangement of struct cpu_info to address the problem? And in any case, shouldn't this cause a bump in kernel version, since you've changed a structure that is shared between kernel and modules? :) Modified Files: src/sys/arch/x86/include: cpu.h Log Message: Hum. Move the __HAVE_DIRECT_MAP block a little below, otherwise dynamically loaded kernel modules use a wrong offset for some ci_* fields. Found when modloading tprof_amd on an AMD 10h, the read of ci_signature was at a wrong address, and the cpu family was not detected correctly. +--+--++ | Paul Goyette | PGP Key fingerprint: | E-mail addresses: | | (Retired)| FA29 0E3B 35AF E8AE 6651 | paul at whooppee dot com | | Kernel Developer | 0786 F758 55DE 53BA 7731 | pgoyette at netbsd dot org | +--+--++
Re: CVS commit: src/sys/arch/x86/include
Any chance that this will fix kern/52919? If not, can we do some additional re-arrangement of struct cpu_info to address the problem? On Sun, 15 Jul 2018, Maxime Villard wrote: Module Name:src Committed By: maxv Date: Sun Jul 15 08:47:43 UTC 2018 Modified Files: src/sys/arch/x86/include: cpu.h Log Message: Hum. Move the __HAVE_DIRECT_MAP block a little below, otherwise dynamically loaded kernel modules use a wrong offset for some ci_* fields. Found when modloading tprof_amd on an AMD 10h, the read of ci_signature was at a wrong address, and the cpu family was not detected correctly. To generate a diff of this commit: cvs rdiff -u -r1.94 -r1.95 src/sys/arch/x86/include/cpu.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. !DSPAM:5b4b0a35163311665672011! +--+--++ | Paul Goyette | PGP Key fingerprint: | E-mail addresses: | | (Retired)| FA29 0E3B 35AF E8AE 6651 | paul at whooppee dot com | | Kernel Developer | 0786 F758 55DE 53BA 7731 | pgoyette at netbsd dot org | +--+--++
Re: CVS commit: src/sys/arch/x86/include
Le 29/09/2017 à 05:17, Ryota Ozaki a écrit : Module Name:src Committed By: ozaki-r Date: Fri Sep 29 03:17:18 UTC 2017 Modified Files: src/sys/arch/x86/include: pmap.h Log Message: Fix build sys/arch/x86/x86/cpu.c:920:20: error: 'pmap_largepages' undeclared (first use in this function) smp_data.large = (pmap_largepages != 0); ^ To generate a diff of this commit: cvs rdiff -u -r1.67 -r1.68 src/sys/arch/x86/include/pmap.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. mmh yes, I patched my test machine but apparently didn't commit the updated diff
Re: CVS commit: src/sys/arch/x86/include
(2013/11/21 15:02), matthew green wrote: >> Module Name: src >> Committed By:msaitoh >> Date:Wed Nov 20 17:50:39 UTC 2013 >> >> Modified Files: >> src/sys/arch/x86/include: specialreg.h >> >> Log Message: >> - Add some AMD Fn8001 extended features %ecx bits definitions from >> the document (AMD64 Architecture Programmer's Manual Volume 3: >> General-Purpose and >> System Instructions. Document revision 3.20) >> >> - "s/MXX/MMXX/" because this bit is "MMX eXtention". > > i thought it was Multi Media eXtension. MMX: Fn0001 %edx bit 23 (Intel and AMD) Fn8001 %edx bit 23 (Same as Fn0001 %edx, AMD only) AMD MMX Extension: Fn8001 %edx bit 22 (AMD extensions to MMX instruction, AMD Only) See Pase 580 in AMD64 Architecture Programmer's manual Volume 3 revision 3.20 :) -- --- SAITOH Masanobu (msai...@execsw.org msai...@netbsd.org)
re: CVS commit: src/sys/arch/x86/include
> Module Name: src > Committed By: msaitoh > Date: Wed Nov 20 17:50:39 UTC 2013 > > Modified Files: > src/sys/arch/x86/include: specialreg.h > > Log Message: > - Add some AMD Fn8001 extended features %ecx bits definitions from > the document (AMD64 Architecture ProgrammerVolume 3: General-Purpose and > System Instructions. Document revision 3.20) > > - "s/MXX/MMXX/" because this bit is "MMX eXtention". i thought it was Multi Media eXtension.
Re: CVS commit: src/sys/arch/x86/include
Le 05/05/12 17:08, Jean-Yves Migeon a écrit : Module Name:src Committed By: jym Date: Sat May 5 15:08:29 UTC 2012 Modified Files: src/sys/arch/x86/include: specialreg.h Log Message: Add latest CR4 bits: [snip] From Intel® 64 and IA-32 Architectures Software Developer’s Manual, March 2012. Align declarations. CPUID_* bits for these features follow. Sorry, I was not very clear: the CPUID feature flags follow these declarations, ie. they are already present in headers (and can be used to check the feature's availability). CR4 values can be used to enable them when needed. -- Jean-Yves Migeon jeanyves.mig...@free.fr
Re: CVS commit: src/sys/arch/x86/include
On 18.09.10 17:49, Jonathan A. Kollasch wrote: > Module Name: src > Committed By: jakllsch > Date: Sat Sep 18 15:49:26 UTC 2010 > > Modified Files: > src/sys/arch/x86/include: specialreg.h > > Log Message: > AMD publication 25759 rev 3.69 says that DisIOReqLock in NB_CFG is "bit 3". > They probably mean "bit 3" and not "the third bit" (or bit 2). > This change should prevent superfluous warnings of errata 89. Correct. AMD manuals starting counting with 0. So bit 0 is "the first bit". Christoph
Re: CVS commit: src/sys/arch/x86/include
On Wed, Mar 25, 2009 at 10:54:57PM +, David Young wrote: > Module Name: src > Committed By: dyoung > Date: Wed Mar 25 22:54:57 UTC 2009 > > Modified Files: > src/sys/arch/x86/include: intr.h > > Log Message: > It is only by accident that this gets the definitions it needs from > , so explicitly #include . These probably don't need to be exported to the kernel, they could be hidden with __X86_PRIVATE or something. Auto inclusion of sys/device.h and sys/atomic.h on x86 also leads to the occasional build break. JFYI. Thanks for looking at this.
