Re: CVS commit: src/sys/dev/gpio
Shouldn't we also add a dependency from the gpio module to require the sysmon_taskq module? On Thu, 15 Oct 2015, Jared D. McNeill wrote: Module Name:src Committed By: jmcneill Date: Thu Oct 15 09:07:49 UTC 2015 Modified Files: src/sys/dev/gpio: files.gpio Log Message: pull in sysmon_taskq To generate a diff of this commit: cvs rdiff -u -r1.13 -r1.14 src/sys/dev/gpio/files.gpio Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. +--+--+-+ | Paul Goyette | PGP Key fingerprint: | E-mail addresses: | | (Retired)| FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com| | Kernel Developer | 0786 F758 55DE 53BA 7731 | pgoyette at netbsd.org | +--+--+-+
Re: CVS commit: src/sys/dev/gpio
I should have been more clear in the commit message -- I added the dependency on gpiobutton(4), not gpio(4). On Fri, 16 Oct 2015, Paul Goyette wrote: Date: Fri, 16 Oct 2015 15:47:43 +0800 (PHT) From: Paul Goyette <p...@vps1.whooppee.com> Reply-To: p...@whooppee.com To: source-changes-d@NetBSD.org Cc: Jared D. McNeill <jmcne...@netbsd.org> Subject: Re: CVS commit: src/sys/dev/gpio Shouldn't we also add a dependency from the gpio module to require the sysmon_taskq module? On Thu, 15 Oct 2015, Jared D. McNeill wrote: Module Name:src Committed By: jmcneill Date: Thu Oct 15 09:07:49 UTC 2015 Modified Files: src/sys/dev/gpio: files.gpio Log Message: pull in sysmon_taskq To generate a diff of this commit: cvs rdiff -u -r1.13 -r1.14 src/sys/dev/gpio/files.gpio Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. +--+--+-+ | Paul Goyette | PGP Key fingerprint: | E-mail addresses: | | (Retired)| FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com| | Kernel Developer | 0786 F758 55DE 53BA 7731 | pgoyette at netbsd.org | +--+--+-+
Re: CVS commit: src/sys/dev/gpio
Arnaud Lacombe lacom...@gmail.com writes: On Sun, Jul 26, 2009 at 5:26 PM, matthew greenm...@eterna.com.au wrote: incidentially, i actually did object to this change on ICB last night but i was off to bed and didn't feel like arguing at the time. i didn't expect to see it commited straight away. so marc's claim that it did not get any objections is infact not entirely right. OOTH, it's not like the code in question was already heavily used: -/* $NetBSD: gpiosim.c,v 1.1 2009/07/25 16:17:10 mbalmer Exp $ */ +/* $NetBSD: gpiosim.c,v 1.2 2009/07/26 13:45:20 mbalmer Exp $ */ And in addition to being less than 24 hours old, the code was his own code. The clear de facto rule is that you can change code you wrote and own with a lot less approval, even for a new developer, than other stuff requires. I'm equally upset that Tonnerre sent him a public rebuke. He could have said, in private, hey, thanks for the enthusiasm, though FYI, you should still be checking stuff with your mentors -- but instead he was very cold about it and did it in public. Neither of those is acceptable. I join perry@ on this thread, and chritos@ too as this should have been privately discussed. Violent agreement all around. Perry -- Perry E. Metzgerpe...@piermont.com
Re: CVS commit: src/sys/dev/gpio
Hi Perry, On Mon, Jul 27, 2009 at 1:41 PM, Perry E. Metzgerpe...@piermont.com wrote: And in addition to being less than 24 hours old, the code was his own code. The clear de facto rule is that you can change code you wrote and own with a lot less approval, even for a new developer, than other stuff requires. As you comment on this, let me put my original comment on hold. There has been only a few hours (~6) between Marc's update and the first commit. I'm not sure I should have commented on this. - Arnaud
Re: CVS commit: src/sys/dev/gpio
On Mon, Jul 27, 2009 at 2:01 PM, Perry E. Metzgerpe...@piermont.com wrote: Eh, if we make it too hard to commit to code under active development, people won't actively develop. Marc has also shown that he's willing to make reasonable changes when improvements are pointed out to him. That's why I _just_ put my comment on hold. My main problem is with the gpiosim(4) interface, which I find is a bit overkill for the intended purpose and not documented. But I can hardly comment anymore as the diff are no longer available. - Arnaud
Re: CVS commit: src/sys/dev/gpio
Arnaud Lacombe lacom...@gmail.com writes: On Mon, Jul 27, 2009 at 1:41 PM, Perry E. Metzgerpe...@piermont.com wrote: And in addition to being less than 24 hours old, the code was his own code. The clear de facto rule is that you can change code you wrote and own with a lot less approval, even for a new developer, than other stuff requires. As you comment on this, let me put my original comment on hold. There has been only a few hours (~6) between Marc's update and the first commit. I'm not sure I should have commented on this. Eh, if we make it too hard to commit to code under active development, people won't actively develop. Marc has also shown that he's willing to make reasonable changes when improvements are pointed out to him. In the end, if we're more concerned about strict rules than code we'll get more strict rules than code. Perry -- Perry E. Metzgerpe...@piermont.com
Re: CVS commit: src/sys/dev/gpio
Tonnerre LOMBARD tonne...@netbsd.ch writes: I am somehow missing an approved by: in this commit message. Whose approval did you get? It was discussed on ICB and no one really objected after the name was changed. While you're still a newdev, please get approval from a specific person before you commit changes. I don't think the change was unreasonable or required more approval than Marc already got. Perry -- Perry E. Metzgerpe...@piermont.com
Re: CVS commit: src/sys/dev/gpio
Salut, On Sun, Jul 26, 2009 at 12:14:28PM -0400, Perry E. Metzger wrote: While you're still a newdev, please get approval from a specific person before you commit changes. I don't think the change was unreasonable or required more approval than Marc already got. Since it changes the way gpiosim works, and since mbalmer is currently in newdev status, it should not be unreasonable to ask him to add the approved-by lines. But of course you might want to change those rules, they are somewhere under localsrc I think. Tonnerre pgpDDfgQY8Ufo.pgp Description: PGP signature
Re: CVS commit: src/sys/dev/gpio
Salut, On Sun, Jul 26, 2009 at 12:48:06PM -0400, Perry E. Metzger wrote: That's another thing: quit being so rude to a new developer. Even if it was bad for him to do this commit, it would be unreasonable to tell him off so impolitely. I'd prefer of you left this judgment to him and me. Tonnerre pgpJ80hTd277s.pgp Description: PGP signature
Re: CVS commit: src/sys/dev/gpio
In article 87ws5vmk70@snark.cb.piermont.com, Perry E. Metzger pe...@piermont.com wrote: Tonnerre LOMBARD tonne...@netbsd.ch writes: On Sun, Jul 26, 2009 at 12:48:06PM -0400, Perry E. Metzger wrote: That's another thing: quit being so rude to a new developer. Even if it was bad for him to do this commit, it would be unreasonable to tell him off so impolitely. I'd prefer of you left this judgment to him and me. I'm afraid that is not a reasonable request. I do not care who is right or wrong here, this is becoming a pissing competition. Things like these are better handled with personal e-mail and escallating through the proper channels rather than public floggings. We would like to foster a friendly environment here, not one where people are afraid to commit code because they will be yelled at. christos
