re: CVS commit: src/sys/external/bsd/drm/dist/bsd-core

2022-03-18 Thread matthew green
> Log Message:
> old drm: Use getticks(), not hardclock_ticks.
>
> Should delete this code, no idea if it even still compiles.

it did last i tried, and it still worked on the r100/r200 systems
that new drm is still problematic with.

not objecting...


.mrg.


Re: CVS commit: src/sys/external/bsd/drm/dist/bsd-core

2012-01-29 Thread Matthias Drochner

lars.heidie...@googlemail.com said:
> where does the diagnostic panic occur?

It was in the course of a realloc() from drm code. It did
apparently assume that the to be free'd block was allocated
by the pool code where it was allocated by kmem.

best regards
Matthias



---
---
Forschungszentrum Juelich GmbH
52425 Juelich
Sitz der Gesellschaft: Juelich
Eingetragen im Handelsregister des Amtsgerichts Dueren Nr. HR B 3498
Vorsitzender des Aufsichtsrats: MinDir Dr. Karl Eugen Huthmacher
Geschaeftsfuehrung: Prof. Dr. Achim Bachem (Vorsitzender),
Karsten Beneke (stellv. Vorsitzender), Prof. Dr.-Ing. Harald Bolt,
Prof. Dr. Sebastian M. Schmidt
---
---

Kennen Sie schon unsere app? http://www.fz-juelich.de/app


Re: CVS commit: src/sys/external/bsd/drm/dist/bsd-core

2012-01-29 Thread Lars Heidieker
we should fix the inconsistent use then, the problem ist malloc(9)
does not return page aligned memory as kmem does now, for allocations
>= PAGE_SIZE and that break drm mmap

where does the diagnostic panic occur?

lars

On Sun, Jan 29, 2012 at 12:49 PM, Matthias Drochner  wrote:
> Module Name:    src
> Committed By:   drochner
> Date:           Sun Jan 29 11:49:02 UTC 2012
>
> Modified Files:
>        src/sys/external/bsd/drm/dist/bsd-core: drm_bufs.c
>
> Log Message:
> remove incomplete conversion to kmem_alloc -- inconsistent use
> leads at least to diagnostic panics
>
>
> To generate a diff of this commit:
> cvs rdiff -u -r1.9 -r1.10 src/sys/external/bsd/drm/dist/bsd-core/drm_bufs.c
>
> Please note that diffs are not public domain; they are subject to the
> copyright notices on the relevant files.
>


Re: CVS commit: src/sys/external/bsd/drm/dist/bsd-core

2011-02-20 Thread David Holland
On Fri, Feb 18, 2011 at 08:30:04AM +0100, Christoph Egger wrote:
 > > the new code matches the linux drm driver.
 > 
 > ok. IIRC there is a PR with a patch that adds an entry for HD4250
 > which can be closed now.

I can't find such a PR - the only open PRs that contain both "radeon"
and "pcidevs" are 39580 and 40987, which are both about other models.

(both those PRs should be easy to commit and close if anyone wants to
take a few minutes to crosscheck that the IDs are correct)

-- 
David A. Holland
dholl...@netbsd.org


Re: CVS commit: src/sys/external/bsd/drm/dist/bsd-core

2011-02-17 Thread Christoph Egger
On 18.02.11 07:00, matthew green wrote:
>>> -   {0x1002, 0x9712, 
>>> CHIP_RV620|RADEON_IS_MOBILITY|RADEON_NEW_MEMMAP|RADEON_IS_IGP, "ATI Radeon 
>>> Mobility HD 4200"}, \
>>> +   {0x1002, 0x9710, CHIP_RS880|RADEON_NEW_MEMMAP|RADEON_IS_IGP, "ATI 
>>> Radeon HD 4200"}, \
>>> +   {0x1002, 0x9711, CHIP_RS880|RADEON_NEW_MEMMAP|RADEON_IS_IGP, "ATI 
>>> Radeon RS880"}, \
>>> +   {0x1002, 0x9712, 
>>> CHIP_RS880|RADEON_IS_MOBILITY|RADEON_NEW_MEMMAP|RADEON_IS_IGP, "ATI Radeon 
>>> Mobility HD 4200"}, \
>>> +   {0x1002, 0x9713, 
>>> CHIP_RS880|RADEON_IS_MOBILITY|RADEON_NEW_MEMMAP|RADEON_IS_IGP, "ATI Radeon 
>>> Mobility RS880"}, \
>>> +   {0x1002, 0x9714, CHIP_RS880|RADEON_NEW_MEMMAP|RADEON_IS_IGP, "ATI 
>>> Radeon HD 4290"}, \
>>> +   {0x1002, 0x9715, CHIP_RS880|RADEON_NEW_MEMMAP|RADEON_IS_IGP, "ATI 
>>> Radeon HD 4250"}, \
>>> {0, 0, 0, NULL}
>>
>> Are you sure some of them aren't actually RS780 chips ?
> 
> the new code matches the linux drm driver.

ok. IIRC there is a PR with a patch that adds an entry for HD4250
which can be closed now.

Christoph


re: CVS commit: src/sys/external/bsd/drm/dist/bsd-core

2011-02-17 Thread matthew green

> > -   {0x1002, 0x9712, 
> > CHIP_RV620|RADEON_IS_MOBILITY|RADEON_NEW_MEMMAP|RADEON_IS_IGP, "ATI Radeon 
> > Mobility HD 4200"}, \
> > +   {0x1002, 0x9710, CHIP_RS880|RADEON_NEW_MEMMAP|RADEON_IS_IGP, "ATI 
> > Radeon HD 4200"}, \
> > +   {0x1002, 0x9711, CHIP_RS880|RADEON_NEW_MEMMAP|RADEON_IS_IGP, "ATI 
> > Radeon RS880"}, \
> > +   {0x1002, 0x9712, 
> > CHIP_RS880|RADEON_IS_MOBILITY|RADEON_NEW_MEMMAP|RADEON_IS_IGP, "ATI Radeon 
> > Mobility HD 4200"}, \
> > +   {0x1002, 0x9713, 
> > CHIP_RS880|RADEON_IS_MOBILITY|RADEON_NEW_MEMMAP|RADEON_IS_IGP, "ATI Radeon 
> > Mobility RS880"}, \
> > +   {0x1002, 0x9714, CHIP_RS880|RADEON_NEW_MEMMAP|RADEON_IS_IGP, "ATI 
> > Radeon HD 4290"}, \
> > +   {0x1002, 0x9715, CHIP_RS880|RADEON_NEW_MEMMAP|RADEON_IS_IGP, "ATI 
> > Radeon HD 4250"}, \
> > {0, 0, 0, NULL}
> 
> Are you sure some of them aren't actually RS780 chips ?

the new code matches the linux drm driver.


.mrg.


Re: CVS commit: src/sys/external/bsd/drm/dist/bsd-core

2011-02-17 Thread Christoph Egger
On 18.02.11 00:21, Jonathan A. Kollasch wrote:
> Module Name:  src
> Committed By: jakllsch
> Date: Thu Feb 17 23:21:54 UTC 2011
> 
> Modified Files:
>   src/sys/external/bsd/drm/dist/bsd-core: drm_pciids.h
> 
> Log Message:
> Add the RS880 device IDs to radeondrm(4).
> 
> 
> To generate a diff of this commit:
> cvs rdiff -u -r1.5 -r1.6 src/sys/external/bsd/drm/dist/bsd-core/drm_pciids.h
> 
> Please note that diffs are not public domain; they are subject to the
> copyright notices on the relevant files.
> 
> 
> 
> 
> Modified files:
> 
> Index: src/sys/external/bsd/drm/dist/bsd-core/drm_pciids.h
> diff -u src/sys/external/bsd/drm/dist/bsd-core/drm_pciids.h:1.5 
> src/sys/external/bsd/drm/dist/bsd-core/drm_pciids.h:1.6
> --- src/sys/external/bsd/drm/dist/bsd-core/drm_pciids.h:1.5   Thu Jan  6 
> 11:07:48 2011
> +++ src/sys/external/bsd/drm/dist/bsd-core/drm_pciids.h   Thu Feb 17 
> 23:21:53 2011
> @@ -393,7 +393,12 @@
>   {0x1002, 0x9552, CHIP_RV710|RADEON_IS_MOBILITY|RADEON_NEW_MEMMAP, "ATI 
> Mobility Radeon 4300 Series"}, \
>   {0x1002, 0x9553, CHIP_RV710|RADEON_IS_MOBILITY|RADEON_NEW_MEMMAP, "ATI 
> Mobility Radeon 4500 Series"}, \
>   {0x1002, 0x9555, CHIP_RV710|RADEON_IS_MOBILITY|RADEON_NEW_MEMMAP, "ATI 
> Mobility Radeon 4500 Series"}, \
> - {0x1002, 0x9712, 
> CHIP_RV620|RADEON_IS_MOBILITY|RADEON_NEW_MEMMAP|RADEON_IS_IGP, "ATI Radeon 
> Mobility HD 4200"}, \
> + {0x1002, 0x9710, CHIP_RS880|RADEON_NEW_MEMMAP|RADEON_IS_IGP, "ATI 
> Radeon HD 4200"}, \
> + {0x1002, 0x9711, CHIP_RS880|RADEON_NEW_MEMMAP|RADEON_IS_IGP, "ATI 
> Radeon RS880"}, \
> + {0x1002, 0x9712, 
> CHIP_RS880|RADEON_IS_MOBILITY|RADEON_NEW_MEMMAP|RADEON_IS_IGP, "ATI Radeon 
> Mobility HD 4200"}, \
> + {0x1002, 0x9713, 
> CHIP_RS880|RADEON_IS_MOBILITY|RADEON_NEW_MEMMAP|RADEON_IS_IGP, "ATI Radeon 
> Mobility RS880"}, \
> + {0x1002, 0x9714, CHIP_RS880|RADEON_NEW_MEMMAP|RADEON_IS_IGP, "ATI 
> Radeon HD 4290"}, \
> + {0x1002, 0x9715, CHIP_RS880|RADEON_NEW_MEMMAP|RADEON_IS_IGP, "ATI 
> Radeon HD 4250"}, \
>   {0, 0, 0, NULL}

Are you sure some of them aren't actually RS780 chips ?

Christoph


>  
>  #define r128_PCI_IDS \
> 



Re: CVS commit: src/sys/external/bsd/drm/dist/bsd-core

2009-12-13 Thread David Young
On Sun, Dec 13, 2009 at 09:04:11AM +1100, matthew green wrote:
>Log Message:
>add stub pmf hook
> 
> shouldn't a driver that schedules DMA have something more than a NULL
> handler for these?  this seems dangerous to me..

Yes, such a driver should have a genuine suspend/resume handler.  Please
add proper handlers.

Dave

-- 
David Young OJC Technologies
dyo...@ojctech.com  Urbana, IL * (217) 278-3933


re: CVS commit: src/sys/external/bsd/drm/dist/bsd-core

2009-12-12 Thread matthew green

   Module Name: src
   Committed By:kefren
   Date:Sat Dec 12 14:15:25 UTC 2009
   
   Modified Files:
src/sys/external/bsd/drm/dist/bsd-core: radeon_drv.c
   
   Log Message:
   add stub pmf hook

shouldn't a driver that schedules DMA have something more than a NULL
handler for these?  this seems dangerous to me..


.mrg.