Re: CVS commit: xsrc/external/mit/xdm/dist/xdm

2013-10-18 Thread Alan Barrett 

On Fri, 18 Oct 2013, Jukka Ruohonen wrote:

Print time_t values by casting to intmax_t and using "%ji" format.


Wouldn't the "right" way be PRIdMAX from inttypes(3)?  Anyways, 
for curiosity: is there actually a portable way across operating 
systems to deal with this?


The "j" modifier is defined in the C99 standard, and that's good 
enough for me.  PRIdMAX would also work, but is more verbose.


I suppose some operating systems might exist where "%jd" doesn't 
work but "%"PRIdMAX does work, and if this was the xorg project 
instead of the NetBSD project then I might care about that.


--apb (Alan Barrett)

Re: CVS commit: xsrc/external/mit/xdm/dist/xdm

2013-10-18 Thread Alan Barrett 

On Fri, 18 Oct 2013, Christos Zoulas wrote:

The result from strlen() has type size_t, so print it with "%zd" format.

%zu is correct.


Fixed, thanks.

Re: CVS commit: xsrc/external/mit/xdm/dist/xdm

2013-10-18 Thread Jukka Ruohonen 
On Fri, Oct 18, 2013 at 03:59:38PM +, Alan Barrett wrote:
> Module Name:  xsrc
> Committed By: apb
> Date: Fri Oct 18 15:59:38 UTC 2013
> 
> Modified Files:
>   xsrc/external/mit/xdm/dist/xdm: dm.c
> 
> Log Message:
> Print time_t values by casting to intmax_t and using "%ji" format.

Wouldn't the "right" way be PRIdMAX from inttypes(3)? Anyways, 
for curiosity: is there actually a portable way across operating 
systems to deal with this?

- Jukka.

Re: CVS commit: xsrc/external/mit/xdm/dist/xdm

2013-10-18 Thread Christos Zoulas 
In article <20131018163140.a391...@cvs.netbsd.org>,
Alan Barrett  wrote:
>-=-=-=-=-=-
>
>Module Name:   xsrc
>Committed By:  apb
>Date:  Fri Oct 18 16:31:40 UTC 2013
>
>Modified Files:
>   xsrc/external/mit/xdm/dist/xdm: xdmauth.c
>
>Log Message:
>The result from strlen() has type size_t, so print it with "%zd" format.

%zu is correct.

christos