Re: acpiec bus tag (was Re: CVS commit: src/sys/dev)
On Fri, Mar 26, 2010 at 07:57:56PM +0200, Jukka Ruohonen wrote: > On Fri, Mar 26, 2010 at 12:50:38PM -0500, David Young wrote: > > It used to be definitely incorrect. So we're making progress. Do you > > have any idea how to make it definitely correct? > > Sorry: I misread the patch originally. It should not affect the > functionality. The NULL pointer dereference is a real bug though. I just fixed the NULL dereference: cvs rdiff -u -r1.162 -r1.163 src/sys/dev/acpi/acpi.c cvs rdiff -u -r1.63 -r1.64 src/sys/dev/acpi/acpi_ec.c Dave -- David Young OJC Technologies dyo...@ojctech.com Urbana, IL * (217) 278-3933
Re: acpiec bus tag (was Re: CVS commit: src/sys/dev)
On Fri, Mar 26, 2010 at 12:50:38PM -0500, David Young wrote: > It used to be definitely incorrect. So we're making progress. Do you > have any idea how to make it definitely correct? Sorry: I misread the patch originally. It should not affect the functionality. The NULL pointer dereference is a real bug though. - Jukka.
acpiec bus tag (was Re: CVS commit: src/sys/dev)
On Fri, Mar 26, 2010 at 07:26:01AM +0200, Jukka Ruohonen wrote: > On Wed, Mar 24, 2010 at 01:13:30AM +, David Young wrote: > > Module Name:src > > Committed By: dyoung > > Date: Wed Mar 24 01:13:30 UTC 2010 > > > > Modified Files: > > src/sys/dev/acpi: acpi_ec.c > > src/sys/dev/isa: pas.c > > > > Log Message: > > Do not use unitialized bus_space_tag_t's. Use the tag(s) from the > > attachment arguments. > > > > > > To generate a diff of this commit: > > cvs rdiff -u -r1.62 -r1.63 src/sys/dev/acpi/acpi_ec.c > > cvs rdiff -u -r1.67 -r1.68 src/sys/dev/isa/pas.c > > ... and: this also fundamentally alters the behavior of acpiec(4) in a way > that is likely to be incorrect. It used to be definitely incorrect. So we're making progress. Do you have any idea how to make it definitely correct? Dave -- David Young OJC Technologies dyo...@ojctech.com Urbana, IL * (217) 278-3933
