Re: CVS commit: src/lib/libc
On 07.01.2018 00:42, Joerg Sonnenberger wrote: > On Fri, Jan 05, 2018 at 08:01:32PM +, Kamil Rytarowski wrote: >> Module Name: src >> Committed By:kamil >> Date:Fri Jan 5 20:01:32 UTC 2018 >> >> Modified Files: >> src/lib/libc/include: namespace.h >> src/lib/libc/time: asctime.c >> >> Log Message: >> Register new weak symbol in libc for internal usage: asctime > > Please revert this. It is plainly wrong. > > Joerg > I will check this case (whether my understanding and rationale is correct) with the sanitizer developers and be back to this, on a public mailing list (tech-userlevel). signature.asc Description: OpenPGP digital signature
Re: CVS commit: src/lib/libc/include
On Fri, Jan 05, 2018 at 06:57:06PM +, Kamil Rytarowski wrote: > Module Name: src > Committed By: kamil > Date: Fri Jan 5 18:57:06 UTC 2018 > > Modified Files: > src/lib/libc/include: namespace.h > > Log Message: > Register more syscalls in namespace.h (of libc) > > Add weak symbols for: > - fcntl > - close > - execve > - setcontext > - wait6 > - write > - writev Most of those are standard library calls. They should not be weak unless they are also a cancellation point. Joerg
Re: CVS commit: src/lib/libc
On Fri, Jan 05, 2018 at 08:01:32PM +, Kamil Rytarowski wrote: > Module Name: src > Committed By: kamil > Date: Fri Jan 5 20:01:32 UTC 2018 > > Modified Files: > src/lib/libc/include: namespace.h > src/lib/libc/time: asctime.c > > Log Message: > Register new weak symbol in libc for internal usage: asctime Please revert this. It is plainly wrong. Joerg
Re: CVS commit: src
On Fri, Jan 05, 2018 at 08:30:51PM +, Kamil Rytarowski wrote: > Module Name: src > Committed By: kamil > Date: Fri Jan 5 20:30:51 UTC 2018 > > Modified Files: > src/lib/libc/include: namespace.h > src/lib/libc/stdlib: atoi.c > src/sys/external/bsd/compiler_rt/dist/lib/profile: InstrProfilingFile.c > > Log Message: > Register new weak symbol in libc for internal usage: atoi Please revert this. It is plainly wrong. Joerg
Re: CVS commit: src/lib/libc/include
On 07.01.2018 00:41, Joerg Sonnenberger wrote: > On Fri, Jan 05, 2018 at 06:57:06PM +, Kamil Rytarowski wrote: >> Module Name: src >> Committed By:kamil >> Date:Fri Jan 5 18:57:06 UTC 2018 >> >> Modified Files: >> src/lib/libc/include: namespace.h >> >> Log Message: >> Register more syscalls in namespace.h (of libc) >> >> Add weak symbols for: >> - fcntl >> - close >> - execve >> - setcontext >> - wait6 >> - write >> - writev > > Most of those are standard library calls. They should not be weak unless > they are also a cancellation point. > > Joerg > I had a different goal of marking them weak. But looking at the specs about the cancellation point functions I can read the following: "Cancellation points shall occur when a thread is executing the following functions:" fcntl, close, related to wait6 (wait, waitpid, waitid), write, writev From the another commit about asctime: "A cancellation point may also occur when a thread is executing the following functions:" asctime() http://pubs.opengroup.org/onlinepubs/009695399/functions/xsh_chap02_09.html signature.asc Description: OpenPGP digital signature
