Re: [Spacewalk-devel] spacecmd wrapper "staging" scripts on github : RFC re inclusion in spacewalk?
On Tue, Apr 24, 2012 at 03:29:13PM +0200, Miroslav Suchý wrote: > On 04/24/2012 12:18 PM, Steven Hardy wrote: > >Also wondering if there's any interest in including these (and other similar > >scripts) in spacewalk, either as part of the spacecmd package, say > >under/usr/share/spacecmd/scripts/, or in some other package? > > We have > /utils/ > where goes scripts which can be useful for lots of people, and which > are clean and commiter is willing to maintain it. This is packaged > as spacewalk-utils, so you have to care about Requires in .spec. > > Then we have > /scripts/ > which is not packaged, so has lower barrier to entry. But still - > please do not put there every script which has "spacewalk" somewhere > in code. So looking at what is currently in scripts and utils, I propose these as candidates for inclusion in the scripts area. Any review welcomed - if you give me the OK to commit them, I could create a scripts/clone_release_scripts directory containing these scripts. Most of these scripts are (IMHO) fairly clean, somewhat proven, and purely make use of spacewalk-specific tools (99% spacecmd). However they do implement a pre-defined policy/workflow, and hence are not configurable "utilities" like most of the tools under /utils appear to be. I'm hoping getting them "out there" may provide some feedback/testing/enhancements from others with a requirement for a similar workflow, whilst also providing some good usage examples of many spacecmd features. Steve ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
[Spacewalk-devel] [PATCH] fixes for system that needs reboot feature
- Move the notification to the last position, and make it appear even when other notifications are shown. - Missing icon - Capitalize the text of the title to be consistent with other pages >From f20edd99cf6b4862e77378d9018161f12417aef7 Mon Sep 17 00:00:00 2001 From: Duncan Mac-Vicar P Date: Tue, 24 Apr 2012 16:18:00 +0200 Subject: [PATCH 1/3] Put the reboot notification at the end. Make it not mutually exclusive with other notifications. --- .../webapp/WEB-INF/pages/systems/sdc/overview.jsp | 16 1 files changed, 12 insertions(+), 4 deletions(-) diff --git a/java/code/webapp/WEB-INF/pages/systems/sdc/overview.jsp b/java/code/webapp/WEB-INF/pages/systems/sdc/overview.jsp index d69645b..94eba0d 100644 --- a/java/code/webapp/WEB-INF/pages/systems/sdc/overview.jsp +++ b/java/code/webapp/WEB-INF/pages/systems/sdc/overview.jsp @@ -8,8 +8,10 @@ <%@ include file="/WEB-INF/pages/common/fragments/systems/system-header.jspf" %> + + @@ -22,10 +24,6 @@ - - - - @@ -54,6 +52,16 @@ + + + + + + + + + + -- 1.7.7 >From c3d2235f90001c953d32db9074a941d43fe78963 Mon Sep 17 00:00:00 2001 From: Duncan Mac-Vicar P Date: Fri, 20 Apr 2012 13:39:16 +0200 Subject: [PATCH 2/3] Missing icon for the systems that need reboot list --- branding/img/restart.png | Bin 0 -> 912 bytes 1 files changed, 0 insertions(+), 0 deletions(-) create mode 100644 branding/img/restart.png diff --git a/branding/img/restart.png b/branding/img/restart.png new file mode 100644 index ..3fd71d6e5929ba0c40db1960e36e9acba9d7e525 GIT binary patch literal 912 zcmV;B18@9^P)oWowDaEkzU!j%l38$)o7}}cCnx7z zVrKYAWwOsS=-Lqw-t?qu)r6QQ!notg696vQmg&~r9t3cLe1UW(yG7H)Ku^~yeO+g> z(bg0Jm{BNJFfw+(d}sQhCl&9uE%R)8S2n|p?*PPznUTt5*BiPR+1l3~ipPS`iO?Jk zARN#U4H*a;0yD)$9M29{3dM>Y4K?&WE>{g^G!Zl7)jelV^{i|AG#D_%trsJC8h7YDw+>Nu`!(E)&&KfE(t5U!_KF)uRXGsl%@ z#;0eK6ZhtiUhin`+P8I6C=m!d1ufk}o{_gOutKfI-_b^R{JP z`QzJ2^LHMWS&9G(o-t)@yh1Uq9cxfG6X$C)H~ghbOC7?WrZ-yyL0>0QOs`0x)U>uAAQg z>;&LGL0Gpf^PVr@oj>}%1`wDT7wv!4sq=s3q*Oh&WftpMhqGg=O68@F-$%x80Ep=T zKm-sG?*3PXAs8nI|0Dok)RR-0Y?z4d_HJBzCO6*s&6^5?o^0No>h2ra)My_p{u2^&LcltM%9%NL@3OcL;J5G-fbF(raxE|ez>From 2022e7821091986983e959adbf0457372d6a19e4 Mon Sep 17 00:00:00 2001 From: Duncan Mac-Vicar P Date: Tue, 24 Apr 2012 15:43:30 +0200 Subject: [PATCH 3/3] Capitalize title to be consistent --- .../frontend/strings/jsp/StringResource_en_US.xml |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/java/code/src/com/redhat/rhn/frontend/strings/jsp/StringResource_en_US.xml b/java/code/src/com/redhat/rhn/frontend/strings/jsp/StringResource_en_US.xml index e82b561..72e9d24 100644 --- a/java/code/src/com/redhat/rhn/frontend/strings/jsp/StringResource_en_US.xml +++ b/java/code/src/com/redhat/rhn/frontend/strings/jsp/StringResource_en_US.xml @@ -5062,7 +5062,7 @@ value for this entitlement, excluding the default organization's consumption. -Systems requiring reboot +Systems Requiring Reboot /rhn/systems/RequiringReboot /rhn/systems/YourRhn.do -- 1.7.7 ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] spacecmd wrapper "staging" scripts on github : RFC re inclusion in spacewalk?
On 04/24/2012 12:18 PM, Steven Hardy wrote: Also wondering if there's any interest in including these (and other similar scripts) in spacewalk, either as part of the spacecmd package, say under/usr/share/spacecmd/scripts/, or in some other package? We have /utils/ where goes scripts which can be useful for lots of people, and which are clean and commiter is willing to maintain it. This is packaged as spacewalk-utils, so you have to care about Requires in .spec. Then we have /scripts/ which is not packaged, so has lower barrier to entry. But still - please do not put there every script which has "spacewalk" somewhere in code. -- Miroslav Suchy Red Hat Satellite Engineering ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
[Spacewalk-devel] spacecmd wrapper "staging" scripts on github : RFC re inclusion in spacewalk?
Hi All, FYI I've pushed some spacecmd wrapper scripts to github: https://github.com/hardys/clone_release_scripts These implement a fairly generic "staging" workflow, via bash spacecmd wrapper scripts. In one case I also use (or plan to use) spacewalk-create-channel/spacewalk-clone-by-date, but they are mostly pure-spacecmd wrappers, so hopefully they may provide useful examples of scripted spacecmd usage. I'm interested in any comments - does anyone have similar stuff out there to share? Also wondering if there's any interest in including these (and other similar scripts) in spacewalk, either as part of the spacecmd package, say under /usr/share/spacecmd/scripts/, or in some other package? Steve ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel