Re: [Spacewalk-devel] Merging the bootstrap-css branch
Hey Duncan! We've had a fair amount of discussion here, and a number of folk playing with the current state of the branch. - Original Message - > > Hi astronauts > > We would like to start discussing a merge of the bootstrap-css branch. > As you may know, the name is very technology specific but the work has a > wider goal in mind. In case you haven't followed it, we prepared a blog > post: > > http://duncan.mac-vicar.com/2013/10/30/modernizing-spacewalks-user-interface/ > > So what is the state of the work? > > [x] Layout > [x] Java widgets (Nav, Toolbar, List) > [x] Perl layout > [x] Forms > [x] Prototype -> jQuery port > [x] Fontawesome icon infrastructure > [x] Spacewalk "black theme" > > Right now there is stuff we would like to fix grouped in various areas: > > [ ] Perl data list > [ ] Port all icons .gif -> fonticon > [ ] Hidden cosmetic details in pages we haven't seen yet. > [ ] JSP tags testcases [ ] Checkstyle is unhappy [ ] What about remaining PXT? While there's clearly work to do, everyone is on-board with merging as long as things *work*, even if they're still ugly. The problem with checkstyle is that it fails all our automated testing, so we wouldn't even get to junit issues. We'd also like to discuss plans for dealing with the remaining PXT pages. Getting them all converted wouldn't hold up a merge - but discussing and creating a plan for a final conversion, and who would do which pieces of it, would be important. > - The perl data list is in our TODO list. > - For the port of all .gif icons we still need to draw some replacements > and this may be an ongoing task. We are then building an equivalence map > and will use the a tool we wrote to aid on the conversion to do a > translation once the map is completed: > https://github.com/dmacvicar/spacewalk-ui-porting > (We also are using this tool to help us sanitize the html, port styles, > etc). > - Hidden cosmetic details is something that will popup as we find issues > and get feedback > - The testcases are WIP. You have seen with previous patches that we > care about the Java test cases because we are running them, and > therefore we will work on this. > > Right now having a branch is blocking another features where we want to > make use of the new css infrastructure and components, therefore it is > our wish to do a first merge as soon as possible. This does not mean > that we will stop working on it, but that we want to do the merges in > stages. Also, I would really love to have other people gving feedback, > contributing, learning and improving the new look&feel. Strong agreement. Merge, and start letting people open bugs as they find L&F issues. > I would like to discuss the previous open items. Which ones would be a > requisite for a 1st stage merge, which ones could be delayed to a second > merge in some weeks from now. Honestly, if we could get the checkstyle fixes and a first pass at The PXT Problem, I think we'd be good to go. We need more eyes, to flush out the edge-case problems. Thoughts? Grant ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] [PATCH] Fix navigation for the default snippets page
On 11/05/2013 05:07 AM, Johannes Renner wrote: On 11/04/2013 05:52 PM, Stephen Herr wrote: Hi Johannes, On 11/04/2013 10:05 AM, Johannes Renner wrote: Further I wonder if we shouldn't go to the "Default Snippets" page per default once a user navigates to Systems -> Kickstart? At least to me it appears odd to end up on the 2nd of three tabs there. You could consider to apply the second patch as well. I would vote against doing this actually. It may be unusual, but we do the same thing other places in the UI. Another example would be the 'Software' tab of a system's details. The default tab should be whichever tab people want to use the most. That may mean that we should move the default tab to be always the first tab, but I don't think we should determin which tab is default based on their current order. I'm not motivated enough to change this the other way right now either. :) I'm motivated enough while I'm at it already.. I surely agree that the default should be what people want to use the most. So assuming that you are right in the fact that in this case it is the custom snippets, here is a patch reordering those tabs. Thank you, Johannes ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel Heh, fair enough. Committed as fd207afe0ae8a9415d96fca52167f2302df8f466. Thanks! -Stephen ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] [PATCH] Fix navigation for the default snippets page
On 11/04/2013 05:52 PM, Stephen Herr wrote: > Hi Johannes, > > On 11/04/2013 10:05 AM, Johannes Renner wrote: >> Further I wonder if we shouldn't go to the "Default Snippets" page per >> default once >> a user navigates to Systems -> Kickstart? At least to me it appears odd to >> end up on >> the 2nd of three tabs there. You could consider to apply the second patch as >> well. > > I would vote against doing this actually. It may be unusual, but we do the > same thing other places > in the UI. Another example would be the 'Software' tab of a system's details. > The default tab should > be whichever tab people want to use the most. That may mean that we should > move the default tab to > be always the first tab, but I don't think we should determin which tab is > default based on their > current order. > > I'm not motivated enough to change this the other way right now either. :) I'm motivated enough while I'm at it already.. I surely agree that the default should be what people want to use the most. So assuming that you are right in the fact that in this case it is the custom snippets, here is a patch reordering those tabs. Thank you, Johannes -- SUSE LINUX Products GmbH, HRB 16746 (AG Nürnberg) GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer >From ea195aa9e88fdb3e444ab3f35311fb7d017812ec Mon Sep 17 00:00:00 2001 From: Johannes Renner Date: Tue, 5 Nov 2013 10:57:12 +0100 Subject: [PATCH] Reorder snippet tabs --- java/code/webapp/WEB-INF/nav/snippet_tabs.xml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/java/code/webapp/WEB-INF/nav/snippet_tabs.xml b/java/code/webapp/WEB-INF/nav/snippet_tabs.xml index c6c6dad..6588e91 100644 --- a/java/code/webapp/WEB-INF/nav/snippet_tabs.xml +++ b/java/code/webapp/WEB-INF/nav/snippet_tabs.xml @@ -1,12 +1,12 @@ - -/rhn/kickstart/cobbler/DefaultSnippetList.do - /rhn/kickstart/cobbler/CustomSnippetList.do + +/rhn/kickstart/cobbler/DefaultSnippetList.do + /rhn/kickstart/cobbler/CobblerSnippetList.do -- 1.8.1.4 ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
