Re: [Spacewalk-devel] [PATCH] - BZ#737697 rhn_check fails to deploy some files when the configuration channel have some other files which does not have a valid UID/GID

2011-09-23 Thread Marcelo Moreira de Mello


On Sep 22, 2011, at 2:05 PM, Jan Pazdziora wrote:

 On Thu, Sep 22, 2011 at 01:02:44PM -0300, Marcelo Moreira de Mello wrote:
 
 When scheduling a config files deployment using the webUI, rhn_check fails 
 if some file scheduled does not have a valid UID/GID into client box. 
 
 
 With current unpatched code, when this happens -- are some of the
 files deployed and some not, or is the whole deployment cancelled?
 I am not completely sure it is correct to deploy half of the files
 and not deploy the other half -- especially with the batch-oriented
 processing of scheduled actions, you don't want the machine to be
 left in an inconsistent state.

At unpatched code, the whole deployment is cancelled. It rollbacks all the 
files and none files is deployed.  When I started looking into this issue, I 
had the thinking that you. 
 
 This patch introduce to rhn_check the same behavior as rhncfg-client get 
 allowing the correct files (which have a valid UID/GID) to be deployed and 
 fails to those files which misses a valid UID/GID. 
 
 
 I assume that rhncfg-client get complains loudly about the files it
 failed to deploy. From this point of view, it is tolerable that
 rhncfg-client get would only deploy half of the files because there
 is likely person running that command which would be able to respond
 accordingly.

Yes. rhncfg-client get complains and print into the screen the files which were 
not able to be deployed. Although, we can see a lot of sysadmin using the 
rhncfg-client get at %post section in their kickstart, where they will not be 
able to see such warning too. In this case per example, we have a customer 
which expects that rhn_check works deploying half of files, but I do agree with 
you that in some other cases, we don't  want the machine to be left in an 
inconsistent state. 

I think that we can offer to the users an option to make such behavior with a 
tunable parameter. Per example, we can add a new option at rhn-actions-control 
--enable-half-deploy or --enable-unbatch which turns rhn_check able to perform 
unbatched deployments.  Please,  check the comment 
https://bugzilla.redhat.com/show_bug.cgi?id=737698#c1 regarding the customer's 
expectations. 

What do you think? 

Appreciate your help. 

Best Regards, 
mmello


 
 -- 
 Jan Pazdziora
 Principal Software Engineer, Satellite Engineering, Red Hat
 
 ___
 Spacewalk-devel mailing list
 Spacewalk-devel@redhat.com
 https://www.redhat.com/mailman/listinfo/spacewalk-devel


___
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel


Re: [Spacewalk-devel] [PATCH] - BZ#737697 rhn_check fails to deploy some files when the configuration channel have some other files which does not have a valid UID/GID

2011-09-23 Thread Jan Pazdziora
On Fri, Sep 23, 2011 at 12:09:39PM -0300, Marcelo Moreira de Mello wrote:
 
 Yes. rhncfg-client get complains and print into the screen the files which 
 were not able to be deployed. Although, we can see a lot of sysadmin using 
 the rhncfg-client get at %post section in their kickstart, where they will 
 not be able to see such warning too. In this case per example, we have a 
 customer which expects that rhn_check works deploying half of files, but I do 
 agree with you that in some other cases, we don't  want the machine to be 
 left in an inconsistent state. 
 
 I think that we can offer to the users an option to make such behavior with a 
 tunable parameter. Per example, we can add a new option at 
 rhn-actions-control --enable-half-deploy or --enable-unbatch which turns 
 rhn_check able to perform unbatched deployments.  Please,  check the comment 
 https://bugzilla.redhat.com/show_bug.cgi?id=737698#c1 regarding the 
 customer's expectations. 
 
 What do you think? 

My preference would be to keep the current rhn_check (strict)
behaviour and change the rhncfg-client get behaviour to

- default to the current behaviour on terminal and to
  strict behaviour of stdout is not a terminal;
- have command-line option to force either the strict or
  non-strict behaviour.

-- 
Jan Pazdziora
Principal Software Engineer, Satellite Engineering, Red Hat

___
Spacewalk-devel mailing list
Spacewalk-devel@redhat.com
https://www.redhat.com/mailman/listinfo/spacewalk-devel