Re: [Spacewalk-devel] [PATCH] support for weak dependencies
Hi, Am Freitag, 15. April 2011, 16:04:42 schrieb Jan Pazdziora: > On Fri, Mar 11, 2011 at 05:21:50PM +0100, Michael Calmer wrote: > > Hi, > > > > Am Mittwoch, 9. März 2011, 12:21:41 schrieb Jan Pazdziora: > > > On Wed, Mar 09, 2011 at 11:11:08AM +0100, Jan Pazdziora wrote: > > > > On Mon, Mar 07, 2011 at 01:24:54PM +0100, Michael Calmer wrote: > > > > > Hello, > > [...] > > > > Could you please investigate? Do you need list of rpms I have > > > > installed or something? > > > > I reworked the patchset: > > - removed the trailing whitespaces > > - fix the missing RPMTAG names bug (patch 0006) > > I've committed the patches to master now and tagged the respective > packages. I'm sorry it got burried for so long. np > I've shifted the schema upgrade scripts to *-1.5 directory as > Spacewalk 1.4 was already branched. I had to fix the SHA1 values > in PostgreSQL sources -- you might want to do > > ( cd schema/spacewalk && perl schema-source-sanity-check.pl ) > > to check that the schema sources look sane. It's actually necessary to > do that because the rpm build would fail otherwise. ok, thanks. -- MFG Michael Calmer -- Michael Calmer SUSE LINUX Products GmbH, Maxfeldstr. 5, D-90409 Nuernberg T: +49 (0) 911 74053 0 F: +49 (0) 911 74053575 - e-mail: michael.cal...@suse.com -- SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] [PATCH] support for weak dependencies
On Fri, Mar 11, 2011 at 05:21:50PM +0100, Michael Calmer wrote: > Hi, > > Am Mittwoch, 9. März 2011, 12:21:41 schrieb Jan Pazdziora: > > On Wed, Mar 09, 2011 at 11:11:08AM +0100, Jan Pazdziora wrote: > > > On Mon, Mar 07, 2011 at 01:24:54PM +0100, Michael Calmer wrote: > > > > Hello, > [...] > > > Could you please investigate? Do you need list of rpms I have > > > installed or something? > > I reworked the patchset: > - removed the trailing whitespaces > - fix the missing RPMTAG names bug (patch 0006) I've committed the patches to master now and tagged the respective packages. I'm sorry it got burried for so long. I've shifted the schema upgrade scripts to *-1.5 directory as Spacewalk 1.4 was already branched. I had to fix the SHA1 values in PostgreSQL sources -- you might want to do ( cd schema/spacewalk && perl schema-source-sanity-check.pl ) to check that the schema sources look sane. It's actually necessary to do that because the rpm build would fail otherwise. Thank you, -- Jan Pazdziora Principal Software Engineer, Satellite Engineering, Red Hat ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] [PATCH] support for weak dependencies
Hi, Am Mittwoch, 9. März 2011, 11:11:08 schrieb Jan Pazdziora: > On Mon, Mar 07, 2011 at 01:24:54PM +0100, Michael Calmer wrote: > > Hello, [...] > Michael, > > when I apply the patches to Spacewalk nightly and try rhnpush (of > openSUSE rpm or Spacewalk rpm), > I get the following traceback: [...] > Could you please investigate? Do you need list of rpms I have > installed or something? rpm upstream has not yet enabled the suggests and enhances flags. This is the reason, why it failes if you use rpm from Fedora/RedHat. SUSE has a patch in rpm which enables these flags. I need to try to use the integers for the RPMTAG_* values directly. I send a new patchset as soon I have implemented and tested it. -- Regards, Michael Calmer -- Michael Calmer SUSE LINUX Products GmbH, Maxfeldstr. 5, D-90409 Nuernberg T: +49 (0) 911 74053 0 F: +49 (0) 911 74053575 - e-mail: michael.cal...@suse.com -- SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] [PATCH] support for weak dependencies
On Wed, Mar 09, 2011 at 11:11:08AM +0100, Jan Pazdziora wrote: > On Mon, Mar 07, 2011 at 01:24:54PM +0100, Michael Calmer wrote: > > Hello, > > > > attached is a patch set which implement weak rpm dependencies (Recommends, > > Suggests, Supplements) into spacewalk. > > > > This patch set implements: parsing weak dependencies during spacewalk-repo- > > sync, store them into the database, show them in the WebUI and generate > > them > > into new created channel metadata. > > Michael, > > when I apply the patches to Spacewalk nightly and try rhnpush (of > openSUSE rpm or Spacewalk rpm), > I get the following traceback: [...] >File > "/usr/lib/python2.6/site-packages/spacewalk/server/importlib/headerSource.py", > line 186, in _populateTag > v = sanitizeList(header[rf]) >File "/usr/lib/python2.6/site-packages/spacewalk/common/rhn_rpm.py", line > 68, in __getitem__ > return self.hdr[name] > ValueError: unknown header tag > > Could you please investigate? Do you need list of rpms I have > installed or something? One thing which might be good to have when you submit patch sets with new features / functionality would be examples of commands or steps (CLI, API, WebUI) which would make it easy to see the feature in action, or reference to some specs page which would have the steps. In this case I just tried rhnpush as that was the easiest for me and I got stuck right at the beginning, which became kinda blocker for the whole patch set. But maybe you did not verify the change with rhnpush at all because it does not fit your workflows and you have some other "preferred" way to get the feature running and observe it, which would unblock me in reviewing it. If you and your peers could add "reproducer steps" to your submissions in the future, it would be cool. Ideally they should be fairly specific about what exact rpm file / repository / whatever was tested and is supposed to work. Thanks, -- Jan Pazdziora Principal Software Engineer, Satellite Engineering, Red Hat ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] [PATCH] support for weak dependencies
On Wed, Mar 09, 2011 at 11:11:08AM +0100, Jan Pazdziora wrote: > On Mon, Mar 07, 2011 at 01:24:54PM +0100, Michael Calmer wrote: > > Hello, > > > > attached is a patch set which implement weak rpm dependencies (Recommends, > > Suggests, Supplements) into spacewalk. > > > > This patch set implements: parsing weak dependencies during spacewalk-repo- > > sync, store them into the database, show them in the WebUI and generate > > them > > into new created channel metadata. > > Michael, > > when I apply the patches to Spacewalk nightly and try rhnpush (of > openSUSE rpm or Spacewalk rpm), > I get the following traceback: > >File > "/usr/lib/python2.6/site-packages/spacewalk/server/apacheUploadServer.py", > line 97, in _wrapper > ret = function(req) >File "/usr/share/rhn/upload_server/handlers/package_push/package_push.py", > line 134, in handler > relative_path=self.rel_package_path, org_id=self.org_id) >File > "/usr/lib/python2.6/site-packages/spacewalk/server/rhnPackageUpload.py", line > 150, in push_package > header_end=header_end, channels=channels) >File > "/usr/lib/python2.6/site-packages/spacewalk/server/importlib/mpmSource.py", > line 224, in create_package > header_end=header_end, channels=channels) >File > "/usr/lib/python2.6/site-packages/spacewalk/server/importlib/headerSource.py", > line 406, in createPackage > channels) >File > "/usr/lib/python2.6/site-packages/spacewalk/server/importlib/headerSource.py", > line 141, in populate > self._populateDependencyInformation(header) >File > "/usr/lib/python2.6/site-packages/spacewalk/server/importlib/headerSource.py", > line 161, in _populateDependencyInformation > self._populateTag(header, k, v) >File > "/usr/lib/python2.6/site-packages/spacewalk/server/importlib/headerSource.py", > line 186, in _populateTag > v = sanitizeList(header[rf]) >File "/usr/lib/python2.6/site-packages/spacewalk/common/rhn_rpm.py", line > 68, in __getitem__ > return self.hdr[name] > ValueError: unknown header tag > > Could you please investigate? Do you need list of rpms I have > installed or something? By the way, rpms I've used (rpm -Fvh over nightly installation) are at https://koji.spacewalkproject.org/koji/taskinfo?taskID=62753 https://koji.spacewalkproject.org/koji/taskinfo?taskID=62817 https://koji.spacewalkproject.org/koji/taskinfo?taskID=62749 https://koji.spacewalkproject.org/koji/taskinfo?taskID=62748 Yours, -- Jan Pazdziora Principal Software Engineer, Satellite Engineering, Red Hat ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] [PATCH] support for weak dependencies
On Mon, Mar 07, 2011 at 01:24:54PM +0100, Michael Calmer wrote: > Hello, > > attached is a patch set which implement weak rpm dependencies (Recommends, > Suggests, Supplements) into spacewalk. Michael, while running git am, I get the following warnings about trailing or mixed whitespaces. Could you please reformat the patches not to introduce them? Applying: implement weak dependencies /home/adelton/project/spacewalk/.git/rebase-apply/patch:98: trailing whitespace. warning: 1 line adds whitespace errors. Applying: generate weak-deps into primary.xml /home/adelton/project/spacewalk/.git/rebase-apply/patch:19: space before tab in indent. rhnChannelPackage chpkg left join rhnPackageRepodata prd ON prd.package_id = chpkg.package_id /home/adelton/project/spacewalk/.git/rebase-apply/patch:33: space before tab in indent. rhnChannelPackage chpkg left join rhnPackageRepodata prd ON prd.package_id = chpkg.package_id /home/adelton/project/spacewalk/.git/rebase-apply/patch:47: space before tab in indent. rhnChannelPackage chpkg left join rhnPackageRepodata prd ON prd.package_id = chpkg.package_id warning: 3 lines add whitespace errors. Applying: show weak deps in Web UI /home/adelton/project/spacewalk/.git/rebase-apply/patch:45: trailing whitespace. SELECT DISTINCT C.name, C.version, P.sense /home/adelton/project/spacewalk/.git/rebase-apply/patch:72: trailing whitespace. SELECT DISTINCT C.name, C.version, P.sense /home/adelton/project/spacewalk/.git/rebase-apply/patch:99: trailing whitespace. SELECT DISTINCT C.name, C.version, P.sense warning: 3 lines add whitespace errors. Applying: database tables for weak dependencies /home/adelton/project/spacewalk/.git/rebase-apply/patch:212: trailing whitespace. -- /home/adelton/project/spacewalk/.git/rebase-apply/patch:240: trailing whitespace. -- /home/adelton/project/spacewalk/.git/rebase-apply/patch:268: trailing whitespace. -- /home/adelton/project/spacewalk/.git/rebase-apply/patch:296: trailing whitespace. -- /home/adelton/project/spacewalk/.git/rebase-apply/patch:303: trailing whitespace. warning: squelched 25 whitespace errors warning: 30 lines add whitespace errors. Thank you, -- Jan Pazdziora Principal Software Engineer, Satellite Engineering, Red Hat ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] [PATCH] support for weak dependencies
On Mon, Mar 07, 2011 at 01:24:54PM +0100, Michael Calmer wrote: > Hello, > > attached is a patch set which implement weak rpm dependencies (Recommends, > Suggests, Supplements) into spacewalk. > > This patch set implements: parsing weak dependencies during spacewalk-repo- > sync, store them into the database, show them in the WebUI and generate them > into new created channel metadata. Michael, when I apply the patches to Spacewalk nightly and try rhnpush (of openSUSE rpm or Spacewalk rpm), I get the following traceback: File "/usr/lib/python2.6/site-packages/spacewalk/server/apacheUploadServer.py", line 97, in _wrapper ret = function(req) File "/usr/share/rhn/upload_server/handlers/package_push/package_push.py", line 134, in handler relative_path=self.rel_package_path, org_id=self.org_id) File "/usr/lib/python2.6/site-packages/spacewalk/server/rhnPackageUpload.py", line 150, in push_package header_end=header_end, channels=channels) File "/usr/lib/python2.6/site-packages/spacewalk/server/importlib/mpmSource.py", line 224, in create_package header_end=header_end, channels=channels) File "/usr/lib/python2.6/site-packages/spacewalk/server/importlib/headerSource.py", line 406, in createPackage channels) File "/usr/lib/python2.6/site-packages/spacewalk/server/importlib/headerSource.py", line 141, in populate self._populateDependencyInformation(header) File "/usr/lib/python2.6/site-packages/spacewalk/server/importlib/headerSource.py", line 161, in _populateDependencyInformation self._populateTag(header, k, v) File "/usr/lib/python2.6/site-packages/spacewalk/server/importlib/headerSource.py", line 186, in _populateTag v = sanitizeList(header[rf]) File "/usr/lib/python2.6/site-packages/spacewalk/common/rhn_rpm.py", line 68, in __getitem__ return self.hdr[name] ValueError: unknown header tag Could you please investigate? Do you need list of rpms I have installed or something? Thanks, -- Jan Pazdziora Principal Software Engineer, Satellite Engineering, Red Hat ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
Re: [Spacewalk-devel] [PATCH] support for weak dependencies
On Mon, Mar 07, 2011 at 01:24:54PM +0100, Michael Calmer wrote: > > attached is a patch set which implement weak rpm dependencies (Recommends, > Suggests, Supplements) into spacewalk. > > This patch set implements: parsing weak dependencies during spacewalk-repo- > sync, store them into the database, show them in the WebUI and generate them > into new created channel metadata. I'm taking this patch set for review. -- Jan Pazdziora Principal Software Engineer, Satellite Engineering, Red Hat ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
