Re: [Spacewalk-devel] patch to allow pgp signed rpms to be displayed in webui
Hey Shannon, sorry it took me so long. I checked your patch and I rather completely removed the package key type limit. Actually possible key types are gpg, pgp, rsa and dsa and I see no reason, why there's the limit. And if anybody signs a package with a rsa key, it shall work by default. (Honestly I didn't try to rhnpush such a package, but I believe, it shall work.) See https://git.fedorahosted.org/cgit/spacewalk.git/commit/?id=d65175ae51e6373894b64356985a65a6999e Regards, -- Tomas Lestach Red Hat Satellite Engineering, Red Hat - Original Message - > From: "Shannon Hughes" > To: spacewalk-devel@redhat.com > Sent: Tuesday, August 6, 2013 8:56:43 PM > Subject: [Spacewalk-devel] patch to allow pgp signed rpms to be displayed in > webui > > Attaching a patch for review to allow pgp signed rpms to be displayed > in > the webui. In looking at the java Package queries xml we are > specifically filtering out any rpm that does not have a key type of > 'gpg' or not signed. I am seeing a case were some rpms are being > imported successfully from puppet that are signed by pgp keys into > custom channels but the webui will not display them due to this > filter > in the query. > > I talked with Justin Sherrill who was the original author of adding > the > filter to the query and we both could not determine why this > constraint > was added. So I wanted to check with spacewalk team if there is a > historical reason otherwise I propose to allow pgp signed rpms. > > Regards, > > Shannon Hughes > Senior SEG/GSS Red Hat > > ___ > Spacewalk-devel mailing list > Spacewalk-devel@redhat.com > https://www.redhat.com/mailman/listinfo/spacewalk-devel ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
[Spacewalk-devel] patch to allow pgp signed rpms to be displayed in webui
Attaching a patch for review to allow pgp signed rpms to be displayed in the webui. In looking at the java Package queries xml we are specifically filtering out any rpm that does not have a key type of 'gpg' or not signed. I am seeing a case were some rpms are being imported successfully from puppet that are signed by pgp keys into custom channels but the webui will not display them due to this filter in the query. I talked with Justin Sherrill who was the original author of adding the filter to the query and we both could not determine why this constraint was added. So I wanted to check with spacewalk team if there is a historical reason otherwise I propose to allow pgp signed rpms. Regards, Shannon Hughes Senior SEG/GSS Red Hat >From 5e9ed31bd1fc4c32f91585ed2ca95a1ff4dc838f Mon Sep 17 00:00:00 2001 From: Shannon Hughes Date: Tue, 6 Aug 2013 14:50:24 -0400 Subject: [PATCH] allow pgp signed rpms to be displayed in webui channel listing --- .../common/db/datasource/xml/Package_queries.xml |2 +- web/html/Makefile |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/java/code/src/com/redhat/rhn/common/db/datasource/xml/Package_queries.xml b/java/code/src/com/redhat/rhn/common/db/datasource/xml/Package_queries.xml index 1971ce6..2a2f557 100644 --- a/java/code/src/com/redhat/rhn/common/db/datasource/xml/Package_queries.xml +++ b/java/code/src/com/redhat/rhn/common/db/datasource/xml/Package_queries.xml @@ -371,7 +371,7 @@ SELECT P.id AS ID, rhnPackageProvider PP on key.provider_id = PP.id left join rhnPackageKeyType KEYT on KEY.key_type_id = KEYT.id WHERE CP.channel_id = :cid and - ( KEYT.label = 'gpg' or KEYT.label is NULL) + ( KEYT.label = 'gpg' or KEYT.label = 'pgp' or KEYT.label is NULL) diff --git a/web/html/Makefile b/web/html/Makefile index ccf016f..77c463a 100644 --- a/web/html/Makefile +++ b/web/html/Makefile @@ -1,5 +1,5 @@ # Makefile for installing the html files for RHN -# +# shughes # $Id$ TOP = .. -- 1.7.7.6 ___ Spacewalk-devel mailing list Spacewalk-devel@redhat.com https://www.redhat.com/mailman/listinfo/spacewalk-devel
