[PATCH 2/3] spi/bcm63xx: add missing spi_master_{resume, suspend} calls to PM callbacks
The PM callbacks implemented by the spi-bcm63xx driver don't call
spi_master_{resume,suspend}, fix that.
Signed-off-by: Florian Fainelli flor...@openwrt.org
---
drivers/spi/spi-bcm63xx.c |4
1 file changed, 4 insertions(+)
diff --git a/drivers/spi/spi-bcm63xx.c b/drivers/spi/spi-bcm63xx.c
index af191f5..c7b5695 100644
--- a/drivers/spi/spi-bcm63xx.c
+++ b/drivers/spi/spi-bcm63xx.c
@@ -484,6 +484,8 @@ static int bcm63xx_spi_suspend(struct device *dev)
platform_get_drvdata(to_platform_device(dev));
struct bcm63xx_spi *bs = spi_master_get_devdata(master);
+ spi_master_suspend(master);
+
clk_disable(bs-clk);
return 0;
@@ -497,6 +499,8 @@ static int bcm63xx_spi_resume(struct device *dev)
clk_enable(bs-clk);
+ spi_master_resume(master);
+
return 0;
}
--
1.7.9.5
--
Don't let slow site performance ruin your business. Deploy New Relic APM
Deploy New Relic app performance management and know exactly
what is happening inside your Ruby, Python, PHP, Java, and .NET app
Try New Relic at no cost today and get our sweet Data Nerd shirt too!
http://p.sf.net/sfu/newrelic-dev2dev
___
spi-devel-general mailing list
spi-devel-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spi-devel-general
[PATCH 1/3] spi/bcm63xx: remove driver version
As Grant Likely reported, this does not make any sense in a mainline kernel
remove that driver version string.
Reported-by: Grant Likely grant.lik...@secretlab.ca
Signed-off-by: Florian Fainelli flor...@openwrt.org
---
drivers/spi/spi-bcm63xx.c |5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/spi/spi-bcm63xx.c b/drivers/spi/spi-bcm63xx.c
index a9f4049..af191f5 100644
--- a/drivers/spi/spi-bcm63xx.c
+++ b/drivers/spi/spi-bcm63xx.c
@@ -36,7 +36,6 @@
#include bcm63xx_dev_spi.h
#define PFXKBUILD_MODNAME
-#define DRV_VER0.1.2
struct bcm63xx_spi {
struct completion done;
@@ -441,8 +440,8 @@ static int __devinit bcm63xx_spi_probe(struct
platform_device *pdev)
goto out_clk_disable;
}
- dev_info(dev, at 0x%08x (irq %d, FIFOs size %d) v%s\n,
-r-start, irq, bs-fifo_size, DRV_VER);
+ dev_info(dev, at 0x%08x (irq %d, FIFOs size %d)\n,
+r-start, irq, bs-fifo_size);
return 0;
--
1.7.9.5
--
Don't let slow site performance ruin your business. Deploy New Relic APM
Deploy New Relic app performance management and know exactly
what is happening inside your Ruby, Python, PHP, Java, and .NET app
Try New Relic at no cost today and get our sweet Data Nerd shirt too!
http://p.sf.net/sfu/newrelic-dev2dev
___
spi-devel-general mailing list
spi-devel-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spi-devel-general
[PATCH 3/3] spi/bcm63xx: remove useless call to bcm63xx_spi_check_transfer()
Calling bcm63xx_spi_check_transfer() with a NULL argument does not do
anything useful that the core spi code is not doing already, remove
this superfluous call.
Signed-off-by: Florian Fainelli flor...@openwrt.org
---
drivers/spi/spi-bcm63xx.c |7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers/spi/spi-bcm63xx.c b/drivers/spi/spi-bcm63xx.c
index c7b5695..6d97047 100644
--- a/drivers/spi/spi-bcm63xx.c
+++ b/drivers/spi/spi-bcm63xx.c
@@ -169,13 +169,6 @@ static int bcm63xx_spi_setup(struct spi_device *spi)
return -EINVAL;
}
- ret = bcm63xx_spi_check_transfer(spi, NULL);
- if (ret 0) {
- dev_err(spi-dev, setup: unsupported mode bits %x\n,
- spi-mode ~MODEBITS);
- return ret;
- }
-
dev_dbg(spi-dev, %s, mode %d, %u bits/w, %u nsec/bit\n,
__func__, spi-mode MODEBITS, spi-bits_per_word, 0);
--
1.7.9.5
--
Don't let slow site performance ruin your business. Deploy New Relic APM
Deploy New Relic app performance management and know exactly
what is happening inside your Ruby, Python, PHP, Java, and .NET app
Try New Relic at no cost today and get our sweet Data Nerd shirt too!
http://p.sf.net/sfu/newrelic-dev2dev
___
spi-devel-general mailing list
spi-devel-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spi-devel-general
Re: [PATCH 1/3] Revert spi/pl022: fix spi-pl022 pm enable at probe
Hi Mark and Grant, Heard from Linus Walleij that you Mark has been helping out merging spi patches, did not know that when sending out this series. Anyway, do you guys see any issues merging this? [PATCH 1/3] Revert spi/pl022: fix spi-pl022 pm enable at probe [PATCH 2/3] Revert spi/pl022: enable runtime PM [PATCH 3/3] spi: spi-pl022: Minor simplification for runtime pm Kind regards Ulf Hansson On 28 September 2012 13:21, Ulf Hansson ulf.hans...@stericsson.com wrote: From: Ulf Hansson ulf.hans...@linaro.org This reverts commit 6887237cd7da904184dab2750504040c68f3a080. Signed-off-by: Ulf Hansson ulf.hans...@linaro.org --- drivers/spi/spi-pl022.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/spi/spi-pl022.c b/drivers/spi/spi-pl022.c index f8568b4..3f2f36c 100644 --- a/drivers/spi/spi-pl022.c +++ b/drivers/spi/spi-pl022.c @@ -2188,6 +2188,7 @@ pl022_probe(struct amba_device *adev, const struct amba_id *id) printk(KERN_INFO pl022: mapped registers from 0x%08x to %p\n, adev-res.start, pl022-virtbase); + pm_runtime_enable(dev); pm_runtime_resume(dev); pl022-clk = clk_get(adev-dev, NULL); -- 1.7.10 -- Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app performance management and know exactly what is happening inside your Ruby, Python, PHP, Java, and .NET app Try New Relic at no cost today and get our sweet Data Nerd shirt too! http://p.sf.net/sfu/newrelic-dev2dev ___ spi-devel-general mailing list spi-devel-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/spi-devel-general
Re: [PATCH 1/3] Revert spi/pl022: fix spi-pl022 pm enable at probe
On Wed, Oct 03, 2012 at 03:43:16PM +0200, Ulf Hansson wrote: Heard from Linus Walleij that you Mark has been helping out merging spi patches, did not know that when sending out this series. Anyway, do you guys see any issues merging this? [PATCH 1/3] Revert spi/pl022: fix spi-pl022 pm enable at probe [PATCH 2/3] Revert spi/pl022: enable runtime PM [PATCH 3/3] spi: spi-pl022: Minor simplification for runtime pm If someone could send the patches I'll take a look... some explanation as to why we're reverting things would be helpful. -- Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app performance management and know exactly what is happening inside your Ruby, Python, PHP, Java, and .NET app Try New Relic at no cost today and get our sweet Data Nerd shirt too! http://p.sf.net/sfu/newrelic-dev2dev ___ spi-devel-general mailing list spi-devel-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/spi-devel-general
Re: [PATCH 1/3] Revert spi/pl022: fix spi-pl022 pm enable at probe
Hi Mark, I will do a resend and include some explanation for the reverts in the cover-letter. Kind regards Ulf Hansson On 3 October 2012 15:55, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Wed, Oct 03, 2012 at 03:43:16PM +0200, Ulf Hansson wrote: Heard from Linus Walleij that you Mark has been helping out merging spi patches, did not know that when sending out this series. Anyway, do you guys see any issues merging this? [PATCH 1/3] Revert spi/pl022: fix spi-pl022 pm enable at probe [PATCH 2/3] Revert spi/pl022: enable runtime PM [PATCH 3/3] spi: spi-pl022: Minor simplification for runtime pm If someone could send the patches I'll take a look... some explanation as to why we're reverting things would be helpful. -- Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app performance management and know exactly what is happening inside your Ruby, Python, PHP, Java, and .NET app Try New Relic at no cost today and get our sweet Data Nerd shirt too! http://p.sf.net/sfu/newrelic-dev2dev ___ spi-devel-general mailing list spi-devel-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/spi-devel-general
Re: [PATCH 1/3] Revert spi/pl022: fix spi-pl022 pm enable at probe
On Wed, Oct 03, 2012 at 04:28:34PM +0200, Ulf Hansson wrote: I will do a resend and include some explanation for the reverts in the cover-letter. It'd be good if the explanation could be in the commit logs so that people reading history can understand things. -- Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app performance management and know exactly what is happening inside your Ruby, Python, PHP, Java, and .NET app Try New Relic at no cost today and get our sweet Data Nerd shirt too! http://p.sf.net/sfu/newrelic-dev2dev ___ spi-devel-general mailing list spi-devel-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/spi-devel-general
re: spi-gpio: allow operation without CS signal
Hello Michael Buesch,
The patch bfb9bcdbda9a: spi-gpio: allow operation without CS signal
from Apr 2, 2009, leads to the following Clang warning:
drivers/spi/spi-gpio.c:229:9: warning: comparison of constant
18446744073709551615 with expression of type 'unsigned int' is always
true [-Wtautological-constant-out-of-range-compare]
#define SPI_GPIO_NO_CHIPSELECT ((unsigned long)-1l)
^^
drivers/spi/spi-gpio.c
223 unsigned int cs = spi_gpio-cs_gpios[spi-chip_select];
224
225 /* set initial clock polarity */
226 if (is_active)
227 setsck(spi, spi-mode SPI_CPOL);
228
229 if (cs != SPI_GPIO_NO_CHIPSELECT) {
This is always true. SPI_GPIO_NO_CHIPSELECT is used like this through
out. The comments say that it's supposed to be used as a void pointer
but that doesn't make a lot of sense either.
230 /* SPI is normally active-low */
231 gpio_set_value(cs, (spi-mode SPI_CS_HIGH) ?
is_active : !is_active);
232 }
regards,
dan carpenter
--
Don't let slow site performance ruin your business. Deploy New Relic APM
Deploy New Relic app performance management and know exactly
what is happening inside your Ruby, Python, PHP, Java, and .NET app
Try New Relic at no cost today and get our sweet Data Nerd shirt too!
http://p.sf.net/sfu/newrelic-dev2dev
___
spi-devel-general mailing list
spi-devel-general@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/spi-devel-general
