Re: [PATCH] spi: tle620x: add missing device_remove_file()
On Thu, May 12, 2011 at 09:25:41AM +0100, Ben Dooks wrote: On 11/05/11 13:39, Axel Lin wrote: This patch includes below fixes: 1. Add missing device_remove_file for dev_attr_status_show in tle62x0_remove. 2. Fix tle62x0_probe error handling: Currently, if the error happens when ptr 0, gpio_attrs[0] is not properly remove. Signed-off-by: Axel Linaxel@gmail.com Acked-by: Ben Dooks ben-li...@fluff.org Applied, thanks. g. -- vRanger cuts backup time in half-while increasing security. With the market-leading solution for virtual backup and recovery, you get blazing-fast, flexible, and affordable data protection. Download your free trial now. http://p.sf.net/sfu/quest-d2dcopy1 ___ spi-devel-general mailing list spi-devel-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/spi-devel-general
Re: [PATCH] spi: tle620x: add missing device_remove_file()
On 11/05/11 13:39, Axel Lin wrote: This patch includes below fixes: 1. Add missing device_remove_file for dev_attr_status_show in tle62x0_remove. 2. Fix tle62x0_probe error handling: Currently, if the error happens when ptr 0, gpio_attrs[0] is not properly remove. Signed-off-by: Axel Linaxel@gmail.com Acked-by: Ben Dooks ben-li...@fluff.org --- drivers/spi/tle62x0.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/spi/tle62x0.c b/drivers/spi/tle62x0.c index a393895..32a4087 100644 --- a/drivers/spi/tle62x0.c +++ b/drivers/spi/tle62x0.c @@ -283,7 +283,7 @@ static int __devinit tle62x0_probe(struct spi_device *spi) return 0; err_gpios: - for (; ptr 0; ptr--) + while (--ptr= 0) device_remove_file(spi-dev, gpio_attrs[ptr]); device_remove_file(spi-dev,dev_attr_status_show); @@ -301,6 +301,7 @@ static int __devexit tle62x0_remove(struct spi_device *spi) for (ptr = 0; ptr st-nr_gpio; ptr++) device_remove_file(spi-dev, gpio_attrs[ptr]); + device_remove_file(spi-dev,dev_attr_status_show); kfree(st); return 0; } -- Achieve unprecedented app performance and reliability What every C/C++ and Fortran developer should know. Learn how Intel has extended the reach of its next-generation tools to help boost performance applications - inlcuding clusters. http://p.sf.net/sfu/intel-dev2devmay ___ spi-devel-general mailing list spi-devel-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/spi-devel-general
[PATCH] spi: tle620x: add missing device_remove_file()
This patch includes below fixes: 1. Add missing device_remove_file for dev_attr_status_show in tle62x0_remove. 2. Fix tle62x0_probe error handling: Currently, if the error happens when ptr 0, gpio_attrs[0] is not properly remove. Signed-off-by: Axel Lin axel@gmail.com --- drivers/spi/tle62x0.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/spi/tle62x0.c b/drivers/spi/tle62x0.c index a393895..32a4087 100644 --- a/drivers/spi/tle62x0.c +++ b/drivers/spi/tle62x0.c @@ -283,7 +283,7 @@ static int __devinit tle62x0_probe(struct spi_device *spi) return 0; err_gpios: - for (; ptr 0; ptr--) + while (--ptr = 0) device_remove_file(spi-dev, gpio_attrs[ptr]); device_remove_file(spi-dev, dev_attr_status_show); @@ -301,6 +301,7 @@ static int __devexit tle62x0_remove(struct spi_device *spi) for (ptr = 0; ptr st-nr_gpio; ptr++) device_remove_file(spi-dev, gpio_attrs[ptr]); + device_remove_file(spi-dev, dev_attr_status_show); kfree(st); return 0; } -- 1.7.1 -- Achieve unprecedented app performance and reliability What every C/C++ and Fortran developer should know. Learn how Intel has extended the reach of its next-generation tools to help boost performance applications - inlcuding clusters. http://p.sf.net/sfu/intel-dev2devmay ___ spi-devel-general mailing list spi-devel-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/spi-devel-general
