[PATCH v2] spi/spi: don't release the spi device twice
This was fixed by David Lamparter in v2.6.36-rc5 3486008 (spi: free children in spi_unregister_master, not siblings) and broken again in v2.6.37-rc1~2^2~4 during the merge of 2b9603a0 (spi: enable spi_board_info to be registered after spi_master). Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- Okay, Feng. So here is the merge fixup. drivers/spi/spi.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c index 709c836..b02d0cb 100644 --- a/drivers/spi/spi.c +++ b/drivers/spi/spi.c @@ -584,8 +584,7 @@ void spi_unregister_master(struct spi_master *master) list_del(master-list); mutex_unlock(board_lock); - dummy = device_for_each_child(master-dev.parent, master-dev, - __unregister); + dummy = device_for_each_child(master-dev, NULL, __unregister); device_unregister(master-dev); } EXPORT_SYMBOL_GPL(spi_unregister_master); -- 1.7.3.2 -- Increase Visibility of Your 3D Game App Earn a Chance To Win $500! Tap into the largest installed PC base get more eyes on your game by optimizing for Intel(R) Graphics Technology. Get started today with the Intel(R) Software Partner Program. Five $500 cash prizes are up for grabs. http://p.sf.net/sfu/intelisp-dev2dev ___ spi-devel-general mailing list spi-devel-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/spi-devel-general
Re: [PATCH v2] spi/spi: don't release the spi device twice
This was fixed by David Lamparter in v2.6.36-rc5 3486008 (spi: free children in spi_unregister_master, not siblings) and broken again in v2.6.37-rc1~2^2~4 during the merge of 2b9603a0 (spi: enable spi_board_info to be registered after spi_master). Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- - dummy = device_for_each_child(master-dev.parent, master-dev, - __unregister); + dummy = device_for_each_child(master-dev, NULL, __unregister); Signed-off-by: David Lamparter equi...@diac24.net very simple merge/rebase/forward-port breakage... Feng, can you check 2b9603a0 for whether anything else got broken? -- Increase Visibility of Your 3D Game App Earn a Chance To Win $500! Tap into the largest installed PC base get more eyes on your game by optimizing for Intel(R) Graphics Technology. Get started today with the Intel(R) Software Partner Program. Five $500 cash prizes are up for grabs. http://p.sf.net/sfu/intelisp-dev2dev ___ spi-devel-general mailing list spi-devel-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/spi-devel-general
Re: [PATCH v2] spi/spi: don't release the spi device twice
On Wed, 24 Nov 2010 00:45:20 +0800 David Lamparter equi...@diac24.net wrote: This was fixed by David Lamparter in v2.6.36-rc5 3486008 (spi: free children in spi_unregister_master, not siblings) and broken again in v2.6.37-rc1~2^2~4 during the merge of 2b9603a0 (spi: enable spi_board_info to be registered after spi_master). Signed-off-by: Sebastian Andrzej Siewior bige...@linutronix.de --- - dummy = device_for_each_child(master-dev.parent, master-dev, - __unregister); + dummy = device_for_each_child(master-dev, NULL, __unregister); Signed-off-by: David Lamparter equi...@diac24.net very simple merge/rebase/forward-port breakage... Feng, can you check 2b9603a0 for whether anything else got broken? I just checked, all other parts should be ok. Thanks, Feng -- Increase Visibility of Your 3D Game App Earn a Chance To Win $500! Tap into the largest installed PC base get more eyes on your game by optimizing for Intel(R) Graphics Technology. Get started today with the Intel(R) Software Partner Program. Five $500 cash prizes are up for grabs. http://p.sf.net/sfu/intelisp-dev2dev ___ spi-devel-general mailing list spi-devel-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/spi-devel-general
